[9] review request: 8154564: Re-enable SandboxAppTest::testJFXPanelImplicitExitApp on Mac

2016-04-21 Thread Kevin Rushforth 

Hi Chien,

Please review this simple fix to re-enable the currently-failing test on 
Mac:


https://bugs.openjdk.java.net/browse/JDK-8154564
http://cr.openjdk.java.net/~kcr/8154564/webrev.00/

It is dependent on the previous fix for 
https://bugs.openjdk.java.net/browse/JDK-8139317


-- Kevin

[9, 8u] review request: 8139317: [Mac] SecurityException when constructing WebView from JFXPanel application

2016-04-21 Thread Kevin Rushforth 

Chien,

Please review the following fix when running WebView in a JFXPanel on 
Mac with a security manager enabled:


https://bugs.openjdk.java.net/browse/JDK-8139317
http://cr.openjdk.java.net/~kcr/8139317/webrev.00/

-- Kevin

Re: CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-21 Thread Vadim Pakhnushev 

Vote: yes

On 21.04.2016 19:48, Kevin Rushforth wrote:

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who 
has contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b

RE: CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-21 Thread Murali Billa 
Vote: YES



-- Murali

-Original Message-
From: Kevin Rushforth 
Sent: Thursday, April 21, 2016 10:18 PM
To: Arunprasad Rajkumar; openjfx-dev@openjdk.java.net
Subject: CFV: New OpenJFX Committer: Arunprasad Rajkumar

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant.

Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].

Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b

Re: CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-21 Thread Kevin Rushforth 

Vote: YES


Kevin Rushforth wrote:

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who 
has contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b

CFV: New OpenJFX Committer: Arunprasad Rajkumar

2016-04-21 Thread Kevin Rushforth 

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who 
has contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b

RFR[9] S: 8154579: Pagination demo:thrown java.lang.IllegalArgumentException on console, when clicking the link of "VIEW SOURCE"

2016-04-21 Thread Morris Meyer 

Kevin and Jonathan,

Please review these changes to Ensemble8.  The View Source feature 
parses the source for Strings that look like urls, and was getting 
thrown on using String.format to build a url programmatically.


Thanks,

--morris

BUG - https://bugs.openjdk.java.net/browse/JDK-8154579
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8154579.01/

Re: 8134600 Can't pass ObservableList as argument using FXML

2016-04-21 Thread Kevin Rushforth 


> Fix is applicable for both 7 and 8.

I presume you mean both *9* and 8?

-- Kevin


Andrey Rusakov wrote:

Hello, Everyone!
Here is my small fix for FXML, JDK-8134600. 

The reason was ProxyBuilder.getUserValue where check for Collection 
class was performed before check for ArrayListWrapper class, so check 
for ArrayListWrapper class could not be fulfilled at all.
Case is covered by 
FxmlTests/test/fxmltests/functional/staticPropertyLoadTest.java#coerceSlot 
test, so there is probably no need to create a new one.

Fix is applicable for both 7 and 8.
http://cr.openjdk.java.net/~arusakov/8134600/webrev.00/

Re: 8134600 Can't pass ObservableList as argument using FXML

2016-04-21 Thread Andrey Rusakov 

Exactly

21.04.2016 18:08, Kevin Rushforth пишет:


> Fix is applicable for both 7 and 8.

I presume you mean both *9* and 8?

-- Kevin


Andrey Rusakov wrote:

Hello, Everyone!
Here is my small fix for FXML,JDK-8134600. 

The reason was ProxyBuilder.getUserValue where check for Collection 
class was performed before check for ArrayListWrapper class, so check 
for ArrayListWrapper class could not be fulfilled at all.
Case is covered by 
FxmlTests/test/fxmltests/functional/staticPropertyLoadTest.java#coerceSlot 
test, so there is probably no need to create a new one.

Fix is applicable for both 7 and 8.
http://cr.openjdk.java.net/~arusakov/8134600/webrev.00/

8134600 Can't pass ObservableList as argument using FXML

2016-04-21 Thread Andrey Rusakov 

Hello, Everyone!
Here is my small fix for FXML,JDK-8134600. 

The reason was ProxyBuilder.getUserValue where check for Collection 
class was performed before check for ArrayListWrapper class, so check 
for ArrayListWrapper class could not be fulfilled at all.
Case is covered by 
FxmlTests/test/fxmltests/functional/staticPropertyLoadTest.java#coerceSlot 
test, so there is probably no need to create a new one.

Fix is applicable for both 7 and 8.
http://cr.openjdk.java.net/~arusakov/8134600/webrev.00/

Re: [9] Review request: 8153872: Nashorn no longer needs access to com.sun.javafx.application

2016-04-21 Thread Sundararajan Athijegannathan 
+1


On 4/21/2016 10:19 AM, Mandy Chung wrote:
>> On Apr 19, 2016, at 8:25 AM, Kevin Rushforth  
>> wrote:
>>
>> Jim,
>>
>> Please review the following fix:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8153872
>> http://cr.openjdk.java.net/~kcr/8153872/webrev.00/
>>
>> This is a simple backout of the earlier fix for JDK-8153754.
> +1
>
> Glad that this dependency is eliminated.
>
> Mandy

Re: [9] Review request: 8153872: Nashorn no longer needs access to com.sun.javafx.application

2016-04-21 Thread Mandy Chung 

> On Apr 19, 2016, at 8:25 AM, Kevin Rushforth  
> wrote:
> 
> Jim,
> 
> Please review the following fix:
> 
> https://bugs.openjdk.java.net/browse/JDK-8153872
> http://cr.openjdk.java.net/~kcr/8153872/webrev.00/
> 
> This is a simple backout of the earlier fix for JDK-8153754.

+1

Glad that this dependency is eliminated.

Mandy