Re: [8] Review request: 8173139 Packager update App Store runtime rules for libjfxwebkit.dylib

[Chris Bensen]

Accidentally send out the wrong bug number. Here’s the correct one:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8174806 

Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174806/webrev.00/ 


Chris


> On Feb 15, 2017, at 9:46 AM, Chris Bensen  wrote:
> 
> Kevin,
> 
> Please review this change to no longer strip libjfxwebkit.dylib after 8u152 
> from a packaged app.
> 
> JIRA: https://bugs.openjdk.java.net/browse/8173139
> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173139/webrev.00/
> 
> Chris

Re: SimpleIntegerProperty is not a Property

[Tom Schindl]

Hi,

See that Michael had to say on that
https://twitter.com/tomsontom/status/760489595029090304

Tom

On 15.02.17 17:19, Michael Paus wrote:
> I am also wondering why this has to be so inconsistent.
> Just in case you didn't know.
> 
> You can say
> p = s.asObject();
> in your example.
> 
> LG, Michael
> 
> Am 15.02.17 um 16:59 schrieb Jens Auer:
>> Hi,
>>
>> I am wondering why SimpleIntegerProperty implements only
>> Property and not Property. This came up while using
>> ReactFx where I tried to bind a Var to a
>> SimpleIntegerProperty and it fails to compile:
>> SimpleIntegerProperty s = null;
>>
>> Var v=null;;
>> v.bindBidirectional(s);
>>
>> It turns out that this is due to the inheritance hierarchy and it also
>> prevents code like
>> javafx.beans.property.Property p;
>> javafx.beans.property.SimpleIntegerProperty s;
>>
>> p = s;
>>
>> Cheers,
>> Jens
>>
>> Jens Auer
>> (Softwareentwicklung)
>> ___
>> Unternehmensberatung H & D GmbH
>> Niederlassung Weißenthurm
>> Werftstr. 5 - 56575 Weißenthurm
>> Tel.:02637/94238 -110
>> Fax:02637/94238 -149
>> michael.zim...@h-d-gmbh.de
>> http://www.h-d-gmbh.de
>> http://www.h-d-gmbh.de/impressum.html
>> ___
>>
> 


-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

[8] Review request: 8173139 Packager update App Store runtime rules for libjfxwebkit.dylib

[Chris Bensen]

Kevin,

Please review this change to no longer strip libjfxwebkit.dylib after 8u152 
from a packaged app.

JIRA: https://bugs.openjdk.java.net/browse/8173139
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173139/webrev.00/

Chris

Re: SimpleIntegerProperty is not a Property

[Michael Paus]

I am also wondering why this has to be so inconsistent.
Just in case you didn't know.

You can say
p = s.asObject();
in your example.

LG, Michael

Am 15.02.17 um 16:59 schrieb Jens Auer:

Hi,

I am wondering why SimpleIntegerProperty implements only Property and not 
Property. This came up while using ReactFx where I tried to bind a 
Var to a SimpleIntegerProperty and it fails to compile:
SimpleIntegerProperty s = null;

Var v=null;;
v.bindBidirectional(s);

It turns out that this is due to the inheritance hierarchy and it also prevents 
code like
javafx.beans.property.Property p;
javafx.beans.property.SimpleIntegerProperty s;

p = s;

Cheers,
Jens

Jens Auer
(Softwareentwicklung)
___
Unternehmensberatung H & D GmbH
Niederlassung Weißenthurm
Werftstr. 5 - 56575 Weißenthurm
Tel.:02637/94238 -110
Fax:02637/94238 -149
michael.zim...@h-d-gmbh.de
http://www.h-d-gmbh.de
http://www.h-d-gmbh.de/impressum.html
___

SimpleIntegerProperty is not a Property

[Jens Auer]

Hi,

I am wondering why SimpleIntegerProperty implements only Property and 
not Property. This came up while using ReactFx where I tried to bind a 
Var to a SimpleIntegerProperty and it fails to compile:
SimpleIntegerProperty s = null;

Var v=null;;
v.bindBidirectional(s);

It turns out that this is due to the inheritance hierarchy and it also prevents 
code like
javafx.beans.property.Property p;
javafx.beans.property.SimpleIntegerProperty s;

p = s;

Cheers,
Jens

Jens Auer
(Softwareentwicklung)
___
Unternehmensberatung H & D GmbH
Niederlassung Weißenthurm
Werftstr. 5 - 56575 Weißenthurm
Tel.:02637/94238 -110
Fax:02637/94238 -149
michael.zim...@h-d-gmbh.de
http://www.h-d-gmbh.de
http://www.h-d-gmbh.de/impressum.html
___

Re: [9] Review request: JDK-8170979: Update for Jigsaw etc. the openFX functional tests

[Yuri Nesterenko]

Version .06:

http://cr.openjdk.java.net/~yan/8170979/webrev.06/

added, a couple more of add-exports for ControlsTests.
Updated https://bugs.openjdk.java.net/browse/JDK-8170979 :
an attached 'hg diff' for this version presumably works
better than a patch generated by webrev.

Thanks,
-yan

On 02/10/2017 01:55 PM, Yuri Nesterenko wrote:

Version .05:

http://cr.openjdk.java.net/~yan/8170979/webrev.05

added, two lines fixing some 300+ Css tests.
Updating https://bugs.openjdk.java.net/browse/JDK-8170979 --
I'll add there a plain diff. Perhaps it would be
easier to apply.

Thank,
-yan

On 01/31/2017 04:03 PM, Yuri Nesterenko wrote:

And once more:

http://cr.openjdk.java.net/~yan/8170979/webrev.04

Added:
   a port of  JDK-8138872;
   a change in javaclient/shared/screenshots/GoldenImageManager.java
to allow it find old golden images.

In the index.html there's a list of 10 files to remove after the patch
applied. Webrev script includes only 4 of them in the patch.
I tried to commit the change, jcheck has nothing against it.

We use this state of the tests (plus a closed part, and
our own svn storage for images) to run in ATR.
If not to analyze.

Thank you!
-yan

On 12/29/2016 04:38 PM, Yuri Nesterenko wrote:

And again:
http://cr.openjdk.java.net/~yan/8170979/webrev.03

(Discussion in the bug)
Unfortunately, webrev doesn't process properly
files deleted by 'hg rm' .

-yan

On 12/22/2016 12:07 PM, Yuri Nesterenko wrote:

A new version is here:
 http://cr.openjdk.java.net/~yan/8170979/webrev.01
(trailing spaces removed).
See also discussion in the bug report:
https://bugs.openjdk.java.net/browse/JDK-8170979
thank you, Kevin!

-yan

On 12/21/2016 12:19 PM, Yuri Nesterenko wrote:

A gentle reminder.
Without this change, we have to make All Test Run out of
the makeshift workspace.

Thanks,
-yan

On 12/09/2016 02:02 PM, Yuri Nesterenko wrote:

Colleagues,

please review this test bug fix:
http://cr.openjdk.java.net/~yan/8170979/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8170979


The changes are mostly in tests/functional/.

This is a merge of current testbase in
http://hg.openjdk.java.net/openjfx/9-dev/tests and whatever
we have internally. The tests should now compile and work
with Jigsaw (including b148, --add-opens), recognize already
not too new JDK directory structure, do not use Builders etc.
Small number of tests was excluded and even dropped for various
reasons.
Several suites were tested with b142-b146 and PIT build for
the recent Jigsaw update (re: --add-opens).

There are still some reservations and unanswered questions.
For instance, a hard monotonous work of creation and maintaining
of the so called golden images is up to a tester: I don't know a
good place to share them between independent teams.
A couple of the suites still won't start without a minor
reconfiguration beforehand, not always properly documented.
We intend to use this state of the tests for the next massive test
run
starting from jdk9 b150.