Re: [11] JDK-8204621: Upgrade MarlinFX to 0.9.2
I tested this on all three platforms and the updated rasterizer looks good.
I spot checked the code changes, but didn't get time to do a complete
review yet. I was mostly looking for diffs between the Java2D version
which was already reviewed, and this one.
I do have a couple comments on the new ClipShapeTest (which looks like a
nice accuracy test, btw).
1. The test runs for way too long (about 20x too long) to include in our
normal test runs. By default the entire class file (all three tests)
needs to take < 5 minutes and 2 minutes would be better. I measured the
time on 4 machines that I have and found that if you cut the number of
iterations down from 5000 to 250 it will be just about the right run
time. Then you can set the timeout to 120 seconds (the slowest test on
the slowest of my machines took about 48 seconds, so a 2 minute timeout
should be plenty).
2. Can you explain the reason for setting the following?
206 // disable static clipping setting:
207 System.setProperty("prism.marlin.clip", "false");
208 System.setProperty("prism.marlin.clip.runtime.enable",
"true");
209
210 // enable subdivider:
211 System.setProperty("prism.marlin.clip.subdivider", "true");
212
213 // disable min length check: always subdivide curves at
clip edges
214 System.setProperty("prism.marlin.clip.subdivider.minLength", "-1");
215
216 // If any curve, increase curve accuracy:
217 // curve length max error:
218 System.setProperty("prism.marlin.curve_len_err", "1e-4");
219
220 // cubic min/max error:
221 System.setProperty("prism.marlin.cubic_dec_d2", "1e-3");
222 System.setProperty("prism.marlin.cubic_inc_d1", "1e-4");
// or disabled ~ 1e-6
223
224 // quad max error:
225 System.setProperty("prism.marlin.quad_dec_d2", "5e-4");
It seems better to test with the default parameters (i.e., it makes a
better regression test that way).
3. Related to that, I think you should eliminate the following (I don't
recommend running functional tests with this set), although since you
don't do any animation, it probably doesn't matter.
227 System.setProperty("javafx.animation.fullspeed", "true");
// full speed
-- Kevin
On 6/8/2018 7:28 AM, Laurent Bourgès wrote:
Hi,
Please review this large patch to upgrade MarlinFX to 0.9.2 in OpenJFX11:
JBS: https://bugs.openjdk.java.net/browse/JDK-8198885
webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-092.0/
New version of the FX-aware jcheck
For those using the modified jcheck as indicated on the OpenJFX Wiki [1] be aware that the latest promoted build tags, which were just synced into the jfx-dev/rt repo, will require you to download a new version of the modified jcheck tool [2] to handle the new tag format. -- Kevin [1] https://wiki.openjdk.java.net/display/OpenJFX/Using+jcheck [2] http://cr.openjdk.java.net/~kcr/jcheck/bin/jcheck.py
Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop
+1 -phil. On 06/15/2018 12:31 AM, Prasanta Sadhukhan wrote: Webrev to add @since 11 to jdk.swing.interop classes (only difference from .14) http://cr.openjdk.java.net/~psadhukhan/fxswing.15/ I also tried submitting mach5 job from linux but it is failing to download jib (although I candownload from browser and ping java.se.oracle.com) ~/Downloads/mach5-1.0.1865-distribution/bin/mach5 --remote-build --email prasanta.sadhuk...@oracle.com Mach 5 Health State: green Creating job description... done Creating build ID... 2018-06-15-0626444.prasanta.sadhukhan.open Publishing source using JIB... [2018-06-15T06:26:42,870Z][INFO][main][c.o.j.s.c.SparkyClient] Downloading JIB bootstrap script Failed to download https://java.se.oracle.com/artifactory/jdk-virtual/com/oracle/java/jib/jib/3.0-SNAPSHOT/jib-3.0-SNAPSHOT.jib.sh.gz I am trying from windows but Phil told windows build does not probably built docs. Are there any easier alternative to verify the doc build? Regards Prasanta On 6/15/2018 1:56 AM, mandy chung wrote: I reviewed the module-info.java change. @since 12 is missing in jdk.unsupported.desktop module-info.java Otherwise it's fine. Does the docs build exclude jdk.unsupported.desktop? You might have confirmed that that I missed. Mandy On 6/13/18 12:48 AM, Prasanta Sadhukhan wrote: Hi Phil, All Please find modified webrev taking care of streamlining SwingInteropUtils class and handling of native window handle in LightweightFrameWrapper class by using JNI call in FX http://cr.openjdk.java.net/~psadhukhan/fxswing.14/ Corresponding CSR: https://bugs.openjdk.java.net/browse/JDK-8202175 Regards Prasanta
Re: Build OpenJFX -> ':graphics:compileDecoraNativeShadersLinux' fails
Hi Kevin,
the build works now. I'm not familar with C++, but some of the output
contained the "cc1plus" word. After a short Google search I've found
the reason. G++ was simply not installed. It seems that G++ is not
installed per default on some linux distributions. In the wiki, G++ is
listed only for the Windows build, not for the Linux build. Maybe this
should be adjusted in the wiki.
-- Michael
Am Freitag, den 15.06.2018, 08:03 -0700 schrieb Kevin Rushforth:
> We just upgraded to gradle 4.8 last week, but haven't yet updated the
> Wiki.
>
> One thing to try is to manually remove the build directory, run
> gradle
> clean, and then try it again with the --info option:
>
> $ rm -rf build
> $ gradle clean
> $ gradle --info sdk
>
> If it still doesn't work, make sure you have all of the required
> tools
> installed.
>
> -- Kevin
>
> On 6/15/2018 7:40 AM, Michael Tischer wrote:
> >
> > Hi All,
> >
> > first sorry for my bad englisch. I have tried to build OpenJFX
> > according to the instructions in the wiki. (https://wiki.openjdk.ja
> > va.n
> > et/display/OpenJFX/Building+OpenJFX)My OS is Linux Mint 18.3.
> >
> > The first thing is that the wiki says that I need gradle 4.3. ("We
> > currently use Gradle 4.3 for jfx-dev (IMPORTANT: Only this version
> > is
> > regularly tested)." But when I use gradle 4.3 the build says:
> >
> > *
> > Unsupported gradle version 4.3.1 in use.
> > Only version 4.8 is supported. Use this version at your own risk
> > *
> >
> > It seems to me that the wiki in this point is no more actually.
> >
> > Okay, so I changed the grade version to 4.8. ANT-Version is 1.8.2.
> > JDK
> > is 10.0.1
> >
> > Unfortunally, "gradle sdk" doesn't work. The build fails with this
> > output:
> >
> >
> > >
> > > Task :graphics:compileDecoraNativeShadersLinux FAILED
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task
> > ':graphics:compileDecoraNativeShadersLinux'.
> > >
> > > java.util.concurrent.ExecutionException:
> > org.gradle.process.internal.ExecException: Process 'command 'gcc''
> > finished with non-zero exit value 1
> >
> >
> >
> > Can you please help me get the build up and running?
> >
> >
> >
> > Regards
> > Michael
> >
Re: Build OpenJFX -> ':graphics:compileDecoraNativeShadersLinux' fails
We just upgraded to gradle 4.8 last week, but haven't yet updated the Wiki.
One thing to try is to manually remove the build directory, run gradle
clean, and then try it again with the --info option:
$ rm -rf build
$ gradle clean
$ gradle --info sdk
If it still doesn't work, make sure you have all of the required tools
installed.
-- Kevin
On 6/15/2018 7:40 AM, Michael Tischer wrote:
Hi All,
first sorry for my bad englisch. I have tried to build OpenJFX
according to the instructions in the wiki. (https://wiki.openjdk.java.n
et/display/OpenJFX/Building+OpenJFX)My OS is Linux Mint 18.3.
The first thing is that the wiki says that I need gradle 4.3. ("We
currently use Gradle 4.3 for jfx-dev (IMPORTANT: Only this version is
regularly tested)." But when I use gradle 4.3 the build says:
*
Unsupported gradle version 4.3.1 in use.
Only version 4.8 is supported. Use this version at your own risk
*
It seems to me that the wiki in this point is no more actually.
Okay, so I changed the grade version to 4.8. ANT-Version is 1.8.2. JDK
is 10.0.1
Unfortunally, "gradle sdk" doesn't work. The build fails with this
output:
Task :graphics:compileDecoraNativeShadersLinux FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':graphics:compileDecoraNativeShadersLinux'.
java.util.concurrent.ExecutionException:
org.gradle.process.internal.ExecException: Process 'command 'gcc''
finished with non-zero exit value 1
Can you please help me get the build up and running?
Regards
Michael
Build OpenJFX -> ':graphics:compileDecoraNativeShadersLinux' fails
Hi All,
first sorry for my bad englisch. I have tried to build OpenJFX
according to the instructions in the wiki. (https://wiki.openjdk.java.n
et/display/OpenJFX/Building+OpenJFX)My OS is Linux Mint 18.3.
The first thing is that the wiki says that I need gradle 4.3. ("We
currently use Gradle 4.3 for jfx-dev (IMPORTANT: Only this version is
regularly tested)." But when I use gradle 4.3 the build says:
*
Unsupported gradle version 4.3.1 in use.
Only version 4.8 is supported. Use this version at your own risk
*
It seems to me that the wiki in this point is no more actually.
Okay, so I changed the grade version to 4.8. ANT-Version is 1.8.2. JDK
is 10.0.1
Unfortunally, "gradle sdk" doesn't work. The build fails with this
output:
> Task :graphics:compileDecoraNativeShadersLinux FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':graphics:compileDecoraNativeShadersLinux'.
> java.util.concurrent.ExecutionException:
org.gradle.process.internal.ExecException: Process 'command 'gcc''
finished with non-zero exit value 1
Can you please help me get the build up and running?
Regards
Michael
[11] RFR : JDK-8205008 : GeneralTransform3D transform function with single Vec3d argument wrong results
Hi Kevin & All, Please review this small corrective fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8205008/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8205008 Regards, Ambarish
Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop
Great! Thanks Prasanta. Mandy On 6/15/18 5:42 AM, Prasanta Sadhukhan wrote: I confirm jdk.unsupported.desktop is not present in doc build. Regards Prasanta
Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop
On 6/15/2018 1:01 PM, Prasanta Sadhukhan wrote: Webrev to add @since 11 to jdk.swing.interop classes (only difference from .14) http://cr.openjdk.java.net/~psadhukhan/fxswing.15/ I also tried submitting mach5 job from linux but it is failing to download jib (although I candownload from browser and ping java.se.oracle.com) ~/Downloads/mach5-1.0.1865-distribution/bin/mach5 --remote-build --email prasanta.sadhuk...@oracle.com Mach 5 Health State: green Creating job description... done Creating build ID... 2018-06-15-0626444.prasanta.sadhukhan.open Publishing source using JIB... [2018-06-15T06:26:42,870Z][INFO][main][c.o.j.s.c.SparkyClient] Downloading JIB bootstrap script I am trying from windows but Phil told windows build does not probably built docs. Are there any easier alternative to verify the doc build? I confirm jdk.unsupported.desktop is not present in doc build. Regards Prasanta Regards Prasanta On 6/15/2018 1:56 AM, mandy chung wrote: I reviewed the module-info.java change. @since 12 is missing in jdk.unsupported.desktop module-info.java Otherwise it's fine. Does the docs build exclude jdk.unsupported.desktop? You might have confirmed that that I missed. Mandy On 6/13/18 12:48 AM, Prasanta Sadhukhan wrote: Hi Phil, All Please find modified webrev taking care of streamlining SwingInteropUtils class and handling of native window handle in LightweightFrameWrapper class by using JNI call in FX http://cr.openjdk.java.net/~psadhukhan/fxswing.14/ Corresponding CSR: https://bugs.openjdk.java.net/browse/JDK-8202175 Regards Prasanta
