date:20181021

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Tom Schindl

Hi,

Well we talk about JavaFX-11 but the important thing is that this bug
only happens if your Eclipse IDE is running Oracle-Java-8 ;-)

Tom

On 21.10.18 21:15, Nir Lisker wrote:
> Ah, I didn't realize you were talking about Java 8.
> 
> On Sun, Oct 21, 2018 at 10:09 PM Tom Schindl
> mailto:tom.schi...@bestsolution.at>> wrote:
> 
> Well:
> - Launch Eclipse 2018-09 with Orcale-Java-8
> - Create a maven-enabled project (I think this is important because if
>   you launch with the FX-SDK on the command line you won't run into
>   this)
> - Boom
> 
> Tom
> 
> On 21.10.18 11:35, Nir Lisker wrote:
> > Hi Tom,
> >
> > Iv'e never gotten this error. How do you reproduce this?
> >
> > - Nir
> >
> > On Thu, Oct 18, 2018 at 1:39 PM Tom Schindl
> mailto:tom.schi...@bestsolution.at>
> >  >> wrote:
> >
> >     Hi,
> >
> >     I just wanted to make you aware that if you run a JavaFX-11
> application
> >     from within Eclipse it is very likely that you'll get an error
> like
> >     this.
> >
> >     > Exception in thread "WindowsNativeRunloopThread"
> >     java.lang.NoSuchMethodError: 
> >     >     at
> >   
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> >     Method)
> >     >     at
> >   
>  javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> >     >     at
> >   
>  javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> >     Method)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     >     at java.base/java.lang.Thread.run(Thread.java:834)
> >     > Exception in thread "JavaFX Application Thread"
> >     java.lang.NullPointerException
> >     >     at
> >   
>  
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> >     >     at
> >   
>  javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> >     Method)
> >     >     at
> >   
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     >     at java.base/java.lang.Thread.run(Thread.java:834)
> >
> >     Scary right! The reason is that JavaFX-11 is loading the wrong
> glass.dll
> >     because Eclipse sets a java.library.path who also contains the
> >     JVM-Directories used to launch your Eclipse IDE.
> >
> >     The simple work-around is to add
> >     -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> >     configuration.
> >
> >     Small tiny question on the side: Wouldn't it make sense to
> version our
> >     .dlls somehow to match the release eg glass-11.dll?
> >
> >     Tom
> >
> >     --
> >     Tom Schindl, CTO
> >     BestSolution.at EDV Systemhaus GmbH
> >     Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> >     Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> >
> 
> -- 
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> 

-- 
Tom Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Review Request: JDK-8212728: Update the Eclipse classpath file for the Swing module

2018-10-21 Thread Nir Lisker

Hi,

Please review the simple fix for:

https://bugs.openjdk.java.net/browse/JDK-8212728
http://cr.openjdk.java.net/~nlisker/8212728/webrev.00/

Thanks,
Nir

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Nir Lisker

Ah, I didn't realize you were talking about Java 8.

On Sun, Oct 21, 2018 at 10:09 PM Tom Schindl 
wrote:

> Well:
> - Launch Eclipse 2018-09 with Orcale-Java-8
> - Create a maven-enabled project (I think this is important because if
>   you launch with the FX-SDK on the command line you won't run into
>   this)
> - Boom
>
> Tom
>
> On 21.10.18 11:35, Nir Lisker wrote:
> > Hi Tom,
> >
> > Iv'e never gotten this error. How do you reproduce this?
> >
> > - Nir
> >
> > On Thu, Oct 18, 2018 at 1:39 PM Tom Schindl  > > wrote:
> >
> > Hi,
> >
> > I just wanted to make you aware that if you run a JavaFX-11
> application
> > from within Eclipse it is very likely that you'll get an error like
> > this.
> >
> > > Exception in thread "WindowsNativeRunloopThread"
> > java.lang.NoSuchMethodError: 
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> > Method)
> > > at
> > javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> > > at
> > javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> > Method)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > > at java.base/java.lang.Thread.run(Thread.java:834)
> > > Exception in thread "JavaFX Application Thread"
> > java.lang.NullPointerException
> > > at
> >
>  
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> > > at
> > javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> > Method)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > > at java.base/java.lang.Thread.run(Thread.java:834)
> >
> > Scary right! The reason is that JavaFX-11 is loading the wrong
> glass.dll
> > because Eclipse sets a java.library.path who also contains the
> > JVM-Directories used to launch your Eclipse IDE.
> >
> > The simple work-around is to add
> > -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> > configuration.
> >
> > Small tiny question on the side: Wouldn't it make sense to version
> our
> > .dlls somehow to match the release eg glass-11.dll?
> >
> > Tom
> >
> > --
> > Tom Schindl, CTO
> > BestSolution.at EDV Systemhaus GmbH
> > Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> >
>
> --
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
>

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Johan Vos

Thanks, that was what I was hoping for but didn't dare to ask :)

- Johan

On Sun, Oct 21, 2018 at 8:06 PM Tom Schindl 
wrote:

> Well fixing the bug in Eclipse is the right way to address this ;-) Once
> I have time I'll provide a patch.
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=540247
>
> Tom
>
> On 21.10.18 19:45, Johan Vos wrote:
> > Hi Tom,
> >
> > Nice workaround, but what do you think needs to be done to fix it? Can
> > the java.library.path somehow be changed in a plugin or so?
> > Renaming the native libraries in JavaFX would probably solve this, but
> > that seems the wrong solution to me.
> >
> > - Johan
> >
> > On Thu, Oct 18, 2018 at 3:39 PM Tom Schindl  > > wrote:
> >
> > Hi,
> >
> > I just wanted to make you aware that if you run a JavaFX-11
> application
> > from within Eclipse it is very likely that you'll get an error like
> > this.
> >
> > > Exception in thread "WindowsNativeRunloopThread"
> > java.lang.NoSuchMethodError: 
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> > Method)
> > > at
> > javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> > > at
> > javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> > Method)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > > at java.base/java.lang.Thread.run(Thread.java:834)
> > > Exception in thread "JavaFX Application Thread"
> > java.lang.NullPointerException
> > > at
> >
>  
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> > > at
> >
>  
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> > > at
> > javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> > Method)
> > > at
> >
>  
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > > at java.base/java.lang.Thread.run(Thread.java:834)
> >
> > Scary right! The reason is that JavaFX-11 is loading the wrong
> glass.dll
> > because Eclipse sets a java.library.path who also contains the
> > JVM-Directories used to launch your Eclipse IDE.
> >
> > The simple work-around is to add
> > -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> > configuration.
> >
> > Small tiny question on the side: Wouldn't it make sense to version
> our 
> > .dlls somehow to match the release eg glass-11.dll?
> >
> > Tom
> >
> > --
> > Tom Schindl, CTO
> > BestSolution.at EDV Systemhaus GmbH
> > Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> > Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> >
>
> --
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
>

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Tom Schindl

Well fixing the bug in Eclipse is the right way to address this ;-) Once
I have time I'll provide a patch.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=540247

Tom

On 21.10.18 19:45, Johan Vos wrote:
> Hi Tom,
> 
> Nice workaround, but what do you think needs to be done to fix it? Can
> the java.library.path somehow be changed in a plugin or so?
> Renaming the native libraries in JavaFX would probably solve this, but
> that seems the wrong solution to me.
> 
> - Johan
> 
> On Thu, Oct 18, 2018 at 3:39 PM Tom Schindl  > wrote:
> 
> Hi,
> 
> I just wanted to make you aware that if you run a JavaFX-11 application
> from within Eclipse it is very likely that you'll get an error like
> this.
> 
> > Exception in thread "WindowsNativeRunloopThread"
> java.lang.NoSuchMethodError: 
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> Method)
> >     at
> javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> >     at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> Method)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     at java.base/java.lang.Thread.run(Thread.java:834)
> > Exception in thread "JavaFX Application Thread"
> java.lang.NullPointerException
> >     at
> 
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> >     at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> Method)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     at java.base/java.lang.Thread.run(Thread.java:834)
> 
> Scary right! The reason is that JavaFX-11 is loading the wrong glass.dll
> because Eclipse sets a java.library.path who also contains the
> JVM-Directories used to launch your Eclipse IDE.
> 
> The simple work-around is to add
> -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> configuration.
> 
> Small tiny question on the side: Wouldn't it make sense to version our
> .dlls somehow to match the release eg glass-11.dll?
> 
> Tom
> 
> -- 
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> 

-- 
Tom Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Johan Vos

Hi Tom,

Nice workaround, but what do you think needs to be done to fix it? Can the
java.library.path somehow be changed in a plugin or so?
Renaming the native libraries in JavaFX would probably solve this, but that
seems the wrong solution to me.

- Johan

On Thu, Oct 18, 2018 at 3:39 PM Tom Schindl 
wrote:

> Hi,
>
> I just wanted to make you aware that if you run a JavaFX-11 application
> from within Eclipse it is very likely that you'll get an error like this.
>
> > Exception in thread "WindowsNativeRunloopThread"
> java.lang.NoSuchMethodError: 
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> Method)
> > at
> javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> > at
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > at java.base/java.lang.Thread.run(Thread.java:834)
> > Exception in thread "JavaFX Application Thread"
> java.lang.NullPointerException
> > at
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> > at
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > at java.base/java.lang.Thread.run(Thread.java:834)
>
> Scary right! The reason is that JavaFX-11 is loading the wrong glass.dll
> because Eclipse sets a java.library.path who also contains the
> JVM-Directories used to launch your Eclipse IDE.
>
> The simple work-around is to add
> -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> configuration.
>
> Small tiny question on the side: Wouldn't it make sense to version our
> .dlls somehow to match the release eg glass-11.dll?
>
> Tom
>
> --
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
>

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Tom Schindl

Well:
- Launch Eclipse 2018-09 with Orcale-Java-8
- Create a maven-enabled project (I think this is important because if
  you launch with the FX-SDK on the command line you won't run into
  this)
- Boom

Tom

On 21.10.18 11:35, Nir Lisker wrote:
> Hi Tom,
> 
> Iv'e never gotten this error. How do you reproduce this?
> 
> - Nir
> 
> On Thu, Oct 18, 2018 at 1:39 PM Tom Schindl  > wrote:
> 
> Hi,
> 
> I just wanted to make you aware that if you run a JavaFX-11 application
> from within Eclipse it is very likely that you'll get an error like
> this.
> 
> > Exception in thread "WindowsNativeRunloopThread"
> java.lang.NoSuchMethodError: 
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> Method)
> >     at
> javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> >     at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> Method)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     at java.base/java.lang.Thread.run(Thread.java:834)
> > Exception in thread "JavaFX Application Thread"
> java.lang.NullPointerException
> >     at
> 
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> >     at
> 
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> >     at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native
> Method)
> >     at
> 
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> >     at java.base/java.lang.Thread.run(Thread.java:834)
> 
> Scary right! The reason is that JavaFX-11 is loading the wrong glass.dll
> because Eclipse sets a java.library.path who also contains the
> JVM-Directories used to launch your Eclipse IDE.
> 
> The simple work-around is to add
> -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> configuration.
> 
> Small tiny question on the side: Wouldn't it make sense to version our
> .dlls somehow to match the release eg glass-11.dll?
> 
> Tom
> 
> -- 
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
> 

-- 
Tom Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Re: Updated code review policies posted on OpenJFX Project Wiki

2018-10-21 Thread Nir Lisker

Hi Kevin,

I suggest to add an "areas of expertise" (modules or JBS components) to the
list of reviewers on the Code Reviews page, at least for active Reviewers,
similarly to how it is done on the Code Ownership page.
It doesn't need to have a formal function (I brought up that idea during
the spring discussion), but would help to know who to consult with when
working on some part of OpenJFX.

- Nir

On Sat, Oct 20, 2018 at 12:18 AM Kevin Rushforth 
wrote:

> The updated code review policies that we discussed last spring are now
> posted on the OpenJFX Project Wiki [1]. For the most part, we have
> effectively been following these for the past several months. This will
> formalize the policies in a way that will be easier to point new
> contributors at. If any of you have any suggestions for making it easier
> to understand, please send them our way.
>
> The executive summary is:
>
> 1. Recorded the fact that Johan and I are co-leads of the OpenJFX Project
>
> 2. Formalized the concept of a Reviewer role and recorded the initial
> list of Reviewers
>
> 3. Formalized the code review requirements:
> * simple fixes: 1"R"eviewer
> * higher-impact fixes: 2 reviewers (one of whom must be "R"eviewer)
> * new features / API changes: discus proposed changes on this list, CSR
> review (including approval by a Lead) for API changes + 2 reviewers for
> implementation
>
> 4. Formalized the streamlined GitHub code review (as long as you
> complete all review steps, including RFR email to this list, prior to PR
> being merged, there is no need for a webrev or additional review to push
> it to HG jfx-dev repo)
>
> I am working on an update to the GitHub CONTRIBUTING.md page [2] to
> align with these newly-formalized policies, primarily to help first time
> contributors, but also as a reminder for all contributors. I'll send a
> PR when ready (tomorrow or Monday).
>
> -- Kevin
>
> [1] https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews
> [2]
>
> https://github.com/javafxports/openjdk-jfx/blob/develop/.github/CONTRIBUTING.md
>
>

Re: Running JavaFX-11 applications from within Eclipse fails

2018-10-21 Thread Nir Lisker

Hi Tom,

Iv'e never gotten this error. How do you reproduce this?

- Nir

On Thu, Oct 18, 2018 at 1:39 PM Tom Schindl 
wrote:

> Hi,
>
> I just wanted to make you aware that if you run a JavaFX-11 application
> from within Eclipse it is very likely that you'll get an error like this.
>
> > Exception in thread "WindowsNativeRunloopThread"
> java.lang.NoSuchMethodError: 
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.staticScreen_getScreens(Native
> Method)
> > at
> javafx.graphics/com.sun.glass.ui.Screen.initScreens(Screen.java:412)
> > at
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:152)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > at java.base/java.lang.Thread.run(Thread.java:834)
> > Exception in thread "JavaFX Application Thread"
> java.lang.NullPointerException
> > at
> javafx.graphics/com.sun.prism.d3d.D3DPipeline.getAdapterOrdinal(D3DPipeline.java:205)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.assignScreensAdapters(QuantumToolkit.java:695)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runToolkit(QuantumToolkit.java:313)
> > at
> javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.lambda$startup$10(QuantumToolkit.java:258)
> > at
> javafx.graphics/com.sun.glass.ui.Application.lambda$run$1(Application.java:153)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
> > at
> javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:174)
> > at java.base/java.lang.Thread.run(Thread.java:834)
>
> Scary right! The reason is that JavaFX-11 is loading the wrong glass.dll
> because Eclipse sets a java.library.path who also contains the
> JVM-Directories used to launch your Eclipse IDE.
>
> The simple work-around is to add
> -Djava.library.path=C:/go-out-of-my-way-eclipse in your launch
> configuration.
>
> Small tiny question on the side: Wouldn't it make sense to version our
> .dlls somehow to match the release eg glass-11.dll?
>
> Tom
>
> --
> Tom Schindl, CTO
> BestSolution.at EDV Systemhaus GmbH
> Eduard-Bodem-Gasse 5-7. A-6020 Innsbruck
> Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
>

Re: Running JavaFX-11 applications from within Eclipse fails

Review Request: JDK-8212728: Update the Eclipse classpath file for the Swing module

Re: Running JavaFX-11 applications from within Eclipse fails

Re: Running JavaFX-11 applications from within Eclipse fails

Re: Running JavaFX-11 applications from within Eclipse fails

Re: Running JavaFX-11 applications from within Eclipse fails

Re: Running JavaFX-11 applications from within Eclipse fails

Re: Updated code review policies posted on OpenJFX Project Wiki

Re: Running JavaFX-11 applications from within Eclipse fails

9 matches

Site Navigation

Mail list logo

Footer information