Re: [Approved] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-23 Thread Johan Vos 
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar  
wrote:

> 8232158: [macOS] Fallback to command line tools if xcode is missing
> 
> 
> 
> Commits:
>  - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is 
> missing
> 
> Changes: https://git.openjdk.java.net/jfx/pull/13/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8232158
>   Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/13.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13

These things (retrieving locations and versions of OS-specific 
directories/settings and toolchains) are imho the most brittle of the whole 
end-to-end building. Mistakes here (e.g. wrong versions, wrong architectures) 
might lead to a number of almost inpredictable failures.
I 100% agree the fallback is a great idea, but I am a bit worried that this 
change is in gradle and that we don't have tests for this.



Approved by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/13

Re: [Integrated] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-23 Thread Arunprasad Rajkumar 
Changeset: ab6ea3b9
Author:Arunprasad Rajkumar 
Date:  2019-10-23 08:41:40 +
URL:   https://git.openjdk.java.net/jfx/commit/ab6ea3b9

8232158: [macOS] Fallback to command line tools if xcode is missing

Reviewed-by: kcr, jvos

! buildSrc/mac.gradle

RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

2019-10-23 Thread Jeanette Winzenburg 
The issue is that firing keyEvents on a node that is not focusOwner might 
produce false green tests, please see the issue for details.

fix for https://bugs.openjdk.java.net/browse/JDK-8231692
- added contructor taking the scene
- changed event firing to use either the target directly or inject into
scene



Commits:
 - aabea139: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into

Changes: https://git.openjdk.java.net/jfx/pull/20/files
 Webrev: https://webrevs.openjdk.java.net/jfx/20/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8231692
  Stats: 263 lines in 2 files changed: 260 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/20/head:pull/20

PR: https://git.openjdk.java.net/jfx/pull/20