Re: [Approved] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under review for Java2D. > > The updates to the `gl.h` and `glx.h` files are large, since we are many, > many years behind. > > The `*ext.h` header files were updated fairly recently, so those diffs are > not large. > > Previously we used to get the `*ext.h` headers from Khronos, but now we get > all the headers from the Mesa project. > > This reduces the number of upstream sources we need to monitor. > > I note that with this update, the `glxext.h` and `wglext.h` files are > slightly older in the Mesa bundle than in Khronos, but the differences are > not relevant to FX. > > I did a full build and test on Mac and Linux and a sanity build (with > `-PINCLUDE_ES2=true`) on Windows. I also verified that the build artifacts > are unchanged. > > As with the Java2D change, the licensing terms are the same as before, but > since we no longer get files directly from Khronos, the `opengl_fx.md` file > is gone and the `mesa3d.md` is updated as required to mention these files. > > > > Commits: > - 7a520adc: 8232210: Update Mesa 3-D Headers to version 19.2.1 > > Changes: https://git.openjdk.java.net/jfx/pull/26/files > Webrev: https://webrevs.openjdk.java.net/jfx/26/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 > Stats: 1515 lines in 8 files changed: 1076 ins; 269 del; 170 mod > Patch: https://git.openjdk.java.net/jfx/pull/26.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 Approved by prr (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/26
Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1
On Wed, 30 Oct 2019 00:43:08 GMT, Sergey Bylokhov wrote: > On Tue, 29 Oct 2019 23:05:46 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: >> >>> This PR updates the header files we use the build the OpenGL ES2 pipeline >>> to Mesa 19.2.1. See [this review >>> thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) >>> for the equivalent change that is under review for Java2D. >>> >>> The updates to the `gl.h` and `glx.h` files are large, since we are many, >>> many years behind. >>> >>> The `*ext.h` header files were updated fairly recently, so those diffs are >>> not large. >>> >>> Previously we used to get the `*ext.h` headers from Khronos, but now we get >>> all the headers from the Mesa project. >>> >>> This reduces the number of upstream sources we need to monitor. >>> >>> I note that with this update, the `glxext.h` and `wglext.h` files are >>> slightly older in the Mesa bundle than in Khronos, but the differences are >>> not relevant to FX. >>> >>> I did a full build and test on Mac and Linux and a sanity build (with >>> `-PINCLUDE_ES2=true`) on Windows. I also verified that the build artifacts >>> are unchanged. >>> >>> As with the Java2D change, the licensing terms are the same as before, but >>> since we no longer get files directly from Khronos, the `opengl_fx.md` file >>> is gone and the `mesa3d.md` is updated as required to mention these files. >>> >>> >>> >>> Commits: >>> - 7a520adc: 8232210: Update Mesa 3-D Headers to version 19.2.1 >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/26/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/26/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 >>> Stats: 1515 lines in 8 files changed: 1076 ins; 269 del; 170 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/26.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 >> >> Reviewers: @prrace, @arapte, @johanvos > > Not sure but should not the license be GPL+CP in some of these files? > Not sure but should not the license be GPL+CP in some of these files? It is not necessary. PR: https://git.openjdk.java.net/jfx/pull/26
Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1
On Tue, 29 Oct 2019 23:05:46 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > >> This PR updates the header files we use the build the OpenGL ES2 pipeline to >> Mesa 19.2.1. See [this review >> thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) >> for the equivalent change that is under review for Java2D. >> >> The updates to the `gl.h` and `glx.h` files are large, since we are many, >> many years behind. >> >> The `*ext.h` header files were updated fairly recently, so those diffs are >> not large. >> >> Previously we used to get the `*ext.h` headers from Khronos, but now we get >> all the headers from the Mesa project. >> >> This reduces the number of upstream sources we need to monitor. >> >> I note that with this update, the `glxext.h` and `wglext.h` files are >> slightly older in the Mesa bundle than in Khronos, but the differences are >> not relevant to FX. >> >> I did a full build and test on Mac and Linux and a sanity build (with >> `-PINCLUDE_ES2=true`) on Windows. I also verified that the build artifacts >> are unchanged. >> >> As with the Java2D change, the licensing terms are the same as before, but >> since we no longer get files directly from Khronos, the `opengl_fx.md` file >> is gone and the `mesa3d.md` is updated as required to mention these files. >> >> >> >> Commits: >> - 7a520adc: 8232210: Update Mesa 3-D Headers to version 19.2.1 >> >> Changes: https://git.openjdk.java.net/jfx/pull/26/files >> Webrev: https://webrevs.openjdk.java.net/jfx/26/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 >> Stats: 1515 lines in 8 files changed: 1076 ins; 269 del; 170 mod >> Patch: https://git.openjdk.java.net/jfx/pull/26.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 > > Reviewers: @prrace, @arapte, @johanvos Not sure but should not the license be GPL+CP in some of these files? PR: https://git.openjdk.java.net/jfx/pull/26
RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1
This PR updates the header files we use the build the OpenGL ES2 pipeline to Mesa 19.2.1. See [this review thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) for the equivalent change that is under review for Java2D. The updates to the `gl.h` and `glx.h` files are large, since we are many, many years behind. The `*ext.h` header files were updated fairly recently, so those diffs are not large. Previously we used to get the `*ext.h` headers from Khronos, but now we get all the headers from the Mesa project. This reduces the number of upstream sources we need to monitor. I note that with this update, the `glxext.h` and `wglext.h` files are slightly older in the Mesa bundle than in Khronos, but the differences are not relevant to FX. I did a full build and test on Mac and Linux and a sanity build (with `-PINCLUDE_ES2=true`) on Windows. I also verified that the build artifacts are unchanged. As with the Java2D change, the licensing terms are the same as before, but since we no longer get files directly from Khronos, the `opengl_fx.md` file is gone and the `mesa3d.md` is updated as required to mention these files. Commits: - 7a520adc: 8232210: Update Mesa 3-D Headers to version 19.2.1 Changes: https://git.openjdk.java.net/jfx/pull/26/files Webrev: https://webrevs.openjdk.java.net/jfx/26/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 Stats: 1515 lines in 8 files changed: 1076 ins; 269 del; 170 mod Patch: https://git.openjdk.java.net/jfx/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 PR: https://git.openjdk.java.net/jfx/pull/26
Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under review for Java2D. > > The updates to the `gl.h` and `glx.h` files are large, since we are many, > many years behind. > > The `*ext.h` header files were updated fairly recently, so those diffs are > not large. > > Previously we used to get the `*ext.h` headers from Khronos, but now we get > all the headers from the Mesa project. > > This reduces the number of upstream sources we need to monitor. > > I note that with this update, the `glxext.h` and `wglext.h` files are > slightly older in the Mesa bundle than in Khronos, but the differences are > not relevant to FX. > > I did a full build and test on Mac and Linux and a sanity build (with > `-PINCLUDE_ES2=true`) on Windows. I also verified that the build artifacts > are unchanged. > > As with the Java2D change, the licensing terms are the same as before, but > since we no longer get files directly from Khronos, the `opengl_fx.md` file > is gone and the `mesa3d.md` is updated as required to mention these files. > > > > Commits: > - 7a520adc: 8232210: Update Mesa 3-D Headers to version 19.2.1 > > Changes: https://git.openjdk.java.net/jfx/pull/26/files > Webrev: https://webrevs.openjdk.java.net/jfx/26/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232210 > Stats: 1515 lines in 8 files changed: 1076 ins; 269 del; 170 mod > Patch: https://git.openjdk.java.net/jfx/pull/26.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/26/head:pull/26 Reviewers: @prrace, @arapte, @johanvos PR: https://git.openjdk.java.net/jfx/pull/26
Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
On Tue, 29 Oct 2019 15:59:58 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier > wrote: > >> On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: >> >>> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: >>> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier wrote: > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is > always a double click. > The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in > JFXPanel ignored if another swing component has focus). > This fix introduced synthesized press-events, which is an unsafe fix for > the problem. > > The pull request introduces a new fix for the problem. > Instead of simulating new input-events, we set JavaFX Scene/Window to > focused. > We do so, by using setFocused. > When the original Swing-Focus event is called slightly later, it won't > have any side-effects, > because calling setFocused just sets the value of a boolean property. > > I've now also added a unit-test for the problem. > > > > Commits: > - 314e423c: JDK-8200224 > - 725e5fef: JDK-8200224 > > Changes: https://git.openjdk.java.net/jfx/pull/25/files > Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 > Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod > Patch: https://git.openjdk.java.net/jfx/pull/25.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 @FlorianKirmaier you still need to file a JBS issue to associate your GitHub username with your OpenJDK user ID as noted [above](#issuecomment-546883472), and per the instructions in [this message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) sent to openjfx-dev. >>> >>> @prsadhuk please review this. I will also review it (this will need two >>> reviewers). >> >> @kevinrushforth >> If created the ticket a moment ago. >> https://bugs.openjdk.java.net/browse/JDK-8233121 >> Is this okay, or is any information missing? > >> https://bugs.openjdk.java.net/browse/JDK-8233121 > > It was created in the JDK Project rather than the SKARA project (odd...the > link should have filled in the right project and component). I fixed it. Great, thanks. Some more notes on the importance of this Change. A project which uses a lot of JFXPanels for small components was basically unusable because the majority of clicks were registered as a double click. This made the software basically unusable with JavaFX11. PR: https://git.openjdk.java.net/jfx/pull/25
Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier wrote: > On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: >> >>> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >>> wrote: >>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 A side effect of JDK-8200224 is, that the first click on a JFXPanel is always a double click. The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in JFXPanel ignored if another swing component has focus). This fix introduced synthesized press-events, which is an unsafe fix for the problem. The pull request introduces a new fix for the problem. Instead of simulating new input-events, we set JavaFX Scene/Window to focused. We do so, by using setFocused. When the original Swing-Focus event is called slightly later, it won't have any side-effects, because calling setFocused just sets the value of a boolean property. I've now also added a unit-test for the problem. Commits: - 314e423c: JDK-8200224 - 725e5fef: JDK-8200224 Changes: https://git.openjdk.java.net/jfx/pull/25/files Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 >>> >>> @FlorianKirmaier you still need to file a JBS issue to associate your >>> GitHub username with your OpenJDK user ID as noted >>> [above](#issuecomment-546883472), and per the instructions in [this >>> message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) >>> sent to openjfx-dev. >> >> @prsadhuk please review this. I will also review it (this will need two >> reviewers). > > @kevinrushforth > If created the ticket a moment ago. > https://bugs.openjdk.java.net/browse/JDK-8233121 > Is this okay, or is any information missing? > https://bugs.openjdk.java.net/browse/JDK-8233121 It was created in the JDK Project rather than the SKARA project (odd...the link should have filled in the right project and component). I fixed it. PR: https://git.openjdk.java.net/jfx/pull/25
Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >> wrote: >> >>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >>> >>> A side effect of JDK-8200224 is, that the first click on a JFXPanel is >>> always a double click. >>> The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in >>> JFXPanel ignored if another swing component has focus). >>> This fix introduced synthesized press-events, which is an unsafe fix for >>> the problem. >>> >>> The pull request introduces a new fix for the problem. >>> Instead of simulating new input-events, we set JavaFX Scene/Window to >>> focused. >>> We do so, by using setFocused. >>> When the original Swing-Focus event is called slightly later, it won't have >>> any side-effects, >>> because calling setFocused just sets the value of a boolean property. >>> >>> I've now also added a unit-test for the problem. >>> >>> >>> >>> Commits: >>> - 314e423c: JDK-8200224 >>> - 725e5fef: JDK-8200224 >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/25/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 >>> Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/25.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 >> >> @FlorianKirmaier you still need to file a JBS issue to associate your GitHub >> username with your OpenJDK user ID as noted >> [above](#issuecomment-546883472), and per the instructions in [this >> message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) >> sent to openjfx-dev. > > @prsadhuk please review this. I will also review it (this will need two > reviewers). @kevinrushforth If created the ticket a moment ago. https://bugs.openjdk.java.net/browse/JDK-8233121 Is this okay, or is any information missing? PR: https://git.openjdk.java.net/jfx/pull/25
Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier > wrote: > >> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >> >> A side effect of JDK-8200224 is, that the first click on a JFXPanel is >> always a double click. >> The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in >> JFXPanel ignored if another swing component has focus). >> This fix introduced synthesized press-events, which is an unsafe fix for the >> problem. >> >> The pull request introduces a new fix for the problem. >> Instead of simulating new input-events, we set JavaFX Scene/Window to >> focused. >> We do so, by using setFocused. >> When the original Swing-Focus event is called slightly later, it won't have >> any side-effects, >> because calling setFocused just sets the value of a boolean property. >> >> I've now also added a unit-test for the problem. >> >> >> >> Commits: >> - 314e423c: JDK-8200224 >> - 725e5fef: JDK-8200224 >> >> Changes: https://git.openjdk.java.net/jfx/pull/25/files >> Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 >> Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod >> Patch: https://git.openjdk.java.net/jfx/pull/25.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 > > @FlorianKirmaier you still need to file a JBS issue to associate your GitHub > username with your OpenJDK user ID as noted [above](#issuecomment-546883472), > and per the instructions in [this > message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) > sent to openjfx-dev. @prsadhuk please review this. I will also review it (this will need two reviewers). PR: https://git.openjdk.java.net/jfx/pull/25
Re: RFR: 8200224: Multiple press event when JFXPanel gains focus
On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier wrote: > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is always > a double click. > The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in > JFXPanel ignored if another swing component has focus). > This fix introduced synthesized press-events, which is an unsafe fix for the > problem. > > The pull request introduces a new fix for the problem. > Instead of simulating new input-events, we set JavaFX Scene/Window to focused. > We do so, by using setFocused. > When the original Swing-Focus event is called slightly later, it won't have > any side-effects, > because calling setFocused just sets the value of a boolean property. > > I've now also added a unit-test for the problem. > > > > Commits: > - 314e423c: JDK-8200224 > - 725e5fef: JDK-8200224 > > Changes: https://git.openjdk.java.net/jfx/pull/25/files > Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 > Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod > Patch: https://git.openjdk.java.net/jfx/pull/25.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 @FlorianKirmaier you still need to file a JBS issue to associate your GitHub username with your OpenJDK user ID as noted [above](#issuecomment-546883472), and per the instructions in [this message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html) sent to openjfx-dev. PR: https://git.openjdk.java.net/jfx/pull/25
Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation
On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote:
> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote:
>
>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:
>>
>>> The pull request has been updated with additional changes.
>>>
>>>
>>>
>>> Added commits:
>>> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for
>>> clarification on TableColumnHeader
>>>
>>> Changes:
>>> - all: https://git.openjdk.java.net/jfx/pull/6/files
>>> - new: https://git.openjdk.java.net/jfx/pull/6/files/969ebb51..e846e51c
>>>
>>> Webrevs:
>>> - full: https://webrevs.openjdk.java.net/jfx/6/webrev.01
>>> - incr: https://webrevs.openjdk.java.net/jfx/6/webrev.00-01
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
>>> Stats: 27 lines in 3 files changed: 13 ins; 1 del; 13 mod
>>> Patch: https://git.openjdk.java.net/jfx/pull/6.diff
>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6
>>
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 608:
>>
>>> 607: protected void resizeColumnToFitContent(int maxRows) {
>>> 608: TableColumnBase tc = getTableColumn();
>>> 609: if (!tc.isResizable()) return;
>>
>> I have put the `since 14`, because if merged, it will be available in
>> OpenJFX 14 right? (It was 13 before)
>
> Correct.
The "The resulting column width for this implementation..." part might belong
in an `@implSpec` section.
PR: https://git.openjdk.java.net/jfx/pull/6
Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation
On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote:
> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote:
>
>> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg
>> wrote:
>>
>>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote:
>>>
Allright, this is a fix for JDK-8207957
Commits:
- 969ebb51: Fixing TableColumnHeaderTest
- 9d379619: Removing Tablecolumnbasehelper
- 4fe020fc: Fix javadoc for TableColumnHeader
- c422c80f: Minor modification and uni test added.
- b2bdfb5b: Change resizeColumn to protected without static in order to
be able to override
- 3b9b7903: Second option for resizeColumnToFitContent in
TableColumnHeader
- d91c56e5: First attempt to extract resizeColumnToFitContent
Changes: https://git.openjdk.java.net/jfx/pull/6/files
Webrev: https://webrevs.openjdk.java.net/jfx/6/webrev.00
Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
Stats: 523 lines in 4 files changed: 330 ins; 187 del; 6 mod
Patch: https://git.openjdk.java.net/jfx/pull/6.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6
>>>
>>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>>> line 600:
>>>
599: * expensive if the number of rows is large. Subclass can either
call this method or override it (no need to call
600: * {@code super()}) to provide their custom algorithm.
601: *
>>>
>>> see
>>> https://github.com/javafxports/openjdk-jfx/pull/289#discussion_r245482213 -
>>> I think I made a suggestion (that probably needs some native speaker's fine
>>> tuning :)
>>
>> Allright @kleopatra , I have indeed removed the TableColumn argument. It is
>> clearer now that we are resizing the TableColumn of the header.
>>
>> I have updated the description a bit but really I'm really not good at
>> method description so I'm open to all suggestions..
>
> A Draft CSR was filed here:
> [JDK-8215554](https://bugs.openjdk.java.net/browse/JDK-8215554). It will need
> to be updated once the API review is complete.
Do you think this looks good now @kleopatra @nlisker ?
PR: https://git.openjdk.java.net/jfx/pull/6
Re: RFR: 8087980: Add property to disable Monocle cursor
On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green wrote: > On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: > >> On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: >> >>> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green >>> <12861109+dellgr...@users.noreply.github.com> wrote: >>> Often on embedded systems a cursor is not a valid input modality. On some of these systems, when the javafx toolkit initialises the native hardware cursor, it produces artefacts which can be seen on screen (in the framebuffer for example). This change adds a system property "monocle.cursor.enabled" that can disable the creation of a native cursor in each of the Monocle NativePlatform implementations in favour of a NullCursor which is a no-op implementation of the NativeCursor abstract class that all native cursors have to implement. NullCursor class already existed and was being returned for some implementations like AndroidPlatform and HeadlessPlatform. This change builds upon that and conditionally returns NullCursor for all platforms. A system property "monocle.debugcursor" has also been added to turn on logging of which NativeCursor has been selected when the toolkit initialises. Commits: - cfbbc7dd: JDK-8087980: Add property to disable Monocle cursor Changes: https://git.openjdk.java.net/jfx/pull/5/files Webrev: https://webrevs.openjdk.java.net/jfx/5/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8087980 Stats: 49 lines in 8 files changed: 40 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jfx/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/5/head:pull/5 >>> >>> This has not yet been reviewed. It will need at least one reviewer with a >>> Reviewer role in the project. >>> >>> >>> >>> Disapproved by kcr (Lead). >> >> Is this PR open for review now? Or will a new PR be created? > > this is ready for review form my perspective. :) The Skara tooling bug in question has been fixed, so yes this is ready for review. PR: https://git.openjdk.java.net/jfx/pull/5
RFR: 8200224: Multiple press event when JFXPanel gains focus
Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 A side effect of JDK-8200224 is, that the first click on a JFXPanel is always a double click. The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in JFXPanel ignored if another swing component has focus). This fix introduced synthesized press-events, which is an unsafe fix for the problem. The pull request introduces a new fix for the problem. Instead of simulating new input-events, we set JavaFX Scene/Window to focused. We do so, by using setFocused. When the original Swing-Focus event is called slightly later, it won't have any side-effects, because calling setFocused just sets the value of a boolean property. I've now also added a unit-test for the problem. Commits: - 314e423c: JDK-8200224 - 725e5fef: JDK-8200224 Changes: https://git.openjdk.java.net/jfx/pull/25/files Webrev: https://webrevs.openjdk.java.net/jfx/25/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8200224 Stats: 140 lines in 2 files changed: 133 ins; 2 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/25/head:pull/25 PR: https://git.openjdk.java.net/jfx/pull/25
Re: RFR: 8087980: Add property to disable Monocle cursor
On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: > On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: > >> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green >> <12861109+dellgr...@users.noreply.github.com> wrote: >> >>> Often on embedded systems a cursor is not a valid input modality. On some >>> of these systems, when the javafx toolkit initialises the native hardware >>> cursor, it produces artefacts which can be seen on screen (in the >>> framebuffer for example). This change adds a system property >>> "monocle.cursor.enabled" that can disable the creation of a native cursor >>> in each of the Monocle NativePlatform implementations in favour of a >>> NullCursor which is a no-op implementation of the NativeCursor abstract >>> class that all native cursors have to implement. >>> >>> NullCursor class already existed and was being returned for some >>> implementations like AndroidPlatform and HeadlessPlatform. This change >>> builds upon that and conditionally returns NullCursor for all platforms. >>> >>> A system property "monocle.debugcursor" has also been added to turn on >>> logging of which NativeCursor has been selected when the toolkit >>> initialises. >>> >>> >>> >>> Commits: >>> - cfbbc7dd: JDK-8087980: Add property to disable Monocle cursor >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/5/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/5/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8087980 >>> Stats: 49 lines in 8 files changed: 40 ins; 0 del; 9 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/5.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/5/head:pull/5 >> >> This has not yet been reviewed. It will need at least one reviewer with a >> Reviewer role in the project. >> >> >> >> Disapproved by kcr (Lead). > > Is this PR open for review now? Or will a new PR be created? this is ready for review form my perspective. :) PR: https://git.openjdk.java.net/jfx/pull/5
Re: [Integrated] RFR: 8232943: Gesture support is not initialized on iOS
Changeset: dca8df4e Author:Jose Pereda Committer: Johan Vos Date: 2019-10-29 10:03:54 + URL: https://git.openjdk.java.net/jfx/commit/dca8df4e 8232943: Gesture support is not initialized on iOS Reviewed-by: jvos ! modules/javafx.graphics/src/main/native-glass/ios/GlassViewDelegate.m
Re: RFR: 8087980: Add property to disable Monocle cursor
On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: > On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> Often on embedded systems a cursor is not a valid input modality. On some of >> these systems, when the javafx toolkit initialises the native hardware >> cursor, it produces artefacts which can be seen on screen (in the >> framebuffer for example). This change adds a system property >> "monocle.cursor.enabled" that can disable the creation of a native cursor in >> each of the Monocle NativePlatform implementations in favour of a NullCursor >> which is a no-op implementation of the NativeCursor abstract class that all >> native cursors have to implement. >> >> NullCursor class already existed and was being returned for some >> implementations like AndroidPlatform and HeadlessPlatform. This change >> builds upon that and conditionally returns NullCursor for all platforms. >> >> A system property "monocle.debugcursor" has also been added to turn on >> logging of which NativeCursor has been selected when the toolkit initialises. >> >> >> >> Commits: >> - cfbbc7dd: JDK-8087980: Add property to disable Monocle cursor >> >> Changes: https://git.openjdk.java.net/jfx/pull/5/files >> Webrev: https://webrevs.openjdk.java.net/jfx/5/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8087980 >> Stats: 49 lines in 8 files changed: 40 ins; 0 del; 9 mod >> Patch: https://git.openjdk.java.net/jfx/pull/5.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/5/head:pull/5 > > This has not yet been reviewed. It will need at least one reviewer with a > Reviewer role in the project. > > > > Disapproved by kcr (Lead). Is this PR open for review now? Or will a new PR be created? PR: https://git.openjdk.java.net/jfx/pull/5
Re: [Approved] RFR: 8232943: Gesture support is not initialized on iOS
On Fri, 25 Oct 2019 09:29:16 GMT, Jose Pereda wrote: > This PR only affects iOS native code. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8232943 > > Since the `IosGestureSupport` class is only instantiated from the native > side, the proposal is to change in `ios/GlassViewDelegate.m` the use of > `FindClass` in favor of `[GlassHelper ClassForName]`, in the same way as it > is done in > [`mac/GlassViewDelegate.m`](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m#L614) > to instantiate `MacGestureSupport`. > > > > Commits: > - 49f39910: Use ClassForName instead of FindClass > > Changes: https://git.openjdk.java.net/jfx/pull/23/files > Webrev: https://webrevs.openjdk.java.net/jfx/23/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232943 > Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jfx/pull/23.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/23/head:pull/23 While the class should also be initialised by using (*env)->FindClass, it is more in line with other parts in the code (and other platforms) to use the GlassHelper for this. Approved by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/23
