RFR: 8208761: Update constant collections to use the new immutable collections
Resubmitting from before the transition to this repo. See linked issue for details. - Commits: - 440e7a88: Initial commit of 8208761 Changes: https://git.openjdk.java.net/jfx/pull/104/files Webrev: https://webrevs.openjdk.java.net/jfx/104/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8208761 Stats: 972 lines in 18 files changed: 180 ins; 279 del; 513 mod Patch: https://git.openjdk.java.net/jfx/pull/104.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/104/head:pull/104 PR: https://git.openjdk.java.net/jfx/pull/104
Re: [Integrated] RFR: 8237770: Error creating fragment phong shader on iOS
Changeset: 56267e1f Author:Jose Pereda Committer: Kevin Rushforth Date: 2020-02-01 23:41:31 + URL: https://git.openjdk.java.net/jfx/commit/56267e1f 8237770: Error creating fragment phong shader on iOS Reviewed-by: kcr ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_color.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_none.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_texture.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main0Lights.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main1Light.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main2Lights.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main3Lights.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/normalMap_none.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/normalMap_texture.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/selfIllum_none.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/selfIllum_texture.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/specular_color.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/specular_mix.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/specular_none.frag ! modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/specular_texture.frag
Re: [Integrated] RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)
Changeset: 2ab40c1c Author:Kevin Rushforth Date: 2020-02-01 14:35:47 + URL: https://git.openjdk.java.net/jfx/commit/2ab40c1c 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina) Reviewed-by: prr, jvos ! modules/javafx.graphics/src/main/native-glass/mac/GlassTouches.m
Re: [Rev 01] RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)
On Sat, 1 Feb 2020 08:38:08 GMT, Kevin Rushforth wrote: >> This is a fix for >> [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable >> the use of `CGEventTap` when running on macOS 10.15 or later. >> >> The effect of this bug is that a scary dialog is shown for all users the >> first time they run a JavaFX application and move the mouse is moved into >> the JavaFX window. It also is reported to block apps from being accepted in >> the Apple store. >> >> This bug is caused by a change in macOS 10.15 to require additional >> permissions for using CGEventTap, which JavaFX uses to track touch events. >> >> The suggested replacement API, >> `NSEvent::addLocalMonitorForEventsMatchingMask`, works just differently >> enough (it tracks events delivered to a specific view, whereas the current >> code is implemented using a global monitor and a global set of touch >> points), that it would be too risky to change it this late in the release. >> >> For openjfx14, I am proposing to disable touch events completely if running >> on macOS 10.15 (or later). This will disable the tracking of native touch >> events, but those events are not used by default on macOS anyway. For Mac >> systems with a trackpad we instead rely on macOS to do the gesture >> recognition by default, and this fix does not intefere with that >> functionality. >> >> I have verified that this avoids the dialog on macOS 10.15 and that the >> HelloGestures program still runs correctly and still recognizes trackpad >> gestures such as zoom and rotate. I also verified that the changes don't >> affect macOS 10.14 or earlier (the Event Tap code is still enabled on those >> older OS versions). >> >> See [this >> thread](https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-January/024876.html) >> on openjfx-dev for more discussion. > > The pull request has been updated with 1 additional commit. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/102
