Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES -- Jonathan (Tapped on a touch device) On Tue, 2 Jun 2020, 1:53 am Kevin Rushforth, wrote: > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. > > Jeanette is an OpenJFX community member, who has contributed 16 > changesets [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#fastegal > > [2] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40openjdk.org=author-date=Commits > > [3] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40swingempire.de=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer > >
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: YES -- Jonathan (Tapped on a touch device) On Tue, 2 Jun 2020, 1:53 am Kevin Rushforth, wrote: > I hereby nominate Jose Pereda [1] to OpenJFX Committer. > > Jose is an OpenJFX community member, who has contributed 16 changesets > [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#jpereda > > [2] > > https://github.com/openjdk/jfx/search?q=author-email%3Ajpereda%40openjdk.org=author-date=Commits > > [3] > > https://github.com/openjdk/jfx/search?q=author-email%3Ajose.pereda%40gluonhq.com=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer > >
Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes
On Thu, 28 May 2020 16:44:33 GMT, Nir Lisker wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON` >> checks. >> * Added `isStopped`, `isRunning` and `isPaused` convenience methods. >> * Added `runHandler` method to deal with running the handler. >> * Moved methods to be grouped closer to where they are used rather than by >> visibility. >> * Removed the static import for `TickCalculation`. >> * Various small subjective readability changes. >> * Behavioral changes: switching `autoReverse` and `onFinished` properties >> from "Simple" to "Base" properties; and lazily >> initializing the `cuePoints` map. >> >> ### Clip Envelopes >> * Added `MultiLoopClipEnvelope` as an intermediate parent for infinite and >> finite clip envelopes. >> * Rearranged methods order to be consistent. >> * Replaced the `checkBounds` method with a new overload of `Utils.clamp`. >> * Renamed `pos` to `cyclePos`. >> * Extracted common methods: `changedDirection` and `ticksRateChange` >> * Added internal documentation. >> >> Also corrected a typo in `TicksCalculation` and added an explanation for an >> animation test. > > Nir Lisker has updated the pull request with a new target base due to a merge > or a rebase. The pull request now > contains 10 commits: > - Merge branch 'master' into > 8242523_Update_the_Animation_and_ClipEnvelope_classes > - Synch whitespace fix > - Addressed review comments > - Removing cycleNumber for now > - Fix typo in TicksCalculation & add an explanation for an animation test > - Initial push of 8242523 > - Comment out erroneous test > - Fix IndefiniteCycleDuration test > - Fixed single loop test > - Initial commit Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/196
RE: CFV: New OpenJFX Committer: Jose Pereda
Vote: Yes Regards, Ambarish
RE: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES Regards, Ambarish
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: YES Regards, Ajit > On 01-Jun-2020, at 7:23 PM, Kevin Rushforth > wrote: > > I hereby nominate Jose Pereda [1] to OpenJFX Committer. > > Jose is an OpenJFX community member, who has contributed 16 changesets [2][3] > to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#jpereda > > [2] > https://github.com/openjdk/jfx/search?q=author-email%3Ajpereda%40openjdk.org=author-date=Commits > > [3] > https://github.com/openjdk/jfx/search?q=author-email%3Ajose.pereda%40gluonhq.com=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer >
Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES Regards, Ajit > On 01-Jun-2020, at 7:22 PM, Kevin Rushforth > wrote: > > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. > > Jeanette is an OpenJFX community member, who has contributed 16 changesets > [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#fastegal > > [2] > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40openjdk.org=author-date=Commits > > [3] > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40swingempire.de=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer >
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 13:21:08 GMT, Kevin Rushforth wrote: >> That's a good question. The commented line was there from the first commit >> (in 9, changeset 9231:241f9696e3ad, >> https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason >> on why it was disabled. >> libffi is also built in the GraalVM project, and that line is not commented >> there. >> >> @sashamatveev or @kevinrushforth do you remember the reason? > > No, I don't remember. No, I don't remember as well. - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote: > It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. Here is the crosslink to the JBS issue: https://bugs.openjdk.java.net/browse/JDK-8246204 - PR: https://git.openjdk.java.net/jfx/pull/243
RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
It seems to be sufficient to add "intel" as an additional vendor to the list in the X11GLFactory class. Tests pass and my own application also works with the new build. - Commit messages: - Fix JDK-8246204 Changes: https://git.openjdk.java.net/jfx/pull/243/files Webrev: https://webrevs.openjdk.java.net/jfx/243/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246204 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/243/head:pull/243 PR: https://git.openjdk.java.net/jfx/pull/243
Re: [Rev 01] RFR: 8208169: can not print selected pages of web page
> Print function of WebEngine.java ignores page range setting and prints given > number of pages starting from first page, > which is the root cause of this issue. To fix it, put check for page ranges > and if it available, use it for printing > pages otherwise print all pages as usual. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: added manual test - Changes: - all: https://git.openjdk.java.net/jfx/pull/222/files - new: https://git.openjdk.java.net/jfx/pull/222/files/39748929..75a0362f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/222/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/222/webrev.00-01 Stats: 153 lines in 1 file changed: 153 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/222/head:pull/222 PR: https://git.openjdk.java.net/jfx/pull/222
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: YES - Nir On Mon, Jun 1, 2020 at 5:09 PM Johan Vos wrote: > Vote: YES > > On Mon, Jun 1, 2020 at 4:03 PM Kevin Rushforth > > wrote: > > > I hereby nominate Jose Pereda [1] to OpenJFX Committer. > > > > Jose is an OpenJFX community member, who has contributed 16 changesets > > [2][3] to OpenJFX. > > > > Votes are due by June 15, 2020. > > > > Only current OpenJFX Committers [4] are eligible to vote on this > > nomination. Votes must be cast in the open by replying to this mailing > > list. > > > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > > Committer is described in [6]. > > > > Thanks. > > > > -- Kevin > > > > > > [1] https://openjdk.java.net/census#jpereda > > > > [2] > > > > > https://github.com/openjdk/jfx/search?q=author-email%3Ajpereda%40openjdk.org=author-date=Commits > > > > [3] > > > > > https://github.com/openjdk/jfx/search?q=author-email%3Ajose.pereda%40gluonhq.com=author-date=Commits > > > > [4] https://openjdk.java.net/census#openjfx > > > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > > > [6] https://openjdk.java.net/projects#project-committer > > > > >
Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES - Nir On Mon, Jun 1, 2020 at 4:52 PM Kevin Rushforth wrote: > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. > > Jeanette is an OpenJFX community member, who has contributed 16 > changesets [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#fastegal > > [2] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40openjdk.org=author-date=Commits > > [3] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40swingempire.de=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer > >
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: YES On Mon, Jun 1, 2020 at 4:03 PM Kevin Rushforth wrote: > I hereby nominate Jose Pereda [1] to OpenJFX Committer. > > Jose is an OpenJFX community member, who has contributed 16 changesets > [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#jpereda > > [2] > > https://github.com/openjdk/jfx/search?q=author-email%3Ajpereda%40openjdk.org=author-date=Commits > > [3] > > https://github.com/openjdk/jfx/search?q=author-email%3Ajose.pereda%40gluonhq.com=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer > >
Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES On Mon, Jun 1, 2020 at 4:00 PM Kevin Rushforth wrote: > I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. > > Jeanette is an OpenJFX community member, who has contributed 16 > changesets [2][3] to OpenJFX. > > Votes are due by June 15, 2020. > > Only current OpenJFX Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. Nomination to a project > Committer is described in [6]. > > Thanks. > > -- Kevin > > > [1] https://openjdk.java.net/census#fastegal > > [2] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40openjdk.org=author-date=Commits > > [3] > > https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40swingempire.de=author-date=Commits > > [4] https://openjdk.java.net/census#openjfx > > [5] https://openjdk.java.net/bylaws#lazy-consensus > > [6] https://openjdk.java.net/projects#project-committer > >
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: yes -phil
Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: yes -phil
Re: CFV: New OpenJFX Committer: Jose Pereda
Vote: YES -- Kevin On 6/1/2020 6:53 AM, Kevin Rushforth wrote: I hereby nominate Jose Pereda [1] to OpenJFX Committer.
CFV: New OpenJFX Committer: Jose Pereda
I hereby nominate Jose Pereda [1] to OpenJFX Committer. Jose is an OpenJFX community member, who has contributed 16 changesets [2][3] to OpenJFX. Votes are due by June 15, 2020. Only current OpenJFX Committers [4] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [5]. Nomination to a project Committer is described in [6]. Thanks. -- Kevin [1] https://openjdk.java.net/census#jpereda [2] https://github.com/openjdk/jfx/search?q=author-email%3Ajpereda%40openjdk.org=author-date=Commits [3] https://github.com/openjdk/jfx/search?q=author-email%3Ajose.pereda%40gluonhq.com=author-date=Commits [4] https://openjdk.java.net/census#openjfx [5] https://openjdk.java.net/bylaws#lazy-consensus [6] https://openjdk.java.net/projects#project-committer
Re: CFV: New OpenJFX Committer: Jeanette Winzenburg
Vote: YES -- Kevin On 6/1/2020 6:52 AM, Kevin Rushforth wrote: I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer.
CFV: New OpenJFX Committer: Jeanette Winzenburg
I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer. Jeanette is an OpenJFX community member, who has contributed 16 changesets [2][3] to OpenJFX. Votes are due by June 15, 2020. Only current OpenJFX Committers [4] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [5]. Nomination to a project Committer is described in [6]. Thanks. -- Kevin [1] https://openjdk.java.net/census#fastegal [2] https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40openjdk.org=author-date=Commits [3] https://github.com/openjdk/jfx/search?q=author-email%3Afastegal%40swingempire.de=author-date=Commits [4] https://openjdk.java.net/census#openjfx [5] https://openjdk.java.net/bylaws#lazy-consensus [6] https://openjdk.java.net/projects#project-committer
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 12:54:28 GMT, Johan Vos wrote: >> modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h >> line 53: >> >>> 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION >>> 53: #ifndef _MSC_VER >>> 54: #define FFI_TARGET_HAS_COMPLEX_TYPE >> >> In the original release of [libffi >> 3.2.1](https://github.com/libffi/libffi/releases/tag/v3.2.1), this line is >> not >> commented. which means it was commented in JavaFX. I cannot trace when and >> why was it commented. Should it be reasoned >> to whether enable it or not ? > > That's a good question. The commented line was there from the first commit > (in 9, changeset 9231:241f9696e3ad, > https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on > why it was disabled. > libffi is also built in the GraalVM project, and that line is not commented > there. > > @sashamatveev or @kevinrushforth do you remember the reason? No, I don't remember. - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 09:54:23 GMT, Ambarish Rapte wrote: >> - Updated libffi to 3.3. > > modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h > line 53: > >> 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION >> 53: #ifndef _MSC_VER >> 54: #define FFI_TARGET_HAS_COMPLEX_TYPE > > In the original release of [libffi > 3.2.1](https://github.com/libffi/libffi/releases/tag/v3.2.1), this line is > not > commented. which means it was commented in JavaFX. I cannot trace when and > why was it commented. Should it be reasoned > to whether enable it or not ? That's a good question. The commented line was there from the first commit (in 9, changeset 9231:241f9696e3ad, https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on why it was disabled. libffi is also built in the GraalVM project, and that line is not commented there. @sashamatveev or @kevinrushforth do you remember the reason? - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h line 53: > 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION > 53: #ifndef _MSC_VER > 54: #define FFI_TARGET_HAS_COMPLEX_TYPE In the original release of libffi 3.2.1, this line is not commented. which means it was commented in JavaFX. I cannot trace when and why was it commented. Should it be reasoned to whether enable it or not ? - PR: https://git.openjdk.java.net/jfx/pull/242
