Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling
On Fri, 4 Dec 2020 10:46:27 GMT, Frederic Thevenet wrote: >> Not yet. I took a quick look, and this is helpful in pointing out where the >> problem is, but I don't know whether it is the right solution to simply >> round the transform values when rendering the cache to the screen. > > Hi, > > Is there anything I can do to help get this moving forward again? > > As mentioned before, I agree the proposed fix might be simply be addressing > the symptoms rather than the root cause and I'm willing to keep working on it > but I'd really appreciate a second opinion and some insights as to where to > direct my attention if this fix proves to be not enough. > > For what it's worth, I've been living with this fix on my dev machine for a > while now, and it does provide the expected relief to the underlying issue, > without me noticing any obvious regressions, neither visually nor > performance-wise (I haven't run any targeted benchmarks, though). > > With JDK-8199592 fixed, I think it'd be great if we could tackle all of the > scaling issues in 16 (might be getting a bit late now, though) I hope to take a look at this, along with other pending reviews, early next week. There is still some time to get this into 16 if we can find a robust fix. - PR: https://git.openjdk.java.net/jfx/pull/308
Re: RFR: 8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina [v2]
On Thu, 3 Dec 2020 17:39:08 GMT, Kevin Rushforth wrote: >> This is a proposed fix for the bug where the Apple system menubar is >> initially non-responsive on macOS 10.15 and later after a JavaFX application >> has started up. The end user can workaround this by switching to some other >> application and then back to the JavaFX app, but there is no known >> workaround that the application developer can use. >> >> JavaFX is using a non-standard approach to creating the system menus, and >> seems likely that some change in macOS 10.15 means that this no longer works >> the same as in previous versions of macOS. We have had problems with >> application startup on macOS in the past that affected the system menubar: >> see [JDK-8123430](https://bugs.openjdk.java.net/browse/JDK-8123430) and >> [JDK-8093743](https://bugs.openjdk.java.net/browse/JDK-8093743). >> >> The solution is to deactivate and then reactivate the application after the >> app has initially been made active, but before any window is initialized and >> before the system menu is populated. >> >> I pushed this as two commits: one with the fix and one with some temporary >> verbose debug print statements. I will remove the print statements prior to >> the formal review, but wanted to leave them in for now in case someone >> wanted to test them, and ran into an issue (the debug print statements could >> help isolate any problems). >> >> I have tested this on macOS 10.14, 10.15, and 11 (Big Sur). It will need >> additional testing. >> >> The only drawback I see with this approach is that there can be a very brief >> flash when launching the JavaFX app from a terminal window as the FX >> application activates, deactivates, and reactivates. > > Kevin Rushforth has updated the pull request incrementally with one > additional commit since the last revision: > > Address review comments modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java line 103: > 101: private final CountDownLatch reactivationLatch = new > CountDownLatch(1); > 102: > 103: // Spin up a nested even loop waiting for the app reactivation event I just spotted a typo in this comment: even --> event I'll wait to see if there are suggested changes from other reviewers, and then fix this. - PR: https://git.openjdk.java.net/jfx/pull/361
Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling
On Wed, 21 Oct 2020 12:35:34 GMT, Kevin Rushforth wrote: >> Hello, >> Did anyone get a chance to look into this? >> Thanks! > > Not yet. I took a quick look, and this is helpful in pointing out where the > problem is, but I don't know whether it is the right solution to simply round > the transform values when rendering the cache to the screen. Hi, Is there anything I can do to help get this moving forward again? As mentioned before, I agree the proposed fix might be simply be addressing the symptoms rather than the root cause and I'm willing to keep working on it but I'd really appreciate a second opinion and some insights as to where to direct my attention if this fix proves to be not enough. For what it's worth, I've been living with this fix on my dev machine for a while now, and it does provide the expected relief to the underlying issue, without me noticing any obvious regressions, neither visually nor performance-wise (I haven't run any targeted benchmarks, though). With JDK-8199592 fixed, I think it'd be great if we could tackle all of the scaling issues in 16 (might be getting a bit late now, though) - PR: https://git.openjdk.java.net/jfx/pull/308
