[jfx17] RFR: 8271230: Remove obsolete test classes and data files from 3DViewer sample
Remove the obsolete `apps/samples/3DViewer/src/test` directory from the 3DViewer sample, including two test classes that don't run and a set of data files that won't load. This is a follow-on cleanup bug to [JDK-8269259](https://bugs.openjdk.java.net/browse/JDK-8269259). NOTE: this is targeted to `jfx17`. - Commit messages: - 8271230: Remove obsolete test classes and data files from 3DViewer sample Changes: https://git.openjdk.java.net/jfx/pull/587/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=587&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271230 Stats: 7167 lines in 16 files changed: 0 ins; 7167 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/587.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/587/head:pull/587 PR: https://git.openjdk.java.net/jfx/pull/587
Re: [jfx17] RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]
On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß wrote: >> * Expand the `Property.bind` and `Property.bindBidirectional` documentation >> * Change the name of the formal parameter of `Property.bind` to "source" >> (currently, it is inconsistently named "observable", "rawObservable" or >> "newObservable") > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > changes as per review I think it might be better to expand the scope of the issue to not only include the documentation changes, but also the implementation changes as discussed in this PR. In this case, I will mark this as a Draft PR and target it to `master` instead. I think content bindings should also be addressed, because the problem is basically the same as for regular bindings. - PR: https://git.openjdk.java.net/jfx/pull/533
Re: [jfx17] RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]
On Sat, 24 Jul 2021 12:56:32 GMT, Michael Strauß wrote: > I think it might be better to expand the scope of the issue to not only > include the documentation changes, but also the implementation changes as > discussed in this PR. In this case, I will mark this as a Draft PR and target > it to `master` instead. I think there is some benefit in getting the documentation changes done earlier (in 17), but if you prefer to do the implementation at the same time, then go ahead and retarget this to `master` for 18 and move it to Draft. Or you can create a new Draft PR if you prefer. Since this PR was marked as `rfr` it will continue to send RFR emails to the alias (which is fine, but if you prefer to avoid the noise then creating a new Draft PR will avoid that). The title and description of the bug will need to change, since it will no longer be just a documentation bug. > I think content bindings should also be addressed, because the problem is > basically the same as for regular bindings. Yes, that's a good point. In which case that's another argument for addressing both documentation and implementation for both regular and content bindings in 18. - PR: https://git.openjdk.java.net/jfx/pull/533
Integrated: Merge jfx17
Merge `jfx17` branch into `master`. - Commit messages: - Merge jfx17 - 8270839: Remove deprecated implementation methods from Scene - 8269374: Menu inoperable after setting stage to second monitor - Merge - 8270838: Remove deprecated protected access members from DateTimeStringConverter - 8270479: WebKit 612.1 build fails with Visual Studio 2017 - 8188027: List/TableCell: must not fire event in startEdit if already editing - 8269639: [macos] Calling stage.setY(0) twice causes wrong popups location - 8269638: Property methods, setters, and getters in printing API should be final - Merge - ... and 5 more: https://git.openjdk.java.net/jfx/compare/d5401095...d433bcde The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.java.net/jfx/pull/588/files Stats: 286793 lines in 5731 files changed: 175700 ins; 68294 del; 42799 mod Patch: https://git.openjdk.java.net/jfx/pull/588.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/588/head:pull/588 PR: https://git.openjdk.java.net/jfx/pull/588
Integrated: Merge jfx17
On Sat, 24 Jul 2021 13:10:30 GMT, Kevin Rushforth wrote: > Merge `jfx17` branch into `master`. This pull request has now been integrated. Changeset: 071828a2 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/071828a200faa9fc1bf22ff6098e5892e6426aa7 Stats: 165 lines in 16 files changed: 63 ins; 0 del; 102 mod Merge - PR: https://git.openjdk.java.net/jfx/pull/588
Content binding API
There has been some discussion in this PR https://github.com/openjdk/jfx/pull/533 on the semantics of unidirectional and bidirectional bindings. I think we've come to the understanding that unidirectional and bidirectional bindings cannot be meaningfully used at the same time, and such usage should be specified to be illegal and fail fast. I think the same argument is true for content bindings, which should mirror the semantics of regular bindings. 1. Let's look at the API of regular bindings: void bind(ObservableValue) void unbind() void bindBidirectional(Property) void unbindBidirectional(Property) It makes intuitive sense that unbind() does not take an argument, because there can only be a single unidirectional binding at a time, while unbindBidirectional(Property) needs to know which bidirectional binding should be unbound. 2. Now let's look at the API of content bindings: void bindContent(ObservableList) void unbindContent(Object) void bindContentBidirectional(ObservableList) void unbindContentBidirectional(Object) It's a bit unclear why unbindContent(Object) requires an argument, let alone of type Object. Mirroring regular bindings, we could potentially introduce a new method unbindContent() without an argument, and deprecate the other method not for removal. In the case of unbindContentBidirectional(Object), I'm not sure why the method doesn't accept an argument of type ObservableList. Can someone educate me if there is a reason for this seeming inconsistency with bindContentBidirectional(ObservableList)?` If there is no reason for the Object argument, "fixing" this would obviously be more problematic because it would be a binary-incompatible change.
Java FX dark theme
Hi all, I am using some CSS rules to create a "dark theme". Is it possible to change the color of the window? As you can see in this picture I have a dark theme but the window border is white. can I change that color? Thank you. Davide
JavaFX tray icon.
Hi guys, will we ever see a tray icon support in JavaFX? I'm trying to style my tray icon PopupMenu with AWT but sincerely I'm not able to do it. Hope that JavaFX will support tray icon soon. Is there some hope to see tray icon in Java FX? Thanks Davide
Re: RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's
On Sat, 24 Jul 2021 02:59:52 GMT, Alexander Matveev wrote: > Fixed by not failing initialization if DSERR_NODRIVER is returned, which will > be return if device is not present at all. Fixed format initialization even > if DirectSound device was not created in case if audio device will arrive > after playback started. Since we already handle correctly device arrival > after playback started, audio will resume if device is enabled or USB audio > card is plugged back. Due to lack of access to USB audio device, it was > tested by disabling sound card via Device Manager, then starting playback > (video plays, but not audio) and then enabling device and once enabled audio > will start playing. The linux test fails since https://github.com/openjdk/jfx/commit/b0d158629ed5f9c92cbcc39a7099f2d37e34ecf7 doesn't seem to be applied to this branch. - PR: https://git.openjdk.java.net/jfx/pull/586
Re: RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's
On Sat, 24 Jul 2021 02:59:52 GMT, Alexander Matveev wrote: > Fixed by not failing initialization if DSERR_NODRIVER is returned, which will > be return if device is not present at all. Fixed format initialization even > if DirectSound device was not created in case if audio device will arrive > after playback started. Since we already handle correctly device arrival > after playback started, audio will resume if device is enabled or USB audio > card is plugged back. Due to lack of access to USB audio device, it was > tested by disabling sound card via Device Manager, then starting playback > (video plays, but not audio) and then enabling device and once enabled audio > will start playing. @sashamatveev Can you merge in the latest upstream master into your branch? That should fix the test failures as well as being easier to test. - PR: https://git.openjdk.java.net/jfx/pull/586
Re: Java FX dark theme
Hi, As the picture did not made it through i can only guess that we talk about the window trim who is controlled by the OS and so JavaFX has no control how it is drawn. So the „solution“ is to use a StageStyle.UNDECORATED and draw a trim with min/max/close yourself, implement window resizer,... I‘ve put the word solution in quotes because once you do that you loose many native festures like snapping to other windows or desktop edges. I gave a talk last year where i talk a bit about this stuff - https://m.youtube.com/watch?v=NusKg2ZWnrg the stuff you are interested in starts around minute 9:20 Tom Von meinem iPhone gesendet > Am 24.07.2021 um 18:14 schrieb Davide Perini : > > Hi all, > I am using some CSS rules to create a "dark theme". > > Is it possible to change the color of the window? > > > > As you can see in this picture I have a dark theme but the window border is > white. can I change that color? > > Thank you. > Davide
