Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels

2021-08-06 Thread Thiago Milczarek Sayao
On Fri, 6 Aug 2021 05:30:39 GMT, Pankaj Bansal  wrote:

> I will look at this. Meanwhile, could you please write an automated system 
> test for this?

Sure, I would provide it, but in the past drag and drop tests were not 
possible. Any ideas?

-

PR: https://git.openjdk.java.net/jfx/pull/599


Formatter of LocalDateTimeStringConverter

2021-08-06 Thread Nir Lisker
I'm looking at [1]. The logic to create the formatter seems fishy. First, a
formatter is created. Then, if dateStyle is null, it tries to create a new
formatter that has its year digits fixed.  However, this ignores the
created formatter. Is this correct behavior and it's just the flow control
that is off?

[1]
https://github.com/openjdk/jfx/blob/ba61a17307d48d373fd8faa169ed16821e81c0fd/modules/javafx.base/src/main/java/javafx/util/converter/LocalDateTimeStringConverter.java#L261


Re: Enhancements for JavaFX 18

2021-08-06 Thread dev . infeo
+1. Implementing the system tray api in JavaFX and not relying on AWT would be 
nice thing.

On Wed, Aug 4, 2021 at 3:54 PM Sebastian Stenzel <
sebastian.stenzel at gmail.com 
https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev> wrote:

> +1 for a proper system tray api
>
> > Am 04.08.2021 um 16:47 schrieb Scott Palmer  > https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev>:
> >
> > +1 to that.
> >
> > I would also like to see some progress with system tray support and
> microphone & webcam access.
> >
> > Scott
> >
> >> On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg <
> fastegal at swingempire.de 
> https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev> wrote:
> >>
> >> 
> >> my suggestion would be the longstanding commit-edit-on-focus-lost -
> solved by an enhancement to the editing api on virtualized controls
> >>
> >> -- Jeanette
> >>
> >> Zitat von Kevin Rushforth  >> https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev>:
> >>
> >>> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
> and enhancement requests for JavaFX 18. It's the summer, so there may be
> delays as some people are out at various times (including me), but I would
> like to get some of the outstanding enhancement requests moving over the
> next few weeks.
> >>>
> >>> Specifically, I'd like to see the following proceed:
> >>>
> >>> * Transparent backgrounds in WebView
> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547
> >>> PR: https://github.com/openjdk/jfx/pull/563
> >>>
> >>> * Add DirectionalLight
> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921
> >>> PR: https://github.com/openjdk/jfx/pull/548
> >>>
> >>> * CSS pseudoclasses :focus-visible and :focus-within
> >>> https://bugs.openjdk.java.net/browse/JDK-8268225
> >>> PR: https://github.com/openjdk/jfx/pull/475
> >>>
> >>> * Improve property system to facilitate correct usage (minus the
> binary incompatible API change)
> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642
> >>> PR: https://github.com/openjdk/jfx/pull/590 (Draft)
> >>>
> >>> And maybe the following:
> >>>
> >>> * Add CSS themes as a first-class concept (need a consensus on how to
> proceed)
> >>>
> >>> * Undecorated interactive stage style (still in early discussion, but
> the concept looks interesting and useful)
> >>>
> >>> There are probably others I'm forgetting.
> >>>
> >>> Each of the above should be discussed in their own thread on
> openjfx-dev rather than a reply to this thread.
> >>>
> >>> -- Kevin
> >>
> >>
> >>
> >
>