Re: Enhancements for JavaFX 18

[Johan Vos]

I think we (everyone committing/reviewing in openjdk/jfx) did a great job
with the 17-work: an impressive amount of old and annoying bugs are fixed.
For 18 and beyond, I believe we have to keep working on those old issues --
at least if they are still relevant.
Also, I am 100% ok with the list of issues Kevin mentioned that need to be
moved forward now.

Apart from that, I want to have support for Metal and Wayland in JavaFX 18.

- Johan

On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth 
wrote:

> Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
> and enhancement requests for JavaFX 18. It's the summer, so there may be
> delays as some people are out at various times (including me), but I
> would like to get some of the outstanding enhancement requests moving
> over the next few weeks.
>
> Specifically, I'd like to see the following proceed:
>
> * Transparent backgrounds in WebView
> JBS: https://bugs.openjdk.java.net/browse/JDK-8090547
> PR: https://github.com/openjdk/jfx/pull/563
>
> * Add DirectionalLight
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234921
> PR: https://github.com/openjdk/jfx/pull/548
>
> * CSS pseudoclasses :focus-visible and :focus-within
> https://bugs.openjdk.java.net/browse/JDK-8268225
> PR: https://github.com/openjdk/jfx/pull/475
>
> * Improve property system to facilitate correct usage (minus the binary
> incompatible API change)
> JBS: https://bugs.openjdk.java.net/browse/JDK-8268642
> PR: https://github.com/openjdk/jfx/pull/590 (Draft)
>
> And maybe the following:
>
> * Add CSS themes as a first-class concept (need a consensus on how to
> proceed)
>
> * Undecorated interactive stage style (still in early discussion, but
> the concept looks interesting and useful)
>
> There are probably others I'm forgetting.
>
> Each of the above should be discussed in their own thread on openjfx-dev
> rather than a reply to this thread.
>
> -- Kevin
>
>
>

Re: Enhancements for JavaFX 18

[Pedro Duque Vieira]

I've filed the bug a long time ago so I can't remember exactly the bug ID
or the title I gave it.

Do you want me to file a new one? Do you want me to attach sample images (I
think you need to do some work around to attach images to a javafx bug
report?)?

Thanks Philip

On Mon, Aug 9, 2021 at 4:06 PM Philip Race  wrote:

> That would be a separate piece of work.  I can't imagine much if any
> overlap.
> Is there a useful bug ID for what you are referring to ?
> The glyph images come from DirectWrite on Windows so I am not sure if
> there's something specific ..
>
> -phil.
>
> On 8/9/21 3:44 AM, Pedro Duque Vieira wrote:
>
> Hi!
>
> @Phil Race  If you're going to tackle font
> rendering, would it also be possible to work on Windows font rendering? I
> find that Windows font rendering is generally much worse than Mac's.
>
> One example is, for instance, trying to render "Segoe UI" (the Windows
> default font) , or "Segoe UI Light"  font (or whatever variant) with a big
> font size. The font appears pixelated..
>
> Thanks,
>
>
>> +1. It is something I intend to get to for 18.
>
>
> -phil.
>
>
> On 8/4/21 1:10 PM, Kirill Grouchnikov wrote:
>> > May I humbly suggest fixing font rendering color fringe issues on macOS
>
>
> --
> Pedro Duque Vieira - https://www.pixelduke.com
>
>
>

-- 
Pedro Duque Vieira - https://www.pixelduke.com

[jfx17] Integrated: 8271485: Javadoc "Method Summary" table is misaligned if overridden JDK method has {@inheritDoc} tag

[Kevin Rushforth]

On Thu, 29 Jul 2021 16:18:24 GMT, Kevin Rushforth  wrote:

> As noted in the JBS bug report, the javadoc-generated HTML table for a class 
> is messed up if any method is overridden from a core JDK class and has the 
> `{@inheritDoc}` tag. For example, the following taken from the 
> [Background](https://github.com/openjdk/jfx/blob/jfx17/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java#L622)
>  class provokes this bug:
> 
> 
> /**
>  * {@inheritDoc}
>  */
> @Override public boolean equals(Object o) {
> 
> 
> The proposed fix is to stop generating javadocs for overridden methods with 
> no spec change. This matches how the JDK docs have been generated since JDK 
> 10. See [JDK-8157000](https://bugs.openjdk.java.net/browse/JDK-8157000). This 
> is done by running `javadoc` with the `--override-methods=summary` option.
> 
> There is no useful information generated for such overridden methods 
> regardless of whether or not they use the `{@inheritDoc}` tag, so this fix 
> also addresses the problem of having methods with no description.
> 
> See the attached "before" and "after" images.
> 
> Before:
> 
> ![javadoc-before](https://user-images.githubusercontent.com/34689748/127527754-ae5c529a-8c49-47a2-b595-5e423f5c9c49.png)
> 
> After:
> 
> ![javadoc-after](https://user-images.githubusercontent.com/34689748/127527789-c97c4689-154f-4ed0-a4a1-5dfdfde0d9d2.png)

This pull request has now been integrated.

Changeset: fbeb0bbd
Author:Kevin Rushforth 
URL:   
https://git.openjdk.java.net/jfx/commit/fbeb0bbd1cec6616b01e8376013f833a191124e8
Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod

8271485: Javadoc "Method Summary" table is misaligned if overridden JDK method 
has {@inheritDoc} tag

Do not generate javadocs for overridden methods with no spec change

Reviewed-by: aghaisas, arapte

-

PR: https://git.openjdk.java.net/jfx/pull/593

RFR: Merge jfx17

[Kevin Rushforth]

Merge `jfx17` branch into `master`.

-

Commit messages:
 - Merge jfx17
 - 8271485: Javadoc "Method Summary" table is misaligned if overridden JDK 
method has {@inheritDoc} tag
 - 8250590: Classes and methods in the javafx.css package are missing 
documentation

The merge commit only contains trivial merges, so no merge-specific webrevs 
have been generated.

Changes: https://git.openjdk.java.net/jfx/pull/600/files
  Stats: 588 lines in 34 files changed: 515 ins; 4 del; 69 mod
  Patch: https://git.openjdk.java.net/jfx/pull/600.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/600/head:pull/600

PR: https://git.openjdk.java.net/jfx/pull/600

Re: RFR: Merge jfx17 [v2]

[Kevin Rushforth]

> Merge `jfx17` branch into `master`.

Kevin Rushforth has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains 20 additional commits 
since the last revision:

 - Merge jfx17
 - 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent 
libjfxmedia_qtkit
   
   Reviewed-by: kcr
 - Merge
 - 8253351: MediaPlayer does not display an mp4 if there no speakers connected 
to the PC's
   
   Reviewed-by: jvos, kcr
 - 8240506: TextFieldSkin/Behavior: misbehavior on switching skin
   
   Reviewed-by: mhanl, arapte
 - Merge
 - 8270839: Remove deprecated implementation methods from Scene
   
   Reviewed-by: arapte, aghaisas
 - 8269374: Menu inoperable after setting stage to second monitor
   
   Reviewed-by: kcr, arapte
 - Merge
 - 8270838: Remove deprecated protected access members from 
DateTimeStringConverter
   
   Reviewed-by: kcr, aghaisas
 - ... and 10 more: https://git.openjdk.java.net/jfx/compare/5d3e3ad5...8ad579b6

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/600/files
  - new: https://git.openjdk.java.net/jfx/pull/600/files/8ad579b6..8ad579b6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=600&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=600&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/600.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/600/head:pull/600

PR: https://git.openjdk.java.net/jfx/pull/600

Integrated: Merge jfx17

[Kevin Rushforth]

On Tue, 10 Aug 2021 12:43:50 GMT, Kevin Rushforth  wrote:

> Merge `jfx17` branch into `master`.

This pull request has now been integrated.

Changeset: 20079b13
Author:Kevin Rushforth 
URL:   
https://git.openjdk.java.net/jfx/commit/20079b1340c966779f383a60e56c962f3d5ff5e2
Stats: 588 lines in 34 files changed: 515 ins; 4 del; 69 mod

Merge

-

PR: https://git.openjdk.java.net/jfx/pull/600

Re: Enhancements for JavaFX 18

[Thiago Milczarek Sayão]

Hi Johan,

Would you prefer a pure Wayland backend or support it with gdk/GTK on top
of the current glass backend?

Cheers

Em ter, 10 de ago de 2021 07:52, Johan Vos  escreveu:

> I think we (everyone committing/reviewing in openjdk/jfx) did a great job
> with the 17-work: an impressive amount of old and annoying bugs are fixed.
> For 18 and beyond, I believe we have to keep working on those old issues --
> at least if they are still relevant.
> Also, I am 100% ok with the list of issues Kevin mentioned that need to be
> moved forward now.
>
> Apart from that, I want to have support for Metal and Wayland in JavaFX 18.
>
> - Johan
>
> On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth <
> kevin.rushfo...@oracle.com>
> wrote:
>
> > Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
> > and enhancement requests for JavaFX 18. It's the summer, so there may be
> > delays as some people are out at various times (including me), but I
> > would like to get some of the outstanding enhancement requests moving
> > over the next few weeks.
> >
> > Specifically, I'd like to see the following proceed:
> >
> > * Transparent backgrounds in WebView
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8090547
> > PR: https://github.com/openjdk/jfx/pull/563
> >
> > * Add DirectionalLight
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8234921
> > PR: https://github.com/openjdk/jfx/pull/548
> >
> > * CSS pseudoclasses :focus-visible and :focus-within
> > https://bugs.openjdk.java.net/browse/JDK-8268225
> > PR: https://github.com/openjdk/jfx/pull/475
> >
> > * Improve property system to facilitate correct usage (minus the binary
> > incompatible API change)
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8268642
> > PR: https://github.com/openjdk/jfx/pull/590 (Draft)
> >
> > And maybe the following:
> >
> > * Add CSS themes as a first-class concept (need a consensus on how to
> > proceed)
> >
> > * Undecorated interactive stage style (still in early discussion, but
> > the concept looks interesting and useful)
> >
> > There are probably others I'm forgetting.
> >
> > Each of the above should be discussed in their own thread on openjfx-dev
> > rather than a reply to this thread.
> >
> > -- Kevin
> >
> >
> >
>

Re: Enhancements for JavaFX 18

[Kevin Rushforth]

Johan can comment on the details, but I think that is a matter of 
investigation.


As with the AWT work which is under discussion, there are two related, 
but different deliverables that should be looked at:


1. Running the existing JavaFX GTK port on Wayland in X11 compatibility mode
2. A native JavaFX Wayland port

For both of them, we need a solution to the same "robot" problems that 
AWT and other libraries face (there is no standard way to control the 
mouse or to read pixels from the screen).


The fact that we already use GTK for most things should make #2 easier, 
and it might be able to share a lot of the code, but it very likely will 
need to be its ow backend, since it can't use X11.


In thinking out loud, one thing to consider might be to have a single 
glass GTK platform with different native libraries for Wayland and X11, 
since we already have that support to handle gtk2 and gtk3. Maybe 
something like:


gtk2 (legacy and only for X11)
gtk3-x11
gtk3-wayland
gtk4-x11
gtk4-wayland

Not sure whether that makes sense or not.

I imagine that 1 should be feasible in the JavaFX 18 time frame. A 
native Wayland port will be a lot of work, but since JavaFX already uses 
GTK for most things, it should be significantly less work than AWT will be.


-- Kevin


On 8/10/2021 8:24 AM, Thiago Milczarek Sayão wrote:

Hi Johan,

Would you prefer a pure Wayland backend or support it with gdk/GTK on top
of the current glass backend?

Cheers

Em ter, 10 de ago de 2021 07:52, Johan Vos  escreveu:


I think we (everyone committing/reviewing in openjdk/jfx) did a great job
with the 17-work: an impressive amount of old and annoying bugs are fixed.
For 18 and beyond, I believe we have to keep working on those old issues --
at least if they are still relevant.
Also, I am 100% ok with the list of issues Kevin mentioned that need to be
moved forward now.

Apart from that, I want to have support for Metal and Wayland in JavaFX 18.

- Johan

On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth <
kevin.rushfo...@oracle.com>
wrote:


Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
and enhancement requests for JavaFX 18. It's the summer, so there may be
delays as some people are out at various times (including me), but I
would like to get some of the outstanding enhancement requests moving
over the next few weeks.

Specifically, I'd like to see the following proceed:

* Transparent backgrounds in WebView
JBS: https://bugs.openjdk.java.net/browse/JDK-8090547
PR: https://github.com/openjdk/jfx/pull/563

* Add DirectionalLight
JBS: https://bugs.openjdk.java.net/browse/JDK-8234921
PR: https://github.com/openjdk/jfx/pull/548

* CSS pseudoclasses :focus-visible and :focus-within
https://bugs.openjdk.java.net/browse/JDK-8268225
PR: https://github.com/openjdk/jfx/pull/475

* Improve property system to facilitate correct usage (minus the binary
incompatible API change)
JBS: https://bugs.openjdk.java.net/browse/JDK-8268642
PR: https://github.com/openjdk/jfx/pull/590 (Draft)

And maybe the following:

* Add CSS themes as a first-class concept (need a consensus on how to
proceed)

* Undecorated interactive stage style (still in early discussion, but
the concept looks interesting and useful)

There are probably others I'm forgetting.

Each of the above should be discussed in their own thread on openjfx-dev
rather than a reply to this thread.

-- Kevin

Re: [External] : Re: Enhancements for JavaFX 18

[Kevin Rushforth]

I think having prototypes of both a Metal pipeline and native Wayland 
would be good in the JavaFX 18 time frame.


We hope to have something to share on Metal in a month or so. The JavaFX 
Metal pipeline can leverage some of the work done for Java2D in the 
Lanai project.


I'll let Johan comment on what he is thinking of for Wayland. As I 
mentioned in another thread, this will be a lot of work (although not as 
much as AWT / Swing / Java2D).


-- Kevin


On 8/10/2021 3:46 AM, Johan Vos wrote:
I think we (everyone committing/reviewing in openjdk/jfx) did a great 
job with the 17-work: an impressive amount of old and annoying bugs 
are fixed.
For 18 and beyond, I believe we have to keep working on those old 
issues -- at least if they are still relevant.
Also, I am 100% ok with the list of issues Kevin mentioned that need 
to be moved forward now.


Apart from that, I want to have support for Metal and Wayland in 
JavaFX 18.


- Johan

On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth 
mailto:kevin.rushfo...@oracle.com>> wrote:


Now that JavaFX 17 is in RDP2, we can turn more attention to bug
fixes
and enhancement requests for JavaFX 18. It's the summer, so there
may be
delays as some people are out at various times (including me), but I
would like to get some of the outstanding enhancement requests moving
over the next few weeks.

Specifically, I'd like to see the following proceed:

* Transparent backgrounds in WebView
JBS: https://bugs.openjdk.java.net/browse/JDK-8090547

PR: https://github.com/openjdk/jfx/pull/563



* Add DirectionalLight
JBS: https://bugs.openjdk.java.net/browse/JDK-8234921

PR: https://github.com/openjdk/jfx/pull/548



* CSS pseudoclasses :focus-visible and :focus-within
https://bugs.openjdk.java.net/browse/JDK-8268225

PR: https://github.com/openjdk/jfx/pull/475



* Improve property system to facilitate correct usage (minus the
binary
incompatible API change)
JBS: https://bugs.openjdk.java.net/browse/JDK-8268642

PR: https://github.com/openjdk/jfx/pull/590


(Draft)

And maybe the following:

* Add CSS themes as a first-class concept (need a consensus on how to
proceed)

* Undecorated interactive stage style (still in early discussion, but
the concept looks interesting and useful)

There are probably others I'm forgetting.

Each of the above should be discussed in their own thread on
openjfx-dev
rather than a reply to this thread.

-- Kevin

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels

[Kevin Rushforth]

On 8/7/2021 11:56 AM, Pankaj Bansal wrote:

On Fri, 6 Aug 2021 20:44:23 GMT, Thiago Milczarek Sayao  
wrote:


I will look at this. Meanwhile, could you please write an automated system test 
for this?

Sure, I would provide it, but in the past drag and drop tests were not 
possible. Any ideas?

I think it should be possible to write an automated testcase in this case. Find 
center of window, move mouse to the location and do mouse click (without 
release). Then move mouse out of window to some location. Afterwards, get the 
pixel color at mouse location and do mouse release. Looks like it should be 
possible. Please let me know if there is some problem, I will also try to write 
one on my end.


If this does turn out to be too complex, we can file a new JBS issue to 
track adding an automated test. In which case, a manual test could be 
added as part of this PR.


-- Kevin

Re: Enhancements for JavaFX 18

[Philip Race]

Well .. if you know you were the reporter, then it narrows down the JBS 
search from thousands to less than 10 :-)


https://bugs.openjdk.java.net/browse/JDK-8092298

Near as I can tell, that is an issue where we are comparing the FX use 
of DirectWrite with
unknown usage and configuration of some Windows bundled apps and maybe 
we aren't

even sure it is the same font ..  there was a lot of back and forth there.

-phil.

On 8/10/21 3:56 AM, Pedro Duque Vieira wrote:
I've filed the bug a long time ago so I can't remember exactly the bug 
ID or the title I gave it.


Do you want me to file a new one? Do you want me to attach sample 
images (I think you need to do some work around to attach images to a 
javafx bug report?)?


Thanks Philip

On Mon, Aug 9, 2021 at 4:06 PM Philip Race > wrote:


That would be a separate piece of work.  I can't imagine much if
any overlap.
Is there a useful bug ID for what you are referring to ?
The glyph images come from DirectWrite on Windows so I am not sure
if there's something specific ..

-phil.

On 8/9/21 3:44 AM, Pedro Duque Vieira wrote:

Hi!

@Phil Race  If you're going to
tackle font rendering, would it also be possible to work on
Windows font rendering? I find that Windows font rendering is
generally much worse than Mac's.

One example is, for instance, trying to render "Segoe UI" (the
Windows default font) , or "Segoe UI Light"  font (or whatever
variant) with a big font size. The font appears pixelated..

Thanks,

+1. It is something I intend to get to for 18.


-phil.


On 8/4/21 1:10 PM, Kirill Grouchnikov wrote:
> May I humbly suggest fixing font rendering color fringe
issues on macOS


-- 
Pedro Duque Vieira - https://www.pixelduke.com






--
Pedro Duque Vieira - https://www.pixelduke.com