Re: [9] Review request: 8153872: Nashorn no longer needs access to com.sun.javafx.application

2016-04-21 Thread Sundararajan Athijegannathan 
+1


On 4/21/2016 10:19 AM, Mandy Chung wrote:
>> On Apr 19, 2016, at 8:25 AM, Kevin Rushforth  
>> wrote:
>>
>> Jim,
>>
>> Please review the following fix:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8153872
>> http://cr.openjdk.java.net/~kcr/8153872/webrev.00/
>>
>> This is a simple backout of the earlier fix for JDK-8153754.
> +1
>
> Glad that this dependency is eliminated.
>
> Mandy

Re: RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

2016-04-11 Thread Sundararajan Athijegannathan 
+1

On 4/11/2016 6:13 PM, Jim Laskey (Oracle) wrote:
> Any one else.
>
>> On Apr 11, 2016, at 9:13 AM, Michael Haupt  wrote:
>>
>> Hi Jim,
>>
>> lower-case thumbs up!
>>
>> Best,
>>
>> Michael
>>
>>> Am 08.04.2016 um 19:05 schrieb Jim Laskey (Oracle) >> >:
>>>
>>> The code was reworked to use jrtfs: instead of reading from javafx.jar.
>>>
>>> http://cr.openjdk.java.net/~jlaskey/8075550/webrev/index.html 
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8075550
>>>
>>>
>>>
>> -- 
>>
>>  
>> Dr. Michael Haupt | Principal Member of Technical Staff
>> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
>> Oracle Java Platform Group | LangTools Team | Nashorn
>> Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, 
>> Germany
>>
>> ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 
>> München
>> Registergericht: Amtsgericht München, HRA 95603
>>
>> Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 
>> 163/167, 3543 AS Utrecht, Niederlande
>> Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
>> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
>>    Oracle is committed to developing 
>> practices and products that help protect the environment
>>