Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]
On Thu, 26 May 2022 07:08:59 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2. When WebView goes out of scope (disposed from app) , its Event Listeners >> are not being garbage collected. >> >> Solution: >> 1. Detached the jni global reference from JavaEventListener. >> 2. Create scoped ref counted wrapper class JavaObjectWrapperHandler for jni >> global reference. >> 3. Create unique JavaObjectWrapperHandler object for each JavaEventListener. >> 4. EventListenerManager is a singleton class , which stores the >> JavaObjectWrapperHandler mapped with JavaEventListener. >> 5. EventListenerManager also stores the JavaEventListener mapped with >> DOMWindow. >> 6. When Event listener explicitly removed , JavaEventListener is being >> forwarded to EventListenerManager to clear the listener. >> 7. When WebView goes out of scope, EventListenerManager will de-registered >> all the event listeners based on the ref counts attached with WebView >> DOMWindow. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > Adding new review change modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.h line 34: > 32: #include "config.h" > 33: > 34: #include nit: space - PR: https://git.openjdk.java.net/jfx/pull/799
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes
On Wed, 16 Feb 2022 08:07:35 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRetainPtr.h line 9: > 7: * > 8: * 1. Redistributions of source code must retain the above copyright > 9: q * notice, this list of conditions and the following disclaimer. seems to be unintentional - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8278595: Provide more information when a pipeline can't be used
On Mon, 13 Dec 2021 11:00:02 GMT, Johan Vos wrote: > This PR provides at least some basic information when a pipeline can't be > used. > There are a number of reasons why a candidate pipeline can't be used, and > this PR makes it clear at which point the pipeline fails. > > The changes are only applied in case `prism.verbose` is already set to > `true`, so there is no unwanted logging. Note: I don't see what @dlemmermann posted but an _initial_ space seems to be missing "could not be initialized..." --> " could not be initialized..." - PR: https://git.openjdk.java.net/jfx/pull/693
Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling
On Fri, 25 Sep 2020 07:47:41 GMT, Johan Vos wrote: >> Also, I don't really have an idea on how this could be tested other than >> visually, so I'm open to suggestions. > > The visual representation corresponds with digits, so there can be tests that > check if the numbers are what we expect > them to be. It's good that this is not windows-only, so that it can be > tackled on linux as well. But what is not clear > to me: does this require a physical HiDPI screen, or is setting the scale > factor manually good enough to reproduce the > bug? FYI: there is another bug [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592) that *reads* somewhat similar even though the issues are very different. It is also marked as a "Windows" bug. Maybe the root of both issues is the same... - PR: https://git.openjdk.java.net/jfx/pull/308
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content) - PR: https://git.openjdk.java.net/jfx/pull/220
