[8u82] review request: 8088397: [Dialog] ButtonType text not updated when Locale changes
Hi Kevin, Please review this backport to 8u-dev. https://bugs.openjdk.java.net/browse/JDK-8088397 http://cr.openjdk.java.net/~leifs/8088397/webrev.8u.00/ Compare to change in JDK 9: http://cr.openjdk.java.net/~leifs/8088397/webrev.00/ http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/6bd5c06d9d0f Thanks, Leif
[9] Request for review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs
Hi Kevin, Please review the implementation of the new API. https://bugs.openjdk.java.net/browse/JDK-8143158 http://cr.openjdk.java.net/~leifs/8143158/webrev.01/ Thanks, Leif
Re: [9] Request for API review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs
Just a reminder. The proposed API for TextFlow is kept simple as described in JIRA. Thanks, Leif On 2015-11-29 16:30, Leif Samuelsson wrote: Kevin, Phil, et al, Please review the proposed new API for Text and TextFlow to open up existing internal methods for text selection, etc. Most of the new Text API is simply renaming of formerly deprecated methods, while the TextFlow API is added to expose underlying layout functionality and matches the corresponding Text API. https://bugs.openjdk.java.net/browse/JDK-8143158 Code review will follow. Thanks, Leif
[9] Review request for 8144983: TabPane disabled pseudo-class cascades until invisibility
Hi Jonathan, Please review this fix for modena.css. The patch is in JIRA. https://bugs.openjdk.java.net/browse/JDK-8144983 Thanks, Leif
[9] Request for API review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs
Kevin, Phil, et al, Please review the proposed new API for Text and TextFlow to open up existing internal methods for text selection, etc. Most of the new Text API is simply renaming of formerly deprecated methods, while the TextFlow API is added to expose underlying layout functionality and matches the corresponding Text API. https://bugs.openjdk.java.net/browse/JDK-8143158 Code review will follow. Thanks, Leif
[9] Review request for 8139606: [MenuBar] Menus should activate on ALT released, not pressed, on Windows/Linux
Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8139606 http://cr.openjdk.java.net/~leifs/8139606/webrev.00/ Thanks, Leif
[9] Review request for 8088969: Ensemble8: HTML Editor's popup controls retain focus
Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8088969 http://cr.openjdk.java.net/~leifs/8088969/webrev.00/ Thanks, Leif
[9] Review request for 8133833: JavaFX HTMLEditor Font Family should not default to a platform-specific font.
Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8133833 http://cr.openjdk.java.net/~leifs/8133833/webrev.00/ Thanks, Leif
[9] Review request for 8088397: [Dialog] ButtonType text not updated when Locale changes
Hi Jonathan, https://bugs.openjdk.java.net/browse/JDK-8088397 http://cr.openjdk.java.net/~leifs/8088397/webrev.00/ Thanks, Leif
[8u, 9] Review request: 8136838: [ComboBox, DatePicker] Value doesn't update when focus is lost
Hi Jonathan, Please review this fix for 8u72 and 9. https://bugs.openjdk.java.net/browse/JDK-8136838 http://cr.openjdk.java.net/~leifs/8136838/webrev-8u.00/ http://cr.openjdk.java.net/~leifs/8136838/webrev-9.00/ Thanks, Leif
Re: Regression or feature: editable comboBox doesn't commit on focus lost
This is a regression in 8u60. I have filed a new issue for this and I hope that we can backport a fix to an 8u release. https://bugs.openjdk.java.net/browse/JDK-8136838 Leif On 2015-09-21 06:38, faste...@swingempire.de wrote: short description (for a complete description and a workaround see http://stackoverflow.com/q/32620739/203657): edit the text in an editable comboBox, focus another control - expected: the edited text is committed (aka: combo's value changed), actual: combo's value unchanged Worked as expected in u45 (and supposedly u51 which I don't have on my machine) - intentional change or regression? Cheers Jeanette
Re: MenuBar in osx to set About, Preferences, Quit
See: https://bugs.openjdk.java.net/browse/JDK-8091517 https://bugs.openjdk.java.net/browse/JDK-8088585 Leif On 2015-09-02 10:10, Kevin Rushforth wrote: You can file an RFE at http://bugs.java.com/ -- Kevn jo...@msli.com wrote: I would love to file a bug, as this is really big hole for javafx. As other gui tool kits support it, so should javafx. If I can log into to https://bugs.openjdk.java.net/ I will file a bug, if it doesn't exist, but right now login appears broken. On Wed, 2015-09-02 at 12:36 -0400, Tai Hu wrote: I am totally agreed with you on this one. Unfortunately couple weeks ago, I spent days on searching solution for this issue. NSMenuFX is only one actually working. Tai On Sep 2, 2015, at 11:02 AM, jo...@msli.com wrote: This method sends us down a hybrid-app route, which I am trying to get away from. Is there no pure javafx complete solution for OSX? On Wed, 2015-09-02 at 10:33 -0400, Tai Hu wrote: I used NSMenuFX, which is using eclipse swt. It works very well on Mac OS Tai On Wednesday, September 2, 2015, jo...@msli.com wrote: Please respond with only methods that do NOT use swing, awt, or eawt, as I have not seen this published anywhere. On Wed, 2015-09-02 at 07:05 -0700, jo...@msli.com wrote: What is the method for a pure javafx app to control the osx application menu bar (e.g. About, Preferences, Quit, etc)? The menu bar area I am asking about can be seen in a native Mac OS applications menu under : About Preferences... Services Hide Hide Others Show All Quit When I use the javapackager (aka javafxpackager ) to make a stand alone app on osx the title of this bar becomes my app name, however how do I control the other parts (e.g. About, Preferences, Quit, etc)? My javafx application has a javafx MenuBar in each window (Stage) with the property useSystemMenuBar set to true, in order to show a more-native behavior, where the menu bar appears in the Apple menu bar at the top of the screen for the active window, but this does not give me control over the areas in question. Please respond with only methods that do swing, awt, or eawt, as I have not seen this published anywhere. NOTICE: This email may contain confidential information. Please see http://www.meyersound.com/confidential/ for our complete policy. NOTICE: This email may contain confidential information. Please see http://www.meyersound.com/confidential/ for our complete policy.
[8u60, 9] Review request: RT-36454: [Modena, TextArea] Vertical scrollbar appears in TextArea and then disappears
Hi Jonathan, Please review this fix for TextArea. https://javafx-jira.kenai.com/browse/RT-36454 http://cr.openjdk.java.net/~leifs/rt36454/webrev.01/ Thanks, Leif
[8u60,9] Review request: RT-34620: [ComboBox, DatePicker] Buttons set to default/cancel are not reacting to ComboBox enter/esc keys
Hi Jonathan, Please review this fix. https://javafx-jira.kenai.com/browse/RT-34620 http://cr.openjdk.java.net/~leifs/rt34620/webrev.01/ Thanks, Leif
[8u60,9] Review request: RT-39804: Apostrophe as dead key doesn't work on Windows 8.1 Latvian (Standard) keyboard layout
Chien, Kevin, David, Please review this fix for Glass on Windows. https://javafx-jira.kenai.com/browse/RT-39804 http://cr.openjdk.java.net/~leifs/rt39804/webrev.01/ Thanks, Leif
[8u60,9] Review request: RT-39464: Polytonic displays incorrectly when typed in (via TextField)
Hi Chien and Kevin, Please review this fix for Glass on Windows. https://javafx-jira.kenai.com/browse/RT-39464 http://cr.openjdk.java.net/~leifs/rt39464/webrev.01/ Thanks, Leif
[8u] Review request: RT-40280 Refactor duplicated editor code in ComboBox and DatePicker skins.
Hi Jonathan, Please review this fix involving skins based on ComboBoListViewSkin. https://javafx-jira.kenai.com/browse/RT-40280 http://cr.openjdk.java.net/~leifs/rt40280/webrev.01/ Thanks, Leif
[8u] Review request: RT-39642: Selection on double click selects too much on Windows
Hi Jonathan, Please review this fix for TextInputControl on Windows. A simple patch is attached in JIRA. https://javafx-jira.kenai.com/browse/RT-39642 Thanks, Leif
[8u40] Review request for RT-38978: [ComboBox] Editable ComboBox doesn't handle IM events if it gets focus through focus traversal keys.
Hi Naoto and Jonathan, Please review this fix for ComboBox and DatePicker. Jira: https://javafx-jira.kenai.com/browse/RT-38978 Webrev: http://cr.openjdk.java.net/~leifs/rt38978/ Thanks, Leif
Re: British english on JavaFX controls
On 2014-10-16 07:20, Tom Schindl wrote: On 16.10.14 16:15, Tom Schindl wrote: Ok - it ResourceBundle.getBundle() uses the classloader of the caller which means the ExtensionClassloader so having the additional properties in your local dir does help. does NOT help! The property files need to be on the bootclasspath, so putting them in a separate jar file and placing it in the JRE/lib/ext dir should help. See also: https://javafx-jira.kenai.com/browse/RT-38657 https://javafx-jira.kenai.com/browse/RT-36404 Leif
hg: openjfx/8u-dev/rt: RT-37092: (cont.) Revert workaround for test failure and fix StubTextLayout instead.
Changeset: e4d86f6cd678 Author:leifs Date: 2014-08-20 14:49 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e4d86f6cd678 RT-37092: (cont.) Revert workaround for test failure and fix StubTextLayout instead. Reviewed-by: fheidric ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java ! modules/graphics/src/test/java/com/sun/javafx/pgstub/StubTextLayout.java
hg: openjfx/8u-dev/rt: RT-37092: Updated fix to avoid NPE in unit tests.
Changeset: d8500a1bace1 Author:leifs Date: 2014-08-19 16:50 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d8500a1bace1 RT-37092: Updated fix to avoid NPE in unit tests. ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
hg: openjfx/8u-dev/rt: RT-37092: When I use 'Arial' or 'Hiragino Sans GB' font in a TextArea, the arrow 'Down' is not working well
Changeset: 0bec451a41d1 Author:leifs Date: 2014-08-19 11:50 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0bec451a41d1 RT-37092: When I use 'Arial' or 'Hiragino Sans GB' font in a TextArea, the arrow 'Down' is not working well Reviewed-by: fheidric ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
hg: openjfx/8u-dev/rt: [TEST ONLY] Fix tests for RT-38012. The explicit TimeZone was not uniformly applied to all objects.
Changeset: 54d3f711ae54 Author:leifs Date: 2014-08-14 10:40 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/54d3f711ae54 [TEST ONLY] Fix tests for RT-38012. The explicit TimeZone was not uniformly applied to all objects. ! modules/base/src/test/java/javafx/util/converter/DateStringConverterTest.java ! modules/base/src/test/java/javafx/util/converter/DateTimeStringConverterTest.java ! modules/base/src/test/java/javafx/util/converter/TimeStringConverterTest.java
hg: openjfx/8u-dev/rt: Disable failing tests after fix for RT-38012.
Changeset: 46ba065ec37e Author:leifs Date: 2014-08-13 14:31 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/46ba065ec37e Disable failing tests after fix for RT-38012. ! modules/base/src/test/java/javafx/util/converter/DateStringConverterTest.java ! modules/base/src/test/java/javafx/util/converter/DateTimeStringConverterTest.java
hg: openjfx/8u-dev/rt: RT-38012: Date/time converters use unwanted format patterns
Changeset: b4880fab246e Author:leifs Date: 2014-08-13 12:02 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b4880fab246e RT-38012: Date/time converters use unwanted format patterns Reviewed-by: jgiles, kcr, snorthov ! modules/base/src/main/java/javafx/util/converter/DateStringConverter.java ! modules/base/src/main/java/javafx/util/converter/DateTimeStringConverter.java ! modules/base/src/main/java/javafx/util/converter/TimeStringConverter.java ! modules/base/src/test/java/javafx/util/converter/DateStringConverterTest.java ! modules/base/src/test/java/javafx/util/converter/DateTimeStringConverterTest.java ! modules/base/src/test/java/javafx/util/converter/TimeStringConverterTest.java
hg: openjfx/8u-dev/rt: RT-38011: StringConverter support for LocalDate/LocalTime/LocalDateTime
Changeset: 2a469ac93070 Author:leifs Date: 2014-08-13 12:00 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2a469ac93070 RT-38011: StringConverter support for LocalDate/LocalTime/LocalDateTime Reviewed-by: jgiles, kcr + modules/base/src/main/java/javafx/util/converter/LocalDateStringConverter.java + modules/base/src/main/java/javafx/util/converter/LocalDateTimeStringConverter.java + modules/base/src/main/java/javafx/util/converter/LocalTimeStringConverter.java + modules/base/src/test/java/javafx/util/converter/LocalDateStringConverterTest.java + modules/base/src/test/java/javafx/util/converter/LocalDateTimeStringConverterTest.java + modules/base/src/test/java/javafx/util/converter/LocalTimeStringConverterTest.java ! modules/controls/src/main/java/javafx/scene/control/DatePicker.java ! modules/controls/src/test/java/javafx/scene/control/DatePickerTest.java
[8u40] Review request: RT-38011 StringConverter support for LocalDate/LocalTime/LocalDateTime
Hi Jonathan, Please review this fix which adds three new converter classes. https://javafx-jira.kenai.com/browse/RT-38011 http://cr.openjdk.java.net/~leifs/rt38011/webrev.02/ Thanks, Leif
[8u40] Review reequest: RT-38012 Date/time converters use unwanted format patterns
Hi Jonathan, Please review this fix which adds two new constructors to each of three converter classes. https://javafx-jira.kenai.com/browse/RT-38012 http://cr.openjdk.java.net/~leifs/rt38012/webrev.01/ Thanks, Leif
[8u20] Review request: RT-37271: User presentable strings for accessibility are not translatable
Hi Felipe, Please review this fix and verify if you can that the strings still appear as expected in the AT software you are testing with. https://javafx-jira.kenai.com/browse/RT-37271 http://cr.openjdk.java.net/~leifs/rt37271/webrev.01/ Thanks, Leif
[8u20] Review request: RT-36660: [TextField] Arrow scrolling movement unexpected when text overflows
Hi Jonathan, Please review. https://javafx-jira.kenai.com/browse/RT-36660 http://cr.openjdk.java.net/~leifs/rt36660/webrev.01/ Thanks, Leif
Re: Creating a type of toggle with two labels..
On 2013-12-04 14:54, Leif Samuelsson wrote: It seems to me that you could do this with a small class extending ToggleButton. Add a couple of String properties and use a selection listener to switch the main text value. You wouldn't need to write any skin or behavior classes, Just define the look in CSS and use -fx-label-padding to place the text on the background. Or maybe just -fx-alignment will be enough. Leif On 2013-12-04 14:05, Pedro Duque Vieira wrote: OK, sounds reasonable. Too bad about the code duplication that will need to take place. Thanks Jonathan and thanks for the link. Regards, On Wed, Dec 4, 2013 at 9:39 PM, Jonathan Giles wrote: It is likely significantly easier to simply roll your own control and not try to coerce ButtonBase to support two labels. For what it is worth, Paru and I talked about precisely this control at JavaOne 2012, which you can watch on YouTube here: http://www.youtube.com/watch?v=ryUTSrGGnvo&list=PLKCk3OyNwIzvw-zzCMJ3xq5SgxL961IFE&index=38 -- Jonathan On 5/12/2013 10:16 a.m., Pedro Duque Vieira wrote: Hi, I'm trying to create a new control to be used by other developers. It is know as "Toggle Switch". You can see this control in android: http://ankri.de/switch-button-for-android-2-3-gingerbread/ in iOS: http://iosguides.net/ios-menus-comparison/ (search for "Toggle Switch") and on Windows 8: http://www.c-sharpcorner.com/UploadFile/83f858/manage-the-windows-8-sync-feature/ (below "Step 2"). My approach was to subclass ButtonBase which is itself a subclass of Labeled. The problem here is that Labeled only accepts one label but the Toggle Switch needs two: one for the "on" state and another for the "off". Any ideas on how to best approach this problem? Thanks in advance, regards,
Re: Creating a type of toggle with two labels..
It seems to me that you could do this with a small class extending ToggleButton. Add a couple of String properties and use a selection listener to switch the main text value. You wouldn't need to write any skin or behavior classes, Just define the look in CSS and use -fx-label-padding to place the text on the background. Leif On 2013-12-04 14:05, Pedro Duque Vieira wrote: OK, sounds reasonable. Too bad about the code duplication that will need to take place. Thanks Jonathan and thanks for the link. Regards, On Wed, Dec 4, 2013 at 9:39 PM, Jonathan Giles wrote: It is likely significantly easier to simply roll your own control and not try to coerce ButtonBase to support two labels. For what it is worth, Paru and I talked about precisely this control at JavaOne 2012, which you can watch on YouTube here: http://www.youtube.com/watch?v=ryUTSrGGnvo&list=PLKCk3OyNwIzvw-zzCMJ3xq5SgxL961IFE&index=38 -- Jonathan On 5/12/2013 10:16 a.m., Pedro Duque Vieira wrote: Hi, I'm trying to create a new control to be used by other developers. It is know as "Toggle Switch". You can see this control in android: http://ankri.de/switch-button-for-android-2-3-gingerbread/ in iOS: http://iosguides.net/ios-menus-comparison/ (search for "Toggle Switch") and on Windows 8: http://www.c-sharpcorner.com/UploadFile/83f858/manage-the-windows-8-sync-feature/ (below "Step 2"). My approach was to subclass ButtonBase which is itself a subclass of Labeled. The problem here is that Labeled only accepts one label but the Toggle Switch needs two: one for the "on" state and another for the "off". Any ideas on how to best approach this problem? Thanks in advance, regards,
Review request: RT-34220 [Control, Text] arrow up / arrow down is wrong on TextArea
Hi Felipe, Please review fix for RT-34220: [Control, Text] arrow up / arrow down is wrong on TextArea. The fix description is in JIRA. https://javafx-jira.kenai.com/browse/RT-34220 http://cr.openjdk.java.net/~leifs/rt34220/ Thanks, Leif
Review request: RT-34298 RTL orientation: MenuButton RTL text exceeds the bound if preferred width is small.
Hi, Please review this fix for Labeled controls. The patch and details are in JIRA. https://javafx-jira.kenai.com/browse/RT-34298 Thanks, Leif
Please review fix for RT-33416: Key traversal does not enter into an opened ScrollPane
Hi, Please review this fix for TitledPaneBehavior and ScrollPaneBehavior. The patch and details are in JIRA. https://javafx-jira.kenai.com/browse/RT-33416 Thanks, Leif
Review request: RT-34115: DatePicker: space is inserted into the textfield when pressing space to close the popup.
Hi Jonathan, A fix description and patch are in JIRA. https://javafx-jira.kenai.com/browse/RT-34115 Thanks, Leif
Re: Minor issue with ColorPicker
Good point (no pun intended). I'll address this when I move the string to the resource file for https://javafx-jira.kenai.com/browse/RT-34099. Leif On 2013-11-07 03:17, Felix Bembrick wrote: Why does the text "Custom Color.." that appears when the colour selections appear in the drop-down section of ColorPicker use two dots (i.e. "..") instead of an ellipsis or three dots (i.e. "...") at the end of the text? The ellipsis is a standard scientific and mathematical symbol and is of course used throughout Swing and JavaFX when text cannot fit into a clipped region so would seem far more appropriate to use in this context than a double-dot which has no mathematical or UI precedence that I am aware of. Felix
