Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

[Kevin Rushforth]

This looks good to me, too, with one comment:

The three new files have DOS line endings. Please convert to UNIX-style 
line endings, else it will fail jcheck (and fail the 
tools/scripts/checkWhiteSpace).


-- Kevin


mandy chung wrote:



On 3/19/18 7:10 AM, Ambarish Rapte wrote:


Hi Kevin, Alan & Mandy,

 


Request you to review this fix:

Webrev: 
http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ 



JBS: https://bugs.openjdk.java.net/browse/JDK-8195800

 



This looks okay.  Nit FieldUtil isn't a trampoline class and you may 
just drop this comment:


  30 /*
  31  * Create a trampoline class.
  32  */

  
Mandy

Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

[mandy chung]

On 3/19/18 7:10 AM, Ambarish Rapte wrote:


Hi Kevin, Alan & Mandy,

    Request you to review this fix:

    Webrev: 
http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ 



    JBS: https://bugs.openjdk.java.net/browse/JDK-8195800



This looks okay.  Nit FieldUtil isn't a trampoline class and you may 
just drop this comment:


  30 /*
  31  * Create a trampoline class.
  32  */

Mandy

[11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

[Ambarish Rapte]

Hi Kevin, Alan & Mandy,

 

Request you to review this fix:

Webrev: 
http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ 

JBS: https://bugs.openjdk.java.net/browse/JDK-8195800

 

Regards,

Ambarish