Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

2016-12-06 Thread Mandy Chung

> On Dec 6, 2016, at 8:10 AM, Kevin Rushforth  
> wrote:
> 
> Chien & Dave,
> 
> Please review the preliminary webrev to allow building JavaFX with jdk-9+148 
> and later:
> 
> https://bugs.openjdk.java.net/browse/JDK-8170485
> http://cr.openjdk.java.net/~kcr/8170485/webrev.00/
> 
> The details are in the JBS issue and also in the "HEADS-UP" message [1] I 
> sent yesterday.
> 
> As indicated in JBS, I will update the webrev later this week to bump the 
> minimum build to 148 once 148 is promoted and available on java.net. No other 
> changes are anticipated (unless you find anything while reviewing it).

Looks good. 

Mandy



Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

2016-12-06 Thread Alan Bateman



On 06/12/2016 16:10, Kevin Rushforth wrote:

Chien & Dave,

Please review the preliminary webrev to allow building JavaFX with 
jdk-9+148 and later:


https://bugs.openjdk.java.net/browse/JDK-8170485
http://cr.openjdk.java.net/~kcr/8170485/webrev.00/


The updates to the module-info.java sources look good.

-Alan


[9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

2016-12-06 Thread Kevin Rushforth

Chien & Dave,

Please review the preliminary webrev to allow building JavaFX with 
jdk-9+148 and later:


https://bugs.openjdk.java.net/browse/JDK-8170485
http://cr.openjdk.java.net/~kcr/8170485/webrev.00/

The details are in the JBS issue and also in the "HEADS-UP" message [1] 
I sent yesterday.


As indicated in JBS, I will update the webrev later this week to bump 
the minimum build to 148 once 148 is promoted and available on java.net. 
No other changes are anticipated (unless you find anything while 
reviewing it).


-- Kevin

[1] 
http://mail.openjdk.java.net/pipermail/openjfx-dev/2016-December/020014.html