Re: [API Review] FXMLLoader's protected fields

2013-09-11 Thread Jonathan Giles 
>From a quick look all four fields were added in JavaFX 8.0 and so there
has been no break to backwards compatibility.

-- Jonathan

On 11/09/2013 6:54 p.m., Daniel Zwolenski wrote:
> Umm, what happened to backwards compatibility?
>
>
> On Wed, Sep 11, 2013 at 4:44 PM, Martin Sladecek > wrote:
>> Hello,
>>
>> FXMLLoader contains a number of protected (non-final) fields that were
>> made 'protected' probably just by accident. I'm going to make these fields
>> private. If there's somebody who is working on a FXMLLoader subclass, let
>> me know if you need some of the fields, so we could turn them into getters
>> or something.
>>
>> Here's the list of the fields:
>>
>> protected Object controller;
>> protected Object root;
>> protected ResourceBundle resources;
>> protected URL location;
>>
>>
>> Thanks,
>> -Martin
>>

Re: [API Review] FXMLLoader's protected fields

2013-09-11 Thread Richard Bair 
These are all marked as new in 8, so there is no break in compatibility.

Richard

On Sep 10, 2013, at 11:54 PM, Daniel Zwolenski  wrote:

> Umm, what happened to backwards compatibility?
> 
> 
> On Wed, Sep 11, 2013 at 4:44 PM, Martin Sladecek > wrote:
> 
>> Hello,
>> 
>> FXMLLoader contains a number of protected (non-final) fields that were
>> made 'protected' probably just by accident. I'm going to make these fields
>> private. If there's somebody who is working on a FXMLLoader subclass, let
>> me know if you need some of the fields, so we could turn them into getters
>> or something.
>> 
>> Here's the list of the fields:
>> 
>> protected Object controller;
>> protected Object root;
>> protected ResourceBundle resources;
>> protected URL location;
>> 
>> 
>> Thanks,
>> -Martin
>>

Re: [API Review] FXMLLoader's protected fields

2013-09-10 Thread Daniel Zwolenski 
Umm, what happened to backwards compatibility?


On Wed, Sep 11, 2013 at 4:44 PM, Martin Sladecek  wrote:

> Hello,
>
> FXMLLoader contains a number of protected (non-final) fields that were
> made 'protected' probably just by accident. I'm going to make these fields
> private. If there's somebody who is working on a FXMLLoader subclass, let
> me know if you need some of the fields, so we could turn them into getters
> or something.
>
> Here's the list of the fields:
>
> protected Object controller;
> protected Object root;
> protected ResourceBundle resources;
> protected URL location;
>
>
> Thanks,
> -Martin
>

[API Review] FXMLLoader's protected fields

2013-09-10 Thread Martin Sladecek 

Hello,

FXMLLoader contains a number of protected (non-final) fields that were 
made 'protected' probably just by accident. I'm going to make these 
fields private. If there's somebody who is working on a FXMLLoader 
subclass, let me know if you need some of the fields, so we could turn 
them into getters or something.


Here's the list of the fields:

protected Object controller;
protected Object root;
protected ResourceBundle resources;
protected URL location;


Thanks,
-Martin