Re: [Rev 01] RFR: 8208169: can not print selected pages of web page
On Mon, 1 Jun 2020 15:37:09 GMT, Bhawesh Choudhary wrote: >> Print function of WebEngine.java ignores page range setting and prints given >> number of pages starting from first page, >> which is the root cause of this issue. To fix it, put check for page ranges >> and if it available, use it for printing >> pages otherwise print all pages as usual. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: > > added manual test tests/manual/printing/PrintPageRangeTest.java line 78: > 77: > 78: static final String initialURL = > "https://en.wikipedia.org/wiki/Java_version_history;; > 79: Have you tested this when using a system proxy ? And do the webview tests in general use random webpages from the internet ? Why can't we generate some simple local content that we KNOW is 4 pages long. You don't even know that for sure about this page. - PR: https://git.openjdk.java.net/jfx/pull/222
Re: [Rev 01] RFR: 8208169: can not print selected pages of web page
> Print function of WebEngine.java ignores page range setting and prints given > number of pages starting from first page, > which is the root cause of this issue. To fix it, put check for page ranges > and if it available, use it for printing > pages otherwise print all pages as usual. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: added manual test - Changes: - all: https://git.openjdk.java.net/jfx/pull/222/files - new: https://git.openjdk.java.net/jfx/pull/222/files/39748929..75a0362f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/222/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/222/webrev.00-01 Stats: 153 lines in 1 file changed: 153 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/222/head:pull/222 PR: https://git.openjdk.java.net/jfx/pull/222
