On Mon, 21 Oct 2019 11:10:32 GMT, Johan Vos wrote:
> The pull request has been updated with additional changes.
>
>
>
> Added commits:
> - f34a99a3: In order to leverage this on Mac, we need to add -DSTATIC_BUILD
> to the cc flags
>
> Changes:
> - all: https://git.openjdk.java.net/jfx/pull/19/files
> - new: https://git.openjdk.java.net/jfx/pull/19/files/6f31ee6b..f34a99a3
>
> Webrevs:
> - full: https://webrevs.openjdk.java.net/jfx/19/webrev.01
> - incr: https://webrevs.openjdk.java.net/jfx/19/webrev.00-01
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8232687
> Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
> Patch: https://git.openjdk.java.net/jfx/pull/19.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19
buildSrc/mac.gradle line 173:
> 172: MAC.prism.ccFlags = ["-O3", "-DINLINE=inline", "-c", IS_STATIC_BUILD?
> "-DSTATIC_BUILD" : "", ccBaseFlags].flatten()
> 173: MAC.prism.linker = linker
> 174: MAC.prism.linkFlags = linkFlagsAlt
Minor: normally we would put a space before the `?` although we are a bit more
lax in the gradle files. Up to you whether you want to fix it.
PR: https://git.openjdk.java.net/jfx/pull/19