Re: [Rev 02] RFR: 8191758: Match WebKit's font weight rendering with JavaFX

[Kevin Rushforth]

On Tue, 21 Apr 2020 16:34:11 GMT, Bhawesh Choudhary 
 wrote:

>> As per JavaFx 700 font weight is considered to be bold but webkit is using 
>> 600 font weight for text to become bold. to
>> fix issue, use boldWeightValue() function which uses 700 font weight rather 
>> than isFontWeightBold() which compare
>> against 600 font weight.
>
> Bhawesh Choudhary has refreshed the contents of this pull request, and 
> previous commits have been removed. The
> incremental views will show differences compared to the previous content of 
> the PR.

The fix and test look good. I confirm that your new test fails without your fix 
and passes with your fix.

I left one style comment and will approve once you fix that.

modules/javafx.web/src/test/java/test/javafx/scene/web/WebViewTest.java line 
111:

> 110: );
> 111: submit(()->{
> 112: assertFalse("Font weight test failed ",

Minor: there should be a space before and after the `->`

-

PR: https://git.openjdk.java.net/jfx/pull/180

Re: [Rev 02] RFR: 8191758: Match WebKit's font weight rendering with JavaFX

[Bhawesh Choudhary]

> As per JavaFx 700 font weight is considered to be bold but webkit is using 
> 600 font weight for text to become bold. to
> fix issue, use boldWeightValue() function which uses 700 font weight rather 
> than isFontWeightBold() which compare
> against 600 font weight.

Bhawesh Choudhary has refreshed the contents of this pull request, and previous 
commits have been removed. The
incremental views will show differences compared to the previous content of the 
PR. The pull request contains one new
commit since the last revision:

  added unit test for jdk-8191758

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/180/files
  - new: https://git.openjdk.java.net/jfx/pull/180/files/43c7cbf1..f6fb1075

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/180/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/180/webrev.01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/180.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/180/head:pull/180

PR: https://git.openjdk.java.net/jfx/pull/180