Re: [Rev 02] RFR: 8208169: can not print selected pages of web page

2020-06-14 Thread Arun Joseph 
On Sun, 14 Jun 2020 19:13:41 GMT, Bhawesh Choudhary 
 wrote:

>> Print function of WebEngine.java ignores page range setting and prints given 
>> number of pages starting from first page,
>> which is the root cause of this issue. To fix it, put check for page ranges 
>> and if it available, use it for printing
>> pages otherwise print all pages as usual.
>
> Bhawesh Choudhary has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Replaced webpage with locally generated html content in test

tests/manual/printing/PrintPageRangeTest.java line 80:

> 79:
> 80: static final String initialURL = 
> "https://en.wikipedia.org/wiki/Java_version_history;;
> 81:

initialURL is no longer required

-

PR: https://git.openjdk.java.net/jfx/pull/222

Re: [Rev 02] RFR: 8208169: can not print selected pages of web page

2020-06-14 Thread Bhawesh Choudhary 
On Thu, 21 May 2020 17:41:46 GMT, Phil Race  wrote:

>> Bhawesh Choudhary has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Replaced webpage with locally generated html content in test
>
> looks ok. Approval waiting on a test.

@prrace
updated test which uses locally generated html content which should be large 
enough to cover 4 pages.

-

PR: https://git.openjdk.java.net/jfx/pull/222

Re: [Rev 02] RFR: 8208169: can not print selected pages of web page

2020-06-14 Thread Bhawesh Choudhary 
> Print function of WebEngine.java ignores page range setting and prints given 
> number of pages starting from first page,
> which is the root cause of this issue. To fix it, put check for page ranges 
> and if it available, use it for printing
> pages otherwise print all pages as usual.

Bhawesh Choudhary has updated the pull request incrementally with one 
additional commit since the last revision:

  Replaced webpage with locally generated html content in test

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/222/files
  - new: https://git.openjdk.java.net/jfx/pull/222/files/75a0362f..4d973a33

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/222/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/222/webrev.01-02

  Stats: 66 lines in 1 file changed: 21 ins; 32 del; 13 mod
  Patch: https://git.openjdk.java.net/jfx/pull/222.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/222/head:pull/222

PR: https://git.openjdk.java.net/jfx/pull/222