Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus
On Fri, 29 May 2020 12:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skin implementation must maintain the contract of dispose > > Looks good. > A test strategy for Android is a good idea for a follow-up issue. Have you considered the case where a TextField is focused by default when its view is shown? As soon as the view is shown the keybord will pop up, even if the user does not plan to edit anything. I just experienced this when I exchanged the Label in the HelloGluon example against a TextField. A lot of strange things then happen. The keyboard pops up, it hides the Gluon nag screen, if you close the keyboard and the nag screen you still see these edit markers and all this just because this text field was focused by default. To my opinion the keyboard and the edit markers should only be shown when the user actually clicks into the text field and thus indicates that he really wants to edit something. I also noticed that after the keyboard was shown I could not normally close the application anymore. (This was on Android with a Galaxy Tab 4) - PR: https://git.openjdk.java.net/jfx/pull/219
Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus
On Tue, 19 May 2020 10:19:42 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This >> condition fails in cases where the control already has focus but the >> keyboard is not visible. Ideally, the keyboard >> should be shown again when the user taps on the TextInputControl. >> This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows >> the keyboard if the TextInput control is >> both editable and focused. > > Abhinay Agarwal has updated the pull request incrementally with one > additional commit since the last revision: > > Skin implementation must maintain the contract of dispose Looks good. A test strategy for Android is a good idea for a follow-up issue. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/219
Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable and focused. Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: Skin implementation must maintain the contract of dispose - Changes: - all: https://git.openjdk.java.net/jfx/pull/219/files - new: https://git.openjdk.java.net/jfx/pull/219/files/9b7d54f4..0b22747f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/219/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/219/webrev.01-02 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/219/head:pull/219 PR: https://git.openjdk.java.net/jfx/pull/219
