Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-18 Thread Arun Joseph 
On Mon, 18 May 2020 08:00:38 GMT, Bhawesh Choudhary 
 wrote:

>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp 
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add 
>> implementation of function clipToImageBuffer()
>> in GraphicsContextJava.cpp and send clip image to 
>> WCGraphicsPrismContext.java  While rendering in
>> WCGraphicsPrismContext.java if image clip mask is available, use it for 
>> rendering using MaskTextureGraphics interface
>> otherwise use usual way of rendering.
>
> Bhawesh Choudhary has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Refactoring, Utilize getFilterContext() function

modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
 line 536:

> 535: RTTexture paintRtTexture = 
> g.getResourceFactory().createRTTexture(
> 536: (int) Math.ceil(transformedRect.width),
> 537: (int) Math.ceil(transformedRect.height),

transformedRect's height and width are already of type int

-

PR: https://git.openjdk.java.net/jfx/pull/213

Re: [Rev 03] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-18 Thread Bhawesh Choudhary 
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp 
> in WebKit was not implemented, so masking
> doesn't take place at all while rendering SVGRect. to fix this issue add 
> implementation of function clipToImageBuffer()
> in GraphicsContextJava.cpp and send clip image to WCGraphicsPrismContext.java 
>  While rendering in
> WCGraphicsPrismContext.java if image clip mask is available, use it for 
> rendering using MaskTextureGraphics interface
> otherwise use usual way of rendering.

Bhawesh Choudhary has updated the pull request incrementally with one 
additional commit since the last revision:

  Refactoring, Utilize getFilterContext() function

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/213/files
  - new: https://git.openjdk.java.net/jfx/pull/213/files/5b85b47d..a55f9f23

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/213/webrev.03
 - incr: https://webrevs.openjdk.java.net/jfx/213/webrev.02-03

  Stats: 8 lines in 1 file changed: 0 ins; 7 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/213.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/213/head:pull/213

PR: https://git.openjdk.java.net/jfx/pull/213