Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added a bunch of >> tests. >> >> After applying this fix, I can no longer reproduce >> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and >> [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228). > > mstr2 has updated the pull request incrementally with two additional commits > since the last revision: > > - Rename local variable in test > - Remove unrelated fix fyi: filed [JDK-8266811](https://bugs.openjdk.java.net/browse/JDK-8266811) for the eclipse classpath issue introduced with this (by using MockListObserver) - will fix when this is integrated :) - PR: https://git.openjdk.java.net/jfx/pull/480
Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added a bunch of >> tests. >> >> After applying this fix, I can no longer reproduce >> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and >> [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228). > > mstr2 has updated the pull request incrementally with two additional commits > since the last revision: > > - Rename local variable in test > - Remove unrelated fix Looks good :) Verified tests failing/passing before/after fix, verified example in bug report working correctly - Marked as reviewed by fastegal (Committer). PR: https://git.openjdk.java.net/jfx/pull/480
Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]
On Wed, 5 May 2021 09:32:30 GMT, Ambarish Rapte wrote: > We have couple more similar issues reported > > 1. [JDK-8255935](https://bugs.openjdk.java.net/browse/JDK-8255935) : > MultipleSelectionModel provides incorrect 'removed' sub-list in change events > 2. [JDK-8196065](https://bugs.openjdk.java.net/browse/JDK-8196065) : > ListChangeListener getRemoved() returns items that were not removed. Both these above issues do not get fixed by this PR. - PR: https://git.openjdk.java.net/jfx/pull/480
Re: RFR: 8189354: Change.getRemoved() list contains incorrect selected items when a TreeItem is collapsed [v9]
On Mon, 3 May 2021 20:51:13 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added a bunch of >> tests. >> >> After applying this fix, I can no longer reproduce >> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and >> [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228). > > mstr2 has updated the pull request incrementally with two additional commits > since the last revision: > > - Rename local variable in test > - Remove unrelated fix looks good to me. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/480
