RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2021-12-22 Thread eduardsdv 
The NullPointer occurs when `Accessible.getAttribute(Object)` returns null. 
I checked all places where the `getAttribute(..)` method is called. Everywhere 
it is checked for null `(Accessible,` `MacAccessible,` `WinAccessible,` 
`WinTextRangeProvider`). Only at this one place in 
`WinAccessible.GetPatternProvider(int)` it is missing.

This PR adds this missing null-check in the 
`WinAccessible.GetPatternProvider(int)` method.

-

Commit messages:
 - Merge branch 'openjdk:master' into 
bugfix/8203463-NPE-in-WinAccessible-GetPatternProvider
 - WinAccessible: Add missing null check

Changes: https://git.openjdk.java.net/jfx/pull/700/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=700&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8203463
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/700.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/700/head:pull/700

PR: https://git.openjdk.java.net/jfx/pull/700

Re: RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2021-12-22 Thread Kevin Rushforth 
On Wed, 22 Dec 2021 08:59:53 GMT, eduardsdv  wrote:

> The NullPointer occurs when `Accessible.getAttribute(Object)` returns null. 
> I checked all places where the `getAttribute(..)` method is called. 
> Everywhere it is checked for null `(Accessible,` `MacAccessible,` 
> `WinAccessible,` `WinTextRangeProvider`). Only at this one place in 
> `WinAccessible.GetPatternProvider(int)` it is missing.
> 
> This PR adds this missing null-check in the 
> `WinAccessible.GetPatternProvider(int)` method.

This looks like an obviously correct fix to me.

-

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/700

[jfx11u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-17 Thread Johan Vos 
Reviewed-by: kcr

-

Commit messages:
 - 8203463: [Accessibility, Narrator] NPE in TableView

Changes: https://git.openjdk.java.net/jfx11u/pull/81/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u&pr=81&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8203463
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx11u/pull/81.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/81/head:pull/81

PR: https://git.openjdk.java.net/jfx11u/pull/81

[jfx17u] RFR: 8203463: [Accessibility, Narrator] NPE in TableView

2022-03-18 Thread Johan Vos 
Reviewed-by: kcr

-

Commit messages:
 - 8203463: [Accessibility, Narrator] NPE in TableView

Changes: https://git.openjdk.java.net/jfx17u/pull/38/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u&pr=38&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8203463
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx17u/pull/38.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/38/head:pull/38

PR: https://git.openjdk.java.net/jfx17u/pull/38