Re: [Integrated] RFR: 8237823: Mark TextTest.testTabSize as unstable

2020-01-24 Thread Kevin Rushforth 
Changeset: da99e248
Author:Kevin Rushforth 
Date:  2020-01-24 16:54:57 +
URL:   https://git.openjdk.java.net/jfx/commit/da99e248

8237823: Mark TextTest.testTabSize as unstable

Reviewed-by: prr

! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java

Re: [Integrated] RFR: 8237823: Mark TextTest.testTabSize as unstable

2020-01-24 Thread Kevin Rushforth 
Changeset: da99e248
Author:Kevin Rushforth 
Date:  2020-01-24 16:54:57 +
URL:   https://git.openjdk.java.net/jfx/commit/da99e248

8237823: Mark TextTest.testTabSize as unstable

Reviewed-by: prr

! modules/javafx.graphics/src/test/java/test/javafx/scene/text/TextTest.java

Re: RFR: 8237823: Mark TextTest.testTabSize as unstable

2020-01-24 Thread Phil Race 
On Fri, 24 Jan 2020 15:12:50 GMT, Kevin Rushforth  wrote:

> Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).
> 
> The javafx.graphics unit test `TextTest.testTabSize` fails intermittently -- 
> see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).
> 
> This PR marks `TextTest.testTabSize` as unstable, meaning it will not be run 
> by default. It will be run only when running gradle with the 
> `-PUNSTABLE_TEST=true` flag.
> 
> As noted in the bug report, I see this about 20% of the time in our nightly 
> and CI builds. Given that we are getting late in the cycle for openjfx14, we 
> need to mark the test as unstable until a fix can be found.
> 
> NOTE: this is targeted to jfx14.

Marked as reviewed by prr (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/94

Re: RFR: 8237823: Mark TextTest.testTabSize as unstable

2020-01-24 Thread Kevin Rushforth 
On Fri, 24 Jan 2020 15:12:50 GMT, Kevin Rushforth  wrote:

> Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).
> 
> The javafx.graphics unit test `TextTest.testTabSize` fails intermittently -- 
> see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).
> 
> This PR marks `TextTest.testTabSize` as unstable, meaning it will not be run 
> by default. It will be run only when running gradle with the 
> `-PUNSTABLE_TEST=true` flag.
> 
> As noted in the bug report, I see this about 20% of the time in our nightly 
> and CI builds. Given that we are getting late in the cycle for openjfx14, we 
> need to mark the test as unstable until a fix can be found.
> 
> NOTE: this is targeted to jfx14.

@prrace can you review this?

-

PR: https://git.openjdk.java.net/jfx/pull/94

RFR: 8237823: Mark TextTest.testTabSize as unstable

2020-01-24 Thread Kevin Rushforth 
Fix for [JDK-8237823](https://bugs.openjdk.java.net/browse/JDK-8237823).

The javafx.graphics unit test `TextTest.testTabSize` fails intermittently -- 
see [JDK-8236728](https://bugs.openjdk.java.net/browse/JDK-8236728).

This PR marks `TextTest.testTabSize` as unstable, meaning it will not be run by 
default. It will be run only when running gradle with the 
`-PUNSTABLE_TEST=true` flag.

As noted in the bug report, I see this about 20% of the time in our nightly and 
CI builds. Given that we are getting late in the cycle for openjfx14, we need 
to mark the test as unstable until a fix can be found.

NOTE: this is targeted to jfx14.

-

Commits:
 - bfca349c: 8237823: Mark TextTest.testTabSize as unstable

Changes: https://git.openjdk.java.net/jfx/pull/94/files
 Webrev: https://webrevs.openjdk.java.net/jfx/94/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8237823
  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/94.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/94/head:pull/94

PR: https://git.openjdk.java.net/jfx/pull/94