Re: [Integrated] RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. This pull request has now been integrated. Changeset: 6bd0e22d Author:Alexander Matveev URL: https://git.openjdk.java.net/jfx/commit/6bd0e22d Stats: 10217 lines in 37 files changed: 4167 ins; 5498 del; 552 mod 8239095: Upgrade libFFI to the latest 3.3 version Reviewed-by: jvos, kcr - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. Looks good to me. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. I tested this and couldn't find issues. The uncommented line worries me a bit, though, but I can't see a reason why it should be commented again. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 13:21:08 GMT, Kevin Rushforth wrote: >> That's a good question. The commented line was there from the first commit >> (in 9, changeset 9231:241f9696e3ad, >> https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason >> on why it was disabled. >> libffi is also built in the GraalVM project, and that line is not commented >> there. >> >> @sashamatveev or @kevinrushforth do you remember the reason? > > No, I don't remember. No, I don't remember as well. - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 12:54:28 GMT, Johan Vos wrote: >> modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h >> line 53: >> >>> 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION >>> 53: #ifndef _MSC_VER >>> 54: #define FFI_TARGET_HAS_COMPLEX_TYPE >> >> In the original release of [libffi >> 3.2.1](https://github.com/libffi/libffi/releases/tag/v3.2.1), this line is >> not >> commented. which means it was commented in JavaFX. I cannot trace when and >> why was it commented. Should it be reasoned >> to whether enable it or not ? > > That's a good question. The commented line was there from the first commit > (in 9, changeset 9231:241f9696e3ad, > https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on > why it was disabled. > libffi is also built in the GraalVM project, and that line is not commented > there. > > @sashamatveev or @kevinrushforth do you remember the reason? No, I don't remember. - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Mon, 1 Jun 2020 09:54:23 GMT, Ambarish Rapte wrote: >> - Updated libffi to 3.3. > > modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h > line 53: > >> 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION >> 53: #ifndef _MSC_VER >> 54: #define FFI_TARGET_HAS_COMPLEX_TYPE > > In the original release of [libffi > 3.2.1](https://github.com/libffi/libffi/releases/tag/v3.2.1), this line is > not > commented. which means it was commented in JavaFX. I cannot trace when and > why was it commented. Should it be reasoned > to whether enable it or not ? That's a good question. The commented line was there from the first commit (in 9, changeset 9231:241f9696e3ad, https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on why it was disabled. libffi is also built in the GraalVM project, and that line is not commented there. @sashamatveev or @kevinrushforth do you remember the reason? - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h line 53: > 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION > 53: #ifndef _MSC_VER > 54: #define FFI_TARGET_HAS_COMPLEX_TYPE In the original release of libffi 3.2.1, this line is not commented. which means it was commented in JavaFX. I cannot trace when and why was it commented. Should it be reasoned to whether enable it or not ? - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 22:41:25 GMT, Kevin Rushforth wrote: >> - Updated libffi to 3.3. > > @arapte Can you review as well? Initial testing looks good. I'll finish my testing & review on Monday. - PR: https://git.openjdk.java.net/jfx/pull/242
Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. @arapte Can you review as well? - PR: https://git.openjdk.java.net/jfx/pull/242
RFR: 8239095: Upgrade libFFI to the latest 3.3 version
- Updated libffi to 3.3. - Commit messages: - 8239095: Fixed jcheck - 8239095: Upgrade libFFI to the latest 3.3 version Changes: https://git.openjdk.java.net/jfx/pull/242/files Webrev: https://webrevs.openjdk.java.net/jfx/242/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8239095 Stats: 10110 lines in 37 files changed: 5391 ins; 4060 del; 659 mod Patch: https://git.openjdk.java.net/jfx/pull/242.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/242/head:pull/242 PR: https://git.openjdk.java.net/jfx/pull/242
