Re: [Integrated] RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! This pull request has now been integrated. Changeset: b2008913 Author:Ajit Ghaisas URL: https://git.openjdk.java.net/jfx/commit/b2008913 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8244824: TableView : Incorrect German translation Co-authored-by: Martin Schelldorfer Reviewed-by: fastegal, kcr - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 12 Jun 2020 10:29:08 GMT, Ajit Ghaisas wrote: >> @aghaisas can you proceed with this one or is there anything required from >> my side? > > I need confirmation from you about which option you prefer (See my last > comment above). @kevinrushforth also has asked > the same question in his last comment. let's do option 1 - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 12 Jun 2020 10:01:52 GMT, Martin Schelldorfer wrote: >> @kevinrushforth brought to my notice that there is a PR >> (https://github.com/openjdk/jfx/pull/210) opened for the same >> issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of >> this PR as it did not have 'rfr' label - >> which I look for. I picked up this issue from JBS and submitted the solution >> mentioned in JBS. >> I would *NOT* like to step on a new contributor's contribution. >> >> Now, I see that the original PR has been closed. Once his signed OCA has >> been recorded, we have two options : >> 1. I will integrate with this PR with due attribution given to >> [schelldorfer](https://github.com/schelldorfer) >> OR >> 2. I will withdraw my PR without integrating and >> [schelldorfer](https://github.com/schelldorfer) can reopen and submit >> his PR. > > @aghaisas can you proceed with this one or is there anything required from my > side? I need confirmation from you about which option you prefer (See my last comment above). @kevinrushforth also has asked the same question in his last comment. - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Tue, 19 May 2020 14:27:40 GMT, Ajit Ghaisas wrote: >> Correct :) > > @kevinrushforth brought to my notice that there is a PR > (https://github.com/openjdk/jfx/pull/210) opened for the same > issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of > this PR as it did not have 'rfr' label - > which I look for. I picked up this issue from JBS and submitted the solution > mentioned in JBS. > I would *NOT* like to step on a new contributor's contribution. > > Now, I see that the original PR has been closed. Once his signed OCA has been > recorded, we have two options : > 1. I will integrate with this PR with due attribution given to > [schelldorfer](https://github.com/schelldorfer) > OR > 2. I will withdraw my PR without integrating and > [schelldorfer](https://github.com/schelldorfer) can reopen and submit > his PR. @aghaisas can you proceed with this one or is there anything required from my side? - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Tue, 19 May 2020 14:38:01 GMT, Kevin Rushforth wrote: >> @kevinrushforth brought to my notice that there is a PR >> (https://github.com/openjdk/jfx/pull/210) opened for the same >> issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of >> this PR as it did not have 'rfr' label - >> which I look for. I picked up this issue from JBS and submitted the solution >> mentioned in JBS. >> I would *NOT* like to step on a new contributor's contribution. >> >> Now, I see that the original PR has been closed. Once his signed OCA has >> been recorded, we have two options : >> 1. I will integrate with this PR with due attribution given to >> [schelldorfer](https://github.com/schelldorfer) >> OR >> 2. I will withdraw my PR without integrating and >> [schelldorfer](https://github.com/schelldorfer) can reopen and submit >> his PR. > > @aghaisas that sounds fine to me. In order to attribute the fix, you will > need to wait for the OCA to be recorded. > > @schelldorfer once your OCA is recorded, which would you prefer to do? Create > a new PR yourself or have @aghaisas list > you as the contributor. I signed the OCA a few days ago and my name is listed on the page https://www.oracle.com/technetwork/community/oca-486395.html#s - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Tue, 19 May 2020 14:27:40 GMT, Ajit Ghaisas wrote: >> Correct :) > > @kevinrushforth brought to my notice that there is a PR > (https://github.com/openjdk/jfx/pull/210) opened for the same > issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of > this PR as it did not have 'rfr' label - > which I look for. I picked up this issue from JBS and submitted the solution > mentioned in JBS. > I would *NOT* like to step on a new contributor's contribution. > > Now, I see that the original PR has been closed. Once his signed OCA has been > recorded, we have two options : > 1. I will integrate with this PR with due attribution given to > [schelldorfer](https://github.com/schelldorfer) > OR > 2. I will withdraw my PR without integrating and > [schelldorfer](https://github.com/schelldorfer) can reopen and submit > his PR. @aghaisas that sounds fine to me. In order to attribute the fix, you will need to wait for the OCA to be recorded. @schelldorfer once your OCA is recorded, which would you prefer to do? Create a new PR yourself or have @aghaisas list you as the contributor. - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 09:47:09 GMT, Jeanette Winzenburg wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 >> >> Fix : As simple as it gets !!! > > Correct :) @kevinrushforth brought to my notice that there is a PR (https://github.com/openjdk/jfx/pull/210) opened for the same issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of this PR as it did not have 'rfr' label - which I look for. I picked up this issue from JBS and submitted the solution mentioned in JBS. I would *NOT* like to step on a new contributor's contribution. Now, I see that the original PR has been closed. Once his signed OCA has been recorded, we have two options : 1. I will integrate with this PR with due attribution given to [schelldorfer](https://github.com/schelldorfer) OR 2. I will withdraw my PR without integrating and [schelldorfer](https://github.com/schelldorfer) can reopen and submit his PR. - PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! Correct :) - Marked as reviewed by fastegal (Author). PR: https://git.openjdk.java.net/jfx/pull/220
Re: RFR: 8244824: TableView : Incorrect German translation
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content) - PR: https://git.openjdk.java.net/jfx/pull/220
RFR: 8244824: TableView : Incorrect German translation
Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 Fix : As simple as it gets !!! - Commit messages: - German translation bug fix Changes: https://git.openjdk.java.net/jfx/pull/220/files Webrev: https://webrevs.openjdk.java.net/jfx/220/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8244824 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/220.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/220/head:pull/220 PR: https://git.openjdk.java.net/jfx/pull/220
