Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

2020-08-26 Thread Kevin Rushforth 
On Wed, 26 Aug 2020 15:21:48 GMT, Bhawesh Choudhary  
wrote:

>> Added missing explicit no-arg constructors to classes in package 
>> javafx.scene, javafx.css and javafx.stage.
>
> Bhawesh Choudhary has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Updated comments as per JDK convention

Looks good except for the one you missed to update, `StringStore`.

modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java line 544:

> 543:  */
> 544: public StringStore() {
> 545: }

You missed updating the wording for this one.

-

PR: https://git.openjdk.java.net/jfx/pull/283

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

2020-08-26 Thread Kevin Rushforth 
On Tue, 25 Aug 2020 09:42:16 GMT, Nir Lisker  wrote:

> Since it will require an additional cleanup issue anyway, I don't think it 
> matters when we do it, but since we're here
> I see no reason not to start already.

Agreed.

Let's adopt the same language as the JDK. If there are configurable parameters, 
we can indicate the default by adding
an `@defaultValue` tag (I don't think we need the word `default` in the 
description).

-

PR: https://git.openjdk.java.net/jfx/pull/283

Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v4]

2020-08-26 Thread Bhawesh Choudhary 
> Added missing explicit no-arg constructors to classes in package 
> javafx.scene, javafx.css and javafx.stage.

Bhawesh Choudhary has updated the pull request incrementally with one 
additional commit since the last revision:

  Updated comments as per JDK convention

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/283/files
  - new: https://git.openjdk.java.net/jfx/pull/283/files/38a7551d..69b75d69

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/283/webrev.03
 - incr: https://webrevs.openjdk.java.net/jfx/283/webrev.02-03

  Stats: 12 lines in 12 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jfx/pull/283.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/283/head:pull/283

PR: https://git.openjdk.java.net/jfx/pull/283