Re: RFR: 8252547: Correct transformations docs in Node [v5]
On Sat, 12 Sep 2020 15:21:35 GMT, Nir Lisker wrote: >> Correction to the order of transforms specified in the docs of `Node`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Replaced a link change looks good to me, javadoc built with no problem. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v5]
On Sat, 12 Sep 2020 15:21:35 GMT, Nir Lisker wrote: >> Correction to the order of transforms specified in the docs of `Node`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Replaced a link Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v4]
On Sat, 12 Sep 2020 14:41:01 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replaced link > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 336: > >> 334: * The transforms are applied in the reverse order of the matrix >> multiplication outlined above: last element of >> the transforms list 335: * to 0th element, scale, rotate, and layout and >> translate. By applying the transforms in this >> order, the bounds in the local 336: * coordinates of the node are >> transformed to the bounds in the parent coordinate >> of the node (see the Bounding Rectangles > > Maybe hyperlink to the Bounding Rectangles section? (although as it is right > below, it isn't as important). Originally I had "see the next section" but didn't want to depend on the order. I put the link anyway. - PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v5]
> Correction to the order of transforms specified in the docs of `Node`. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Replaced a link - Changes: - all: https://git.openjdk.java.net/jfx/pull/293/files - new: https://git.openjdk.java.net/jfx/pull/293/files/453435ef..45f9d8aa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/293/head:pull/293 PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v4]
On Sat, 12 Sep 2020 13:53:49 GMT, Nir Lisker wrote: >> Correction to the order of transforms specified in the docs of `Node`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Replaced link Changes look good to me. I asked one question about whether you wanted to add another hyperlink, but it's up to you. modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 336: > 334: * The transforms are applied in the reverse order of the matrix > multiplication outlined above: last element of > the transforms list 335: * to 0th element, scale, rotate, and layout and > translate. By applying the transforms in this > order, the bounds in the local 336: * coordinates of the node are > transformed to the bounds in the parent coordinate > of the node (see the Bounding Rectangles Maybe hyperlink to the Bounding Rectangles section? (although as it is right below, it isn't as important). - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v4]
> Correction to the order of transforms specified in the docs of `Node`. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Replaced link - Changes: - all: https://git.openjdk.java.net/jfx/pull/293/files - new: https://git.openjdk.java.net/jfx/pull/293/files/0bf63c0b..453435ef Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/293/head:pull/293 PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v3]
On Fri, 11 Sep 2020 21:43:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 3423:
>
>> 3421: *
>> 3422: * @return the {@code boundsInParent} property for this {@code
>> Node}
>> 3423: * @see {@linkplain Node Bounding Rectangles} section in the class
>> docs
>
> This causes a javadoc error:
>
>> Task :javadoc
> modules\javafx.graphics\src\main\java\javafx\scene\Node.java:3423: error:
> unexpected content
> * @see {@linkplain Node Bounding Rectangles} section in the class docs
>^
> 1 error
>
>> Task :javadoc FAILED
`@see` doesn't show for properties because of the special handling (same goes
for `@return`). I opted to create HTML
links to the headers instead. I did it to all for them even if they are not all
used.
-
PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v3]
> Correction to the order of transforms specified in the docs of `Node`. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added tags - Changes: - all: https://git.openjdk.java.net/jfx/pull/293/files - new: https://git.openjdk.java.net/jfx/pull/293/files/e09d20f7..0bf63c0b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=01-02 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/293/head:pull/293 PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node [v2]
> Correction to the order of transforms specified in the docs of `Node`. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: https://git.openjdk.java.net/jfx/pull/293/files - new: https://git.openjdk.java.net/jfx/pull/293/files/d56f8d02..e09d20f7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=00-01 Stats: 16 lines in 1 file changed: 4 ins; 2 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/293/head:pull/293 PR: https://git.openjdk.java.net/jfx/pull/293
Re: RFR: 8252547: Correct transformations docs in Node
On Mon, 31 Aug 2020 23:28:51 GMT, Nir Lisker wrote:
> Correction to the order of transforms specified in the docs of `Node`.
The updated text look good, although there is a javadoc error that causes the
build to fail. I left a few comments
below.
modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 335:
> 333: *
> 334: * The transforms are applied in the reverse order of the matrix
> multiplication outlined above: last element of
> the transforms list 335: * to 0th element, scale, rotate, and layout and
> translate. By applying the transforms in this
> order, the bound in the local
"bounds" should be plural.
modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 328:
> 326: * The matrices that represent the transforms are multiplied in this
> order:
> 327: *
> 328: * Layout ({@link #layoutXProperty layoutX}), {@link
> #layoutYProperty layoutY} and translate
The closing paren should be after `layoutY`:
* Layout ({@link #layoutXProperty layoutX}, {@link #layoutYProperty
layoutY}) and ...
Also, can you add `` after each item?
modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 3423:
> 3421: *
> 3422: * @return the {@code boundsInParent} property for this {@code Node}
> 3423: * @see {@linkplain Node Bounding Rectangles} section in the class
> docs
This causes a javadoc error:
> Task :javadoc
modules\javafx.graphics\src\main\java\javafx\scene\Node.java:3423: error:
unexpected content
* @see {@linkplain Node Bounding Rectangles} section in the class docs
^
1 error
> Task :javadoc FAILED
-
PR: https://git.openjdk.java.net/jfx/pull/293
RFR: 8252547: Correct transformations docs in Node
Correction to the order of transforms specified in the docs of `Node`. - Commit messages: - Remove whitespace - Remove whitespace - Initial commit Changes: https://git.openjdk.java.net/jfx/pull/293/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=293&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252547 Stats: 37 lines in 1 file changed: 13 ins; 12 del; 12 mod Patch: https://git.openjdk.java.net/jfx/pull/293.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/293/head:pull/293 PR: https://git.openjdk.java.net/jfx/pull/293
