Re: RFR: 8260475: Deprecate for removal protected access members in DateTimeStringConverter [v2]
On Wed, 3 Feb 2021 02:49:53 GMT, Nir Lisker wrote: >> Deprecating protected members in DateTimeStringConverter. Internal >> implementation should not be exposed (similar to `NumberStringConverter` and >> others). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added javadoc deprecation tags Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/390
Re: RFR: 8260475: Deprecate for removal protected access members in DateTimeStringConverter [v2]
On Wed, 3 Feb 2021 21:06:07 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added javadoc deprecation tags > > Looks good. Go ahead and file a CSR. CSR filed. - PR: https://git.openjdk.java.net/jfx/pull/390
Re: RFR: 8260475: Deprecate for removal protected access members in DateTimeStringConverter [v2]
On Wed, 3 Feb 2021 02:49:53 GMT, Nir Lisker wrote: >> Deprecating protected members in DateTimeStringConverter. Internal >> implementation should not be exposed (similar to `NumberStringConverter` and >> others). > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added javadoc deprecation tags Looks good. Go ahead and file a CSR. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/390
Re: RFR: 8260475: Deprecate for removal protected access members in DateTimeStringConverter [v2]
> Deprecating protected members in DateTimeStringConverter. Internal > implementation should not be exposed (similar to `NumberStringConverter` and > others). Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added javadoc deprecation tags - Changes: - all: https://git.openjdk.java.net/jfx/pull/390/files - new: https://git.openjdk.java.net/jfx/pull/390/files/9fb95ba8..fb6d71a7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=390&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=390&range=00-01 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/390.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/390/head:pull/390 PR: https://git.openjdk.java.net/jfx/pull/390
