Re: RFR: 8269259: Remove obsolete apps, tests, and scripts
On Tue, 29 Jun 2021 03:58:10 GMT, Nir Lisker wrote: > Under tests/system/src there are several projects called "testappN". Are they > named cryptically on purpose? Not really, no. They are all added to `build.gradle` as separate source sets [here](https://github.com/openjdk/jfx/blob/master/build.gradle#L3643), but we don't take advantage of the naming. They just need to be difference from the primary `test` source set. - PR: https://git.openjdk.java.net/jfx/pull/545
Re: RFR: 8269259: Remove obsolete apps, tests, and scripts
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy > apps/toys/StretchyGrid > apps/toys/TouchSuite > > tests/functional/* > tests/performance/VMPerformance > > tools/* > > See the JBS issue and [this > thread](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-June/030894.html) > on the openjfx-dev mailing list for more info. > > There are two commits for ease of review. The first one is generated by doing > a "git rm -r" on each of the above listed directories. The second is to > remove any remaining references to the removed directories. Build and sanity testing looks good. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/545
Re: RFR: 8269259: Remove obsolete apps, tests, and scripts
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy > apps/toys/StretchyGrid > apps/toys/TouchSuite > > tests/functional/* > tests/performance/VMPerformance > > tools/* > > See the JBS issue and [this > thread](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-June/030894.html) > on the openjfx-dev mailing list for more info. > > There are two commits for ease of review. The first one is generated by doing > a "git rm -r" on each of the above listed directories. The second is to > remove any remaining references to the removed directories. Looks fine. I don't know which of these are used frequently and which aren't, but I tested that there are no errors as a result of this patch. Under tests/system/src there are several projects called "testappN". Are they named cryptically on purpose? - Marked as reviewed by nlisker (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/545
Re: RFR: 8269259: Remove obsolete apps, tests, and scripts
On Fri, 25 Jun 2021 14:59:00 GMT, Kevin Rushforth wrote: > This PR deletes the following applications, tests, and scripts that are > either obsolete > or unmaintained: > > apps/performance/* > > apps/tests/HelloTest > > apps/toys/FXSlideShow > apps/toys/Industrial > apps/toys/Shape3DToy > apps/toys/StretchyGrid > apps/toys/TouchSuite > > tests/functional/* > tests/performance/VMPerformance > > tools/* > > See the JBS issue and [this > thread](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-June/030894.html) > on the openjfx-dev mailing list for more info. > > There are two commits for ease of review. The first one is generated by doing > a "git rm -r" on each of the above listed directories. The second is to > remove any remaining references to the removed directories. I will review the eclipse file changes. I'm not sure what constitutes a review for removed files in the case where nothing depends on them. - PR: https://git.openjdk.java.net/jfx/pull/545
RFR: 8269259: Remove obsolete apps, tests, and scripts
This PR deletes the following applications, tests, and scripts that are either obsolete or unmaintained: apps/performance/* apps/tests/HelloTest apps/toys/FXSlideShow apps/toys/Industrial apps/toys/Shape3DToy apps/toys/StretchyGrid apps/toys/TouchSuite tests/functional/* tests/performance/VMPerformance tools/* See the JBS issue and [this thread](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-June/030894.html) on the openjfx-dev mailing list for more info. There are two commits for ease of review. The first one is generated by doing a "git rm -r" on each of the above listed directories. The second is to remove any remaining references to the removed directories. - Commit messages: - Remove references to removed dirs and apps - 8269259: Remove obsolete apps, tests, and scripts Changes: https://git.openjdk.java.net/jfx/pull/545/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=545=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269259 Stats: 33646 lines in 196 files changed: 0 ins; 33645 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/545.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/545/head:pull/545 PR: https://git.openjdk.java.net/jfx/pull/545
