Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v4]

2021-12-10 Thread eduardsdv 
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last 
> element but to the bottom of the last element.

eduardsdv has updated the pull request incrementally with one additional commit 
since the last revision:

  8276167: Avoid additional Toolkit.getToolkit().firePulse()
  
  Avoid using of additional Toolkit.getToolkit().firePulse() in the test,
  adjust expected values instead.

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/656/files
  - new: https://git.openjdk.java.net/jfx/pull/656/files/588a7e41..73e11f4b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=656&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=656&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/656.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/656/head:pull/656

PR: https://git.openjdk.java.net/jfx/pull/656

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v4]

2021-12-10 Thread Johan Vos 
On Fri, 10 Dec 2021 15:24:44 GMT, eduardsdv  wrote:

>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last 
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8276167: Avoid additional Toolkit.getToolkit().firePulse()
>   
>   Avoid using of additional Toolkit.getToolkit().firePulse() in the test,
>   adjust expected values instead.

Marked as reviewed by jvos (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/656

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v4]

2021-12-12 Thread Ajit Ghaisas 
On Fri, 10 Dec 2021 15:24:44 GMT, eduardsdv  wrote:

>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last 
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8276167: Avoid additional Toolkit.getToolkit().firePulse()
>   
>   Avoid using of additional Toolkit.getToolkit().firePulse() in the test,
>   adjust expected values instead.

Marked as reviewed by aghaisas (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/656