Re: RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread Kevin Rushforth
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv  wrote:

> Create sources.jars and attach they to the publish task, so that they can be 
> uploaded to the (e.g. maven) repository automatically.

As discussed in the bug report, it isn't at all clear that we should do this.

@johanvos can make the call on this.

-

PR: https://git.openjdk.java.net/jfx/pull/657


Re: RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread Florian Kirmaier
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv  wrote:

> Create sources.jars and attach they to the publish task, so that they can be 
> uploaded to the (e.g. maven) repository automatically.

I wonder how the sources for the official maven release are generated? 
https://repo1.maven.org/maven2/org/openjfx/javafx-graphics/17/
The official release contains all the sources, but when we build it from 
source, these files are missing.

-

PR: https://git.openjdk.java.net/jfx/pull/657


RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread eduardsdv
Create sources.jars and attach they to the publish task, so that they can be 
uploaded to the (e.g. maven) repository automatically.

-

Commit messages:
 - 8276170: Remove trailing whitespaces
 - JDK-8276170: Create Sources when publishing to Maven

Changes: https://git.openjdk.java.net/jfx/pull/657/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx=657=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8276170
  Stats: 13 lines in 1 file changed: 13 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/657.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/657/head:pull/657

PR: https://git.openjdk.java.net/jfx/pull/657