Re: RFR: 8281953: NullPointer in InputMethod components in JFXPanel [v2]

2022-02-21 Thread Ajit Ghaisas 
On Mon, 21 Feb 2022 12:35:34 GMT, eduardsdv  wrote:

>> If the InputMethod's node is not in the scene, the default text location 
>> point is returned.
>
> eduardsdv has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>8281953: Format TextInputControlSkinTest

Marked as reviewed by aghaisas (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/735

Re: RFR: 8281953: NullPointer in InputMethod components in JFXPanel [v2]

2022-02-21 Thread eduardsdv 
On Mon, 21 Feb 2022 11:30:17 GMT, Ajit Ghaisas  wrote:

>> eduardsdv has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>8281953: Format TextInputControlSkinTest
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TextInputControlSkinTest.java
>  line 105:
> 
>> 103: // and that the default point is returned.
>> 104: Point2D point = 
>> textField.getInputMethodRequests().getTextLocation(0);
>> 105: assertEquals(new Point2D(0,0), point);
> 
> Very minor : Please add a space between `0,0`

I added the space and checked the fix again with the sample program. 
The fix works, the NullPointer does not occur anymore.

-

PR: https://git.openjdk.java.net/jfx/pull/735

Re: RFR: 8281953: NullPointer in InputMethod components in JFXPanel [v2]

2022-02-21 Thread eduardsdv 
> If the InputMethod's node is not in the scene, the default text location 
> point is returned.

eduardsdv has updated the pull request incrementally with one additional commit 
since the last revision:

   8281953: Format TextInputControlSkinTest

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/735/files
  - new: https://git.openjdk.java.net/jfx/pull/735/files/c9c66b47..755444da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=735&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=735&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/735.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/735/head:pull/735

PR: https://git.openjdk.java.net/jfx/pull/735