Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197: TableColumnHeader: calc of cell width must respect row styling > (TreeTableView) > >Test class cosmetic cleanups #2. > - 8285197: TableColumnHeader: calc of cell width must respect row styling > (TreeTableView) > >Test class cosmetic cleanups. Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197: TableColumnHeader: calc of cell width must respect row styling > (TreeTableView) > >Test class cosmetic cleanups #2. > - 8285197: TableColumnHeader: calc of cell width must respect row styling > (TreeTableView) > >Test class cosmetic cleanups. Marked as reviewed by mhanl (Author). - PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]
On Thu, 12 May 2022 05:22:38 GMT, Ajit Ghaisas wrote: >> Robert Lichtenberger has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8285197: TableColumnHeader: calc of cell width must respect row styling >> (TreeTableView) >> >>Test class cosmetic cleanups #2. >> - 8285197: TableColumnHeader: calc of cell width must respect row styling >> (TreeTableView) >> >>Test class cosmetic cleanups. > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights >> reserved. > > Replace "2018, 2021" with just "2022" as this is newly introduced test file. done > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java > line 51: > >> 49: import java.util.List; >> 50: >> 51: import static org.junit.Assert.*; > > Replace generic import statement with specific ones. done - PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Finally found the time to cleanup the test class... - PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]
> Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Robert Lichtenberger has updated the pull request incrementally with two additional commits since the last revision: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Test class cosmetic cleanups #2. - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Test class cosmetic cleanups. - Changes: - all: https://git.openjdk.java.net/jfx/pull/779/files - new: https://git.openjdk.java.net/jfx/pull/779/files/38d930a8..68f7c806 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=779=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=779=00-01 Stats: 13 lines in 1 file changed: 3 ins; 6 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/779.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/779/head:pull/779 PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. The fix looks good. The newly introduced test file needs some cosmetic cleanups. modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights > reserved. Replace "2018, 2021" with just "2022" as this is newly introduced test file. modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 33: > 31: import javafx.event.Event; > 32: import javafx.scene.Node; > 33: import javafx.scene.control.*; Replace generic import statement with specific ones. modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableColumnHeaderTest.java line 51: > 49: import java.util.List; > 50: > 51: import static org.junit.Assert.*; Replace generic import statement with specific ones. - Changes requested by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Looks good! Verified that the fix works. I can also confirm, that this fix is the same as previously done for `TableView` in PR: https://github.com/openjdk/jfx/pull/757 - Marked as reviewed by mhanl (Author). PR: https://git.openjdk.java.net/jfx/pull/779
RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
Separate test class added for TreeTableView case. Fix is analogous to JDK-8251480. - Commit messages: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Changes: https://git.openjdk.java.net/jfx/pull/779/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=779=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285197 Stats: 183 lines in 2 files changed: 179 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/779.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/779/head:pull/779 PR: https://git.openjdk.java.net/jfx/pull/779
