Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-10-01 Thread Ambarish Rapte
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus  wrote:

>> Fixes the issue by using the "open" command as discussed before.
>> See: https://bugs.openjdk.java.net/browse/JDK-8214158
>
> Michael Paus has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed two minor formatting issues

Looks good. Verified on Mac and Windows.

-

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/634


Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Kevin Rushforth
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus  wrote:

>> Fixes the issue by using the "open" command as discussed before.
>> See: https://bugs.openjdk.java.net/browse/JDK-8214158
>
> Michael Paus has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fixed two minor formatting issues

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/634


Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT [v5]

2021-09-30 Thread Michael Paus
> Fixes the issue by using the "open" command as discussed before.
> See: https://bugs.openjdk.java.net/browse/JDK-8214158

Michael Paus has updated the pull request incrementally with one additional 
commit since the last revision:

  Fixed two minor formatting issues

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/634/files
  - new: https://git.openjdk.java.net/jfx/pull/634/files/4e510dec..24ceab1c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=634&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=634&range=03-04

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/634.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/634/head:pull/634

PR: https://git.openjdk.java.net/jfx/pull/634