Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct unintentional change Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct unintentional change Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct unintentional change Looks good on Linux. - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote: >> Include additional stabilization fixes of WebKit 613.1 >> Sanity testing did not show any concerns. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > correct unintentional change So far all my testing looks good, but I'll finish tomorrow. - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 08:49:15 GMT, danielpeintner wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct unintentional change > > modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRetainPtr.h > line 9: > >> 7: * >> 8: * 1. Redistributions of source code must retain the above copyright >> 9: q * notice, this list of conditions and the following disclaimer. > > seems to be unintentional Thank you, It is corrected now. - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
> Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: correct unintentional change - Changes: - all: https://git.openjdk.java.net/jfx/pull/733/files - new: https://git.openjdk.java.net/jfx/pull/733/files/e58b3e38..a725f3dc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=733&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=733&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/733.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/733/head:pull/733 PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes
On Wed, 16 Feb 2022 08:07:35 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRetainPtr.h line 9: > 7: * > 8: * 1. Redistributions of source code must retain the above copyright > 9: q * notice, this list of conditions and the following disclaimer. seems to be unintentional - PR: https://git.openjdk.java.net/jfx/pull/733
