Re: RFR: 8285534: Update the 3D lighting test sample [v3]
On Thu, 28 Apr 2022 17:28:34 GMT, Nir Lisker wrote: >> Update the the test utility. Includes: >> * Refactoring since there is no more need the split pre- and >> post-attenuation and light types. >> * Added customizable material to the `Boxes` to test the interaction between >> lights and materials.. >> * Light colors can now be changed. >> * Added ambient lights, >> >> Note that GitHub decided to count the removal of the `AttenLightingSample` >> and addition of the `Controls` file as renaming. The sample is now run now >> only through `LightingSample`. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added ambient lights This looks like a nice improvement to the test app. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/787
Re: RFR: 8285534: Update the 3D lighting test sample [v3]
> Update the the test utility. Includes: > * Refactoring since there is no more need the split pre- and post-attenuation > and light types. > * Added customizable material to the `Boxes` to test the interaction between > lights and materials.. > * Light colors can now be changed. > > Note that GitHub decided to count the removal of the `AttenLightingSample` > and addition of the `Controls` file as renaming. The sample is now run now > only through `LightingSample`. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added ambient lights - Changes: - all: https://git.openjdk.java.net/jfx/pull/787/files - new: https://git.openjdk.java.net/jfx/pull/787/files/dae9c1d7..cbca5f8f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=787&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=787&range=01-02 Stats: 23 lines in 3 files changed: 18 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/787.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/787/head:pull/787 PR: https://git.openjdk.java.net/jfx/pull/787
