Re: Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Artem Ananiev


On 11/7/2013 7:38 PM, Stephen F Northover wrote:

Artem old friend!!

We are moving all sorts of comments like this over to the JIRA rather
than sending them to the list.


My bad. I've duplicated this question in RT-34077 comments.

Thanks,

Artem


Steve

On 2013-11-07 10:24 AM, Artem Ananiev wrote:

Hi, Petr,

since the return value now depends on presence/absence of FX scene
embedded into JFXPanel, shouldn't we also change setEmbeddedScene() in
JFXPanel.HostContainer?

Thanks,

Artem




Re: Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Stephen F Northover

Artem old friend!!

We are moving all sorts of comments like this over to the JIRA rather 
than sending them to the list.


Steve

On 2013-11-07 10:24 AM, Artem Ananiev wrote:

Hi, Petr,

since the return value now depends on presence/absence of FX scene 
embedded into JFXPanel, shouldn't we also change setEmbeddedScene() in 
JFXPanel.HostContainer?


Thanks,

Artem 




Re: Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Artem Ananiev

Hi, Petr,

since the return value now depends on presence/absence of FX scene 
embedded into JFXPanel, shouldn't we also change setEmbeddedScene() in 
JFXPanel.HostContainer?


Thanks,

Artem

On 11/7/2013 4:48 PM, Petr Pchelko wrote:

Hello, OpenJFX community.

Please review the fix for the issue: 
https://javafx-jira.kenai.com/browse/RT-34077
The webrev is available at: http://cr.openjdk.java.net/~pchelko/fx/34077/webrev/

Thank you.
With best regards. Petr.



Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Petr Pchelko
Hello, OpenJFX community.

Please review the fix for the issue: 
https://javafx-jira.kenai.com/browse/RT-34077
The webrev is available at: http://cr.openjdk.java.net/~pchelko/fx/34077/webrev/

Thank you.
With best regards. Petr.