Remove
> On Aug 17, 2020, at 4:35 AM, openjfx-dev-requ...@openjdk.java.net wrote: > > Send openjfx-dev mailing list submissions to > openjfx-dev@openjdk.java.net > > To subscribe or unsubscribe via the World Wide Web, visit > https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev > or, via email, send a message with subject or body 'help' to > openjfx-dev-requ...@openjdk.java.net > > You can reach the person managing the list at > openjfx-dev-ow...@openjdk.java.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of openjfx-dev digest..." > > > Today's Topics: > > 1. Make TransformationList (Filtered and Sorted) extendable > (Tobias Diez) > 2. Re: Unable to import OpenJFX Build into Eclipse (Nir Lisker) > 3. [jfx15] RFR: 8249537: Update copyright header for files > modified in 2020 (Ambarish Rapte) > 4. Re: Unable to import OpenJFX Build into Eclipse (Tom Schindl) > 5. RFR: 8251352: Many javafx.base classes have implicit no-arg > constructors (Bhawesh Choudhary) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sun, 16 Aug 2020 15:28:25 +0200 > From: "Tobias Diez" <tobiasd...@gmx.de> > To: <openjfx-dev@openjdk.java.net> > Subject: Make TransformationList (Filtered and Sorted) extendable > Message-ID: <000601d673d1$1ef218f0$5cd64ad0$@gmx.de> > Content-Type: text/plain; charset="us-ascii" > > Hello everybody, > > Right now it is hard to extend the FilteredList and the SortedList as these > classes are marked final. This makes it practically impossible to add > convenient helper methods, or change or extend the behavior of these > classes. > I agree that normally you don't need to extend them, but I also don't see > any reason why you shouldn't be allowed to do so. > > Usually, you could use composition over inheritance if a class is marked > final but you still want to extend it. However, some of the controls expect > really a SortedList , e.g. > https://github.com/openjdk/jfx/blob/master/modules/javafx.controls/src/main/ > java/javafx/scene/control/TableView.java#L442 > So this approach does not work either. > > The motivation for me comes from some limitations that we encountered while > developing EasyBind, a small library to make bindings easier. We provide a > few convenient methods that extend the ObservableList, and we want to > provide a fluent interface similar to streams, e.g. > EasyBind.wrap(standard observable list).filter(predicate).map(mapper). > For this to work, the filter method needs to return a FilteredList with the > additional map method. The easiest solution would be to derive from > FilteredList, and implement the "EasyObservableList" interface that we have. > > Removing the final keyword is done in the following PR: > https://github.com/openjdk/jfx/pull/278 > > Looking forward to your feedback. > Best regards > Tobias > > > > ------------------------------ > > Message: 2 > Date: Sun, 16 Aug 2020 22:49:47 +0300 > From: Nir Lisker <nlis...@gmail.com> > To: Andrew Waters <gb91...@gmail.com> > Cc: "openjfx-dev@openjdk.java.net Mailing" > <openjfx-dev@openjdk.java.net> > Subject: Re: Unable to import OpenJFX Build into Eclipse > Message-ID: > <ca+0ynh9qzwjc7xtayoqegq2zl99ibkjmz8rhjt7kr0swtn4...@mail.gmail.com> > Content-Type: text/plain; charset="UTF-8" > > Hi Andrew, > > I did the same setup only with Ubuntu 18, which shouldn't matter, and I > don't remember having this issue. I can try redoing it next time I boot the > Ubuntu partition. > > What looks odd is that the error references the build directory. What > happens if you clean the project first? > > - Nir > >> On Sat, Aug 15, 2020 at 1:55 PM Andrew Waters <gb91...@gmail.com> wrote: >> >> Hi All, >> >> >> I'm trying to diagnose a bug in OpenJFX that I've been struggling with >> on and off for almost a year(!) and I decided to build OpenJFX from >> source and use Eclipse to help. I've built a brand new Ubuntu >> 20.04.1-Desktop system with OpenJDK 14.0.1 and the latest stable OpenJFX >> 14. I've run the Gradle build and run the tests and all looks 100%. >> >> >> When importing the root directory (home/jdkdev/dev/jfx) into Eclipse >> using the gradle import tool (using the wrapper option as recommended) I >> get this build path error: >> >> >> Cannot nest >> 'home/jdkdev/dev/jfx/modules/javafx.base/build/classes/java/main/javafx.base' >> >> inside library >> 'home/jdkdev/dev/jfx/modules/javafx.base/build/classes/java/main' >> >> >> It seems to be trying to set up a looped import to itself somehow. I've >> tried to edit the build path in eclipse but the fields appear to be all >> non-editable. Has anyone any idea as to what the problem is and how to >> fix it? Has anyone recently done a successful import with these latest >> levels? >> >> >> As this is the base module none of the other modules compile of course >> so they too may have other problems once the base module is fixed. >> >> >> I tried the "existing projects" import too but that just appears to have >> even more problems. >> >> >> Thanks, >> >> Andrew Waters >> >> UK. >> >> > > > ------------------------------ > > Message: 3 > Date: Mon, 17 Aug 2020 06:45:26 GMT > From: Ambarish Rapte <ara...@openjdk.java.net> > To: <openjfx-dev@openjdk.java.net> > Subject: [jfx15] RFR: 8249537: Update copyright header for files > modified in 2020 > Message-ID: > > <jow5rkKXiKRIhCHD2np6RMInjJNubGmYh6g4XE_VYKQ=.94530360-6bd0-4c47-9522-fa9f32ba4...@github.com> > > Content-Type: text/plain; charset=utf-8 > > Update last modified year of copyright headers for files modified in 2020. > > ------------- > > Commit messages: > - 8249537: Update copyright header for files modified in 2020 > > Changes: https://git.openjdk.java.net/jfx/pull/281/files > Webrev: https://webrevs.openjdk.java.net/jfx/281/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8249537 > Stats: 92 lines in 91 files changed: 0 ins; 0 del; 92 mod > Patch: https://git.openjdk.java.net/jfx/pull/281.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/281/head:pull/281 > > PR: https://git.openjdk.java.net/jfx/pull/281 > > > ------------------------------ > > Message: 4 > Date: Mon, 17 Aug 2020 09:42:24 +0200 > From: Tom Schindl <tom.schi...@bestsolution.at> > To: openjfx-dev@openjdk.java.net > Subject: Re: Unable to import OpenJFX Build into Eclipse > Message-ID: <0ba0cda3-600f-fa39-45ad-1f7f05565...@bestsolution.at> > Content-Type: text/plain; charset=utf-8; format=flowed > > Hi, > > Do we really use the Eclipse-Gradle-Tooling now? I think the reasons we > checked in all .product/.classpath files is that this did not work in > the past. > > At least my Eclipse install I use for OpenJFX-Development does not have > the gradle-tooling installed and things work there just fine. > > Tom > >> Am 16.08.20 um 21:49 schrieb Nir Lisker: >> Hi Andrew, >> >> I did the same setup only with Ubuntu 18, which shouldn't matter, and I >> don't remember having this issue. I can try redoing it next time I boot the >> Ubuntu partition. >> >> What looks odd is that the error references the build directory. What >> happens if you clean the project first? >> >> - Nir >> >>> On Sat, Aug 15, 2020 at 1:55 PM Andrew Waters <gb91...@gmail.com> wrote: >>> >>> Hi All, >>> >>> >>> I'm trying to diagnose a bug in OpenJFX that I've been struggling with >>> on and off for almost a year(!) and I decided to build OpenJFX from >>> source and use Eclipse to help. I've built a brand new Ubuntu >>> 20.04.1-Desktop system with OpenJDK 14.0.1 and the latest stable OpenJFX >>> 14. I've run the Gradle build and run the tests and all looks 100%. >>> >>> >>> When importing the root directory (home/jdkdev/dev/jfx) into Eclipse >>> using the gradle import tool (using the wrapper option as recommended) I >>> get this build path error: >>> >>> >>> Cannot nest >>> 'home/jdkdev/dev/jfx/modules/javafx.base/build/classes/java/main/javafx.base' >>> >>> inside library >>> 'home/jdkdev/dev/jfx/modules/javafx.base/build/classes/java/main' >>> >>> >>> It seems to be trying to set up a looped import to itself somehow. I've >>> tried to edit the build path in eclipse but the fields appear to be all >>> non-editable. Has anyone any idea as to what the problem is and how to >>> fix it? Has anyone recently done a successful import with these latest >>> levels? >>> >>> >>> As this is the base module none of the other modules compile of course >>> so they too may have other problems once the base module is fixed. >>> >>> >>> I tried the "existing projects" import too but that just appears to have >>> even more problems. >>> >>> >>> Thanks, >>> >>> Andrew Waters >>> >>> UK. >>> >>> > > > ------------------------------ > > Message: 5 > Date: Mon, 17 Aug 2020 09:30:48 GMT > From: Bhawesh Choudhary <bchoudh...@openjdk.java.net> > To: <openjfx-dev@openjdk.java.net> > Subject: RFR: 8251352: Many javafx.base classes have implicit no-arg > constructors > Message-ID: > > <pSyTWr7y4wo73X5Gj0mgTf2dym6IGIXw-0V5Jgqy65A=.3c9bdfbd-02ea-4dc2-8b49-7a10e7346...@github.com> > > Content-Type: text/plain; charset=utf-8 > > Added missing explicit no-arg constructors to classes in package > javafx.beans.property, javafx.collections, javafx.util > and javafx.util.converter in module javafx.base. > > ------------- > > Commit messages: > - 8251352: Many javafx.base classes have implicit no-arg constructors > > Changes: https://git.openjdk.java.net/jfx/pull/282/files > Webrev: https://webrevs.openjdk.java.net/jfx/282/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8251352 > Stats: 224 lines in 35 files changed: 224 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jfx/pull/282.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/282/head:pull/282 > > PR: https://git.openjdk.java.net/jfx/pull/282 > > > End of openjfx-dev Digest, Vol 105, Issue 26 > ********************************************
