[RFR] [openjfx13] 8222912: Websocket client doesn't work in WebView
Hi Kevin, Please review the following PR, JBS: https://bugs.openjdk.java.net/browse/JDK-8222912 https://github.com/javafxports/openjdk-jfx/pull/524 Thanks, Arun
[RFR] [openjfx13] 8227431: [Windows] Fix assertion failure on X86 32-bit when enabling CLOOP based JavaScript interpreter
Hi Kevin, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/525 Thanks, Arun
Re: [Integrated] RFR: 8211308: Support HTTP/2 in WebView
Changeset: 98035cb2 Author:Arunprasad Rajkumar Date: 2019-12-03 08:24:01 + URL: https://git.openjdk.java.net/jfx/commit/98035cb2 8211308: Support HTTP/2 in WebView Reviewed-by: ghb, kcr ! modules/javafx.web/src/main/java/com/sun/webkit/network/ByteBufferPool.java + modules/javafx.web/src/main/java/com/sun/webkit/network/HTTP2Loader.java ! modules/javafx.web/src/main/java/com/sun/webkit/network/NetworkContext.java ! modules/javafx.web/src/main/java/com/sun/webkit/network/URLLoader.java + modules/javafx.web/src/main/java/com/sun/webkit/network/URLLoaderBase.java ! modules/javafx.web/src/main/java/module-info.java ! modules/javafx.web/src/main/native/Source/WebCore/mapfile-macosx ! modules/javafx.web/src/main/native/Source/WebCore/mapfile-vers ! modules/javafx.web/src/main/native/Source/WebCore/platform/java/IDNJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceHandle.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/ResourceHandleInternal.h ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/java/ResourceHandleJava.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/java/URLLoader.cpp ! modules/javafx.web/src/main/native/Source/WebCore/platform/network/java/URLLoader.h
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >> wrote: >> >>> 8232158: [macOS] Fallback to command line tools if xcode is missing >>> >>> >>> >>> Commits: >>> - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode >>> is missing >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/13/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 >>> Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/13.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 >> >> @kevinrushforth Am I missing anything here which prevents the review process? > > No, I have just been swamped the last few days. It's on my list to review. > Sorry for the delay. Thanks @kevin. PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8211308: Support HTTP/2 in WebView
On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg wrote: > On Fri, 11 Oct 2019 07:01:48 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: >> >>> On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar >>> wrote: >>> >>>> On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar >>>> wrote: >>>> >>>>> The goal of this enhancement is to use new [HttpClient >>>>> APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) >>>>> available from JDK 11. >>>>> >>>>> Reference: >>>>> [1] https://openjdk.java.net/groups/net/httpclient/intro.html >>>>> [2] >>>>> https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html >>>>> >>>>> Though this uses JDK 11 HttpClient APIs, it needs latest JDK 12 to work >>>>> correctly due to the dependency on following issues, >>>>> >>>>> [JDK-8218546](https://bugs.openjdk.java.net/browse/JDK-8218546) Unable to >>>>> connect to https://google.com using java.net.HttpClient >>>>> [JDK-8218662](https://bugs.openjdk.java.net/browse/JDK-8218662) Allow 204 >>>>> responses with Content-Length:0 >>>>> [JDK-8203850](https://bugs.openjdk.java.net/browse/JDK-8203850) >>>>> java.net.http HTTP client should allow specifying Origin and Referer >>>>> headers >>>>> >>>>> Task List >>>>> - [x] simple GET requests >>>>> - [x] Runtime setting to fallback to legacy client >>>>> - [ ] Runtime settings to use *only* HTTP/1.1 >>>>> - [x] sync requests >>>>> - [x] Error Handling & Propagation >>>>> - [x] POST with form data >>>>> - [x] AccessController association for HttpClient.sendAsync / send >>>>> - [x] Redirection >>>>> - [ ] Check for possibilities to write unit tests >>>>> - [ ] Sync request handling from WebCore java platform layer >>>>> - [x] Make use of singleton instance of direct ByteBuffer instead of >>>>> using allocator pool >>>>> - [x] gzip, deflate encoding support >>>>> >>>>> HTTP/2 Test pages >>>>> - http://www.http2demo.io >>>>> - https://http2.akamai.com/demo >>>>> - https://http2.golang.org >>>>> - https://google.com >>>>> >>>>> Redirection Test >>>>> - https://www.httpwatch.com/httpgallery/redirection/#showExample7 >>>>> >>>>> More details are available at >>>>> https://github.com/javafxports/openjdk-jfx/pull/247. >>>>> >>>>> >>>>> >>>>> Commits: >>>>> - 1798a661: 8211308: Support HTTP/2 in WebView >>>>> >>>>> Changes: https://git.openjdk.java.net/jfx/pull/14/files >>>>> Webrev: https://webrevs.openjdk.java.net/jfx/14/webrev.00 >>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8211308 >>>>> Stats: 1161 lines in 14 files changed: 876 ins; 217 del; 68 mod >>>>> Patch: https://git.openjdk.java.net/jfx/pull/14.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14 >>>> >>>> Still few changes need to be done as [suggested >>>> by](https://github.com/javafxports/openjdk-jfx/pull/247#pullrequestreview-283699613) >>>> @kevinrushforth. >>> >>> Good work. Should the title be prefixed with WIP until it's ready for >>> review, so that Skara will send the RFR when it is ready for review? >> >> I was wondering why @skara had sent the RFR when the PR is still in draft >> stage. Actually @skara should consider the "Draft" attribute associated with >> the PR. > > Good point, I've created https://bugs.openjdk.java.net/browse/SKARA-129 to > track this. @jfx team, now it is ready for a fresh review :) PR: https://git.openjdk.java.net/jfx/pull/14
Re: [Rev 01] RFR: WIP: 8211308: Support HTTP/2 in WebView
The pull request has been updated with additional changes. Added commits: - 1832c2db: Incorporate fixes provided by @kcr Changes: - all: https://git.openjdk.java.net/jfx/pull/14/files - new: https://git.openjdk.java.net/jfx/pull/14/files/1798a661..1832c2db Webrevs: - full: https://webrevs.openjdk.java.net/jfx/14/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/14/webrev.00-01 Stats: 13 lines in 2 files changed: 5 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/14.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14 PR: https://git.openjdk.java.net/jfx/pull/14
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.net/jfx/pull/13/files > Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 > Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod > Patch: https://git.openjdk.java.net/jfx/pull/13.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 @kevinrushforth Am I missing anything here which prevents the review process? PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Wed, 16 Oct 2019 15:54:54 GMT, Arunprasad Rajkumar wrote: > On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > >> On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >>> wrote: >>> >>>> 8232158: [macOS] Fallback to command line tools if xcode is missing >>>> >>>> >>>> >>>> Commits: >>>> - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode >>>> is missing >>>> >>>> Changes: https://git.openjdk.java.net/jfx/pull/13/files >>>> Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 >>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 >>>> Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod >>>> Patch: https://git.openjdk.java.net/jfx/pull/13.diff >>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 >>> >>> @kevinrushforth Am I missing anything here which prevents the review >>> process? >> >> No, I have just been swamped the last few days. It's on my list to review. >> Sorry for the delay. > > Thanks @kevin. @johanvos , Do you have any concern? In short, this fix allows developers to build jfx on mac without full Xcode install. It would be useful for CI/CD. PR: https://git.openjdk.java.net/jfx/pull/13
Re: [Integrated] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
Changeset: ab6ea3b9 Author:Arunprasad Rajkumar Date: 2019-10-23 08:41:40 + URL: https://git.openjdk.java.net/jfx/commit/ab6ea3b9 8232158: [macOS] Fallback to command line tools if xcode is missing Reviewed-by: kcr, jvos ! buildSrc/mac.gradle
Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote:
> Memory allocated in initDecompressor() and decompressIndirect() is not freed
> in error case.
> In error case,
> 1. Allocated memory should be freed.
> 2. Appropriate de-initialization jpeg library calls should be added.
>
> Verified that,
> 1. All unit and systems tests pass on three platforms, and
> 2. Memory consumption with and without fix is similar by comparing memory
> before and after showing 10 jpeg images for 100 times.
>
>
>
> Commits:
> - 7af932b7: 8212034: Memory leaks in jpegLoader.c in error case
>
> Changes: https://git.openjdk.java.net/jfx/pull/54/files
> Webrev: https://webrevs.openjdk.java.net/jfx/54/webrev.00
> Issue: https://bugs.openjdk.java.net/browse/JDK-8212034
> Stats: 62 lines in 1 file changed: 36 ins; 14 del; 12 mod
> Patch: https://git.openjdk.java.net/jfx/pull/54.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/54/head:pull/54
modules/javafx.graphics/src/main/native-iio/jpegloader.c line 1625:
> 1624:
> 1625: JSAMPROW scanline_ptr = (JSAMPROW) malloc(bytes_per_row * sizeof
> (JSAMPLE));
> 1626: if (scanline_ptr == NULL) {
You can remove quite a few calls to `free` if you move the memory allocation
for `scanline_ptr` just [before it's
usage](https://github.com/openjdk/jfx/blob/7af932b7f5215949776ec79fb2a5484c521b21a1/modules/javafx.graphics/src/main/native-iio/jpegloader.c#L1690).
Also free it as soon as you are done with it.
PR: https://git.openjdk.java.net/jfx/pull/54
RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
8232158: [macOS] Fallback to command line tools if xcode is missing Commits: - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is missing Changes: https://git.openjdk.java.net/jfx/pull/13/files Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod Patch: https://git.openjdk.java.net/jfx/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 PR: https://git.openjdk.java.net/jfx/pull/13
RFR: 8211308: Support HTTP/2 in WebView
The goal of this enhancement is to use new [HttpClient APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) available from JDK 11. Reference: [1] https://openjdk.java.net/groups/net/httpclient/intro.html [2] https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html Though this uses JDK 11 HttpClient APIs, it needs latest JDK 12 to work correctly due to the dependency on following issues, [JDK-8218546](https://bugs.openjdk.java.net/browse/JDK-8218546) Unable to connect to https://google.com using java.net.HttpClient [JDK-8218662](https://bugs.openjdk.java.net/browse/JDK-8218662) Allow 204 responses with Content-Length:0 [JDK-8203850](https://bugs.openjdk.java.net/browse/JDK-8203850) java.net.http HTTP client should allow specifying Origin and Referer headers Task List - [x] simple GET requests - [x] Runtime setting to fallback to legacy client - [ ] Runtime settings to use *only* HTTP/1.1 - [x] sync requests - [x] Error Handling & Propagation - [x] POST with form data - [x] AccessController association for HttpClient.sendAsync / send - [x] Redirection - [ ] Check for possibilities to write unit tests - [ ] Sync request handling from WebCore java platform layer - [x] Make use of singleton instance of direct ByteBuffer instead of using allocator pool - [x] gzip, deflate encoding support HTTP/2 Test pages - http://www.http2demo.io - https://http2.akamai.com/demo - https://http2.golang.org - https://google.com Redirection Test - https://www.httpwatch.com/httpgallery/redirection/#showExample7 More details are available at https://github.com/javafxports/openjdk-jfx/pull/247. Commits: - 1798a661: 8211308: Support HTTP/2 in WebView Changes: https://git.openjdk.java.net/jfx/pull/14/files Webrev: https://webrevs.openjdk.java.net/jfx/14/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8211308 Stats: 1161 lines in 14 files changed: 876 ins; 217 del; 68 mod Patch: https://git.openjdk.java.net/jfx/pull/14.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14 PR: https://git.openjdk.java.net/jfx/pull/14
Re: [Rev 01] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
The pull request has been updated with additional changes. Added commits: - 9b1f7286: 8232158: [macOS] Fallback to command line tools if xcode is missing Changes: - all: https://git.openjdk.java.net/jfx/pull/13/files - new: https://git.openjdk.java.net/jfx/pull/13/files/063d2f38..9b1f7286 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/13/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/13/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8211308: Support HTTP/2 in WebView
On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar wrote: > The goal of this enhancement is to use new [HttpClient > APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) > available from JDK 11. > > Reference: > [1] https://openjdk.java.net/groups/net/httpclient/intro.html > [2] > https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html > > Though this uses JDK 11 HttpClient APIs, it needs latest JDK 12 to work > correctly due to the dependency on following issues, > > [JDK-8218546](https://bugs.openjdk.java.net/browse/JDK-8218546) Unable to > connect to https://google.com using java.net.HttpClient > [JDK-8218662](https://bugs.openjdk.java.net/browse/JDK-8218662) Allow 204 > responses with Content-Length:0 > [JDK-8203850](https://bugs.openjdk.java.net/browse/JDK-8203850) java.net.http > HTTP client should allow specifying Origin and Referer headers > > Task List > - [x] simple GET requests > - [x] Runtime setting to fallback to legacy client > - [ ] Runtime settings to use *only* HTTP/1.1 > - [x] sync requests > - [x] Error Handling & Propagation > - [x] POST with form data > - [x] AccessController association for HttpClient.sendAsync / send > - [x] Redirection > - [ ] Check for possibilities to write unit tests > - [ ] Sync request handling from WebCore java platform layer > - [x] Make use of singleton instance of direct ByteBuffer instead of using > allocator pool > - [x] gzip, deflate encoding support > > HTTP/2 Test pages > - http://www.http2demo.io > - https://http2.akamai.com/demo > - https://http2.golang.org > - https://google.com > > Redirection Test > - https://www.httpwatch.com/httpgallery/redirection/#showExample7 > > More details are available at > https://github.com/javafxports/openjdk-jfx/pull/247. > > > > Commits: > - 1798a661: 8211308: Support HTTP/2 in WebView > > Changes: https://git.openjdk.java.net/jfx/pull/14/files > Webrev: https://webrevs.openjdk.java.net/jfx/14/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8211308 > Stats: 1161 lines in 14 files changed: 876 ins; 217 del; 68 mod > Patch: https://git.openjdk.java.net/jfx/pull/14.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14 Still few changes need to be done as [suggested by](https://github.com/javafxports/openjdk-jfx/pull/247#pullrequestreview-283699613) @kevinrushforth. PR: https://git.openjdk.java.net/jfx/pull/14
Re: RFR: WIP: 8211308: Support HTTP/2 in WebView
On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: > On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar >> wrote: >> >>> The goal of this enhancement is to use new [HttpClient >>> APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) >>> available from JDK 11. >>> >>> Reference: >>> [1] https://openjdk.java.net/groups/net/httpclient/intro.html >>> [2] >>> https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html >>> >>> Though this uses JDK 11 HttpClient APIs, it needs latest JDK 12 to work >>> correctly due to the dependency on following issues, >>> >>> [JDK-8218546](https://bugs.openjdk.java.net/browse/JDK-8218546) Unable to >>> connect to https://google.com using java.net.HttpClient >>> [JDK-8218662](https://bugs.openjdk.java.net/browse/JDK-8218662) Allow 204 >>> responses with Content-Length:0 >>> [JDK-8203850](https://bugs.openjdk.java.net/browse/JDK-8203850) >>> java.net.http HTTP client should allow specifying Origin and Referer headers >>> >>> Task List >>> - [x] simple GET requests >>> - [x] Runtime setting to fallback to legacy client >>> - [ ] Runtime settings to use *only* HTTP/1.1 >>> - [x] sync requests >>> - [x] Error Handling & Propagation >>> - [x] POST with form data >>> - [x] AccessController association for HttpClient.sendAsync / send >>> - [x] Redirection >>> - [ ] Check for possibilities to write unit tests >>> - [ ] Sync request handling from WebCore java platform layer >>> - [x] Make use of singleton instance of direct ByteBuffer instead of using >>> allocator pool >>> - [x] gzip, deflate encoding support >>> >>> HTTP/2 Test pages >>> - http://www.http2demo.io >>> - https://http2.akamai.com/demo >>> - https://http2.golang.org >>> - https://google.com >>> >>> Redirection Test >>> - https://www.httpwatch.com/httpgallery/redirection/#showExample7 >>> >>> More details are available at >>> https://github.com/javafxports/openjdk-jfx/pull/247. >>> >>> >>> >>> Commits: >>> - 1798a661: 8211308: Support HTTP/2 in WebView >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/14/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/14/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8211308 >>> Stats: 1161 lines in 14 files changed: 876 ins; 217 del; 68 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/14.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/14/head:pull/14 >> >> Still few changes need to be done as [suggested >> by](https://github.com/javafxports/openjdk-jfx/pull/247#pullrequestreview-283699613) >> @kevinrushforth. > > Good work. Should the title be prefixed with WIP until it's ready for review, > so that Skara will send the RFR when it is ready for review? I was wondering why @skara had sent the RFR when the PR is still in draft stage. Actually @skara should consider the "Draft" attribute associated with the PR. PR: https://git.openjdk.java.net/jfx/pull/14
