Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request incrementally with one additional > commit since the last revision: > > Make use of Utils.clamp function I tested with Oracle OpenJDK 22.0.1 and JavaFX 22.0.1+7 Tested moving the cursor around but the narrator focus wont change. - PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2078260806
Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v22]
On Thu, 25 Apr 2024 19:39:02 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 30 additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into patch-1 > - Switch from `@EnabledOnOS` to `assumeTrue` > - Re-order for more clearness > - Fix tests > - Remove unused import > - classpath > - Fix JavaDoc formatting > - Discard changes to modules/javafx.graphics/src/test/addExports > - Add missing exports > - Try to use StubToolkit > - ... and 20 more: https://git.openjdk.org/jfx/compare/a7c1c59f...527e1ecf Tried on my local machine (win10) w/o patch with narrator:  - PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2078090611
