Re: RFR: 8341920: Intermittent WebKit build failure on Windows generating PDB files in 619.1
On Fri, 11 Oct 2024 17:22:02 GMT, Hima Bindu Meda wrote: > Disabled the pdb file generation in order to resolve the build failure. > Sanity testing looks fine. Verified build on windows, mac and linux. I ran a test and all builds succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1599#pullrequestreview-2364838351
Re: RFR: 8341164: Update boot JDK to 23
On Wed, 2 Oct 2024 17:09:59 GMT, Ambarish Rapte wrote: > Update the boot JDK to version 23. > > Since Gradle 8.9 does not support JDK 23, it is necessary to upgrade Gradle > to the latest release, version 8.10.2, which supports JDK 23. > It is advised to upgrade directly to Gradle 8.10.2 rather than 8.10. refer to > [the release notes](https://docs.gradle.org/8.10.2/release-notes.html) > > No modifications to the Gradle build script are required for upgrading the > Gradle version. Builds and tests all ran successfully. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1589#pullrequestreview-2344915142
Re: RFR: 8340980: Cannot build on Windows ARM
On Thu, 26 Sep 2024 01:45:14 GMT, Martin Fox wrote: > Restored some behavior in genVSproperties that enabled ARM builds and > cross-compilation on Windows. Verified that I can build on ARM but have no > way of testing other architectures. The change looks good to me. I've done a build on our build machine and it still correctly selected the x64 build environment. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1580#pullrequestreview-2330779129
Re: RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4
On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda wrote: > Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is > successful on all platforms.No issues seen Builds and tests ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1570#pullrequestreview-2309518303
Re: RFR: 8338701: Provide media support for libavcodec version 61
On Thu, 29 Aug 2024 21:02:41 GMT, Alexander Matveev wrote: > - Added support for libavcodec 61. > - Updated AV plugins to use new APIs instead of APIs which were removed in 61. > - We still using some deprecated APIs. > - `reordered_opaque` replacement exist in 61 which is used to pass user data > between compressed frame and uncompressed. In 61 this variable is pointer to > `void` instead of `int64_t`. We can use new `opaque` to pass PTS, but it is > not documented way to pass PTS between compressed and uncompressed frames. > Updated code will be using `AVPacket.pts/AVFrame.pts` which is documented way > to provide PTS. > - Tested on Ubuntu 24.10 with 61 and 24.04 with 60 with all supported formats. Everything went fine with the builds. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1552#pullrequestreview-2272100416
Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64 [v2]
On Thu, 29 Aug 2024 14:43:39 GMT, ANUPAM DEV wrote: >> Hi, >> >> I have updated the name of the SWT.jar that needs to be downloaded during >> the build process for Linux aarch64. >> from: >> IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : >> "" >> >> to: >> IS_LINUX && IS_AARCH64 ? >> "org.eclipse.swt.gtk.linux.aarch64_3.124.200.v20231113-1355" : >> IS_LINUX && !IS_AARCH64 ? >> "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : "" >> >> Please review. >> >> Regards, >> Anupam > > ANUPAM DEV has updated the pull request incrementally with one additional > commit since the last revision: > > Updated verification-metadata.xml. Added sha256 for Linux /aarch64 jar Build was successful on a linux aarch64 machine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1549#pullrequestreview-2271415809
Re: RFR: 8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
On Wed, 21 Aug 2024 09:53:24 GMT, Hima Bindu Meda wrote: > Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. > No issue seen. Builds and tests were successful on our infrastructure. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1541#pullrequestreview-2257085624
Re: RFR: 8336940: Update GStreamer to 1.24.6 [v2]
On Wed, 21 Aug 2024 21:36:52 GMT, Alexander Matveev wrote: >> - Updated GStreamer to 1.24.6 and Glib to 2.80.4. >> - Testing done on all platforms with all supported formats. >> - Removed gstpluginloader.c. This file contains additional plugin loading >> mechanism which we do not use. Latest GStreamer modified it heavily and it >> did not compile without pulling additional dependency from GLib, but since >> we do not use it anyway it was removed. Corresponding calls to >> gstpluginloader.c from gstregistry.c were disabled as well. >> - Removed DSD support from Alsa audio sink. Latest GStreamer added support >> for Alsa DSD (Direct Stream Digital), but we do not use it so it was >> removed. Also, such support requires newer libasound2 (ALSA) which is not >> available on older Linux distributions. >> - No other changes or bug fixes are done. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8336940: Update GStreamer to 1.24.6 [v3] Builds and tests ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1542#pullrequestreview-2253749840
Re: RFR: 8336632: Update Gradle to 8.9 [v3]
On Tue, 20 Aug 2024 16:53:09 GMT, Ambarish Rapte wrote: >> Gradle 8.8 released on May 31, 2024, supports JDK 22. >> On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest >> gradle 8.9 >> >> This gradle update is required in order to update the boot jdk to 22.0.2. >> The changes are minimal, no source code changes were required. >> >> This PR also includes the boot jdk update. > > Ambarish Rapte has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merge branch 'master' into gradle89-jdk2202 > - win bootjdk gha > - chmod 644 gradlew > - gradle 89, jdk 2202 > - revert gradle-wrapper.properties partially > - gradle 8.9 All builds succeeded with the newest gradle and JDK 22. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1539#pullrequestreview-2250075324
Re: RFR: 8338306: WebView Drag and Drop fails with WebKit 619.1 [v2]
On Tue, 20 Aug 2024 14:04:29 GMT, Hima Bindu Meda wrote: >> This commit resolves drag and drop issue observed with Webkit-619.1. >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove duplicate call Looking good. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1538#pullrequestreview-2249809325
Re: RFR: 8336938: Update libFFI to 3.4.6 [v2]
On Tue, 13 Aug 2024 19:04:09 GMT, Alexander Matveev wrote: >> - libFFI updated to 3.4.6. >> - No additional changes are done. >> - Tested on Windows, macOS and Linux with all supported formats. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8336938: Update libFFI to 3.4.6 [v2] All builds ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1531#pullrequestreview-2244997338
Re: RFR: 8328994 : Update WebKit to 619.1
On Fri, 12 Jul 2024 08:29:34 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v619.1. > Build is verified in mac , windows and linux. Sanity testing looks fine. No > issues seen. All builds succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1502#pullrequestreview-2180192559
Re: RFR: 8326712: Robot tests fail on XWayland
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev wrote: > Most of the headful test failures on XWayland are due to screen capture is > not working. > > Wayland, unlike X11, does not allow arbitrary applications to capture the > screen contents directly. > Instead, screen capture functionality is managed by the compositor, which can > enforce stricter controls and permissions, requiring explicit user approval > for screen capture operations. > > This issue is already resolved in OpenJDK ([base > issue](https://bugs.openjdk.org/browse/JDK-8280982), there are subsequent > fixes) by using the [ScreenCast XDG > portal](https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.ScreenCast.html). > > The XDG ScreenCast portal is utilized for capturing screen data as it > provides a secure and standardized method for applications to access screen > content. > Additionally, it allows for the reuse of user permissions without requiring > repeated confirmations, streamlining the user experience and enhancing > convenience. > > > > > So this changeset is a copy of the OpenJDK fixes with the addition of the > JavaFX customization. > For ease of review, you can skip the changes in the first two commits: > - First commit is a direct copy of files from OpenJDK > - Second commit removes the `gtk-` prefix before the `gtk_...` and `g_...` > function calls (in AWT all gtk functions are dynamically loaded, we don't > need that in JavaFX). > > properties added: > > - `javafx.robot.screenshotMethod`, accepts `gtk`(existing gtk method) and > `dbusScreencast`(added by this changeset, used by default for Wayland) > - `javafx.robot.screenshotDebug` prints debug info if it is set to `true` > > > > What are the remaining issues? > > 1. > > After applying this fix, system tests will pass except for the > `SwingNodeJDialogTest` test. > > This interop test calls `java.awt.Robot#getPixelColor` which internally > `gtk->g_main_context_iteration(NULL, TRUE);` causes a blocking of javafx gtk > loop, so the test hangs. > So a change is required on OpenJDK side to fix this issue. > > 2. > > Even after solving the `#1`, the > `SwingNodeJDialogTest.testNodeRemovalBeforeShow` case is still failing. > > 3. > > Internally the ScreenCast session keeps open for > [2s](https://github.com/openjdk/jdk/blob/d457609f700bbb1fed233f1a04501c995852e5ac/src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java#L62). > This is to reduce overhead in case of frequent consecutive screen captures. > > There is a crash when an AWT ScreenCast session overlaps with the FX > ScreenCast session. E.g. `java.awt.Robot#getPixelColor()` and `jav... The build still works as expected and documented on our CI infrastructure. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1490#pullrequestreview-2148098931
Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]
On Fri, 21 Jun 2024 00:07:33 GMT, Jay Bhaskar wrote: >> Issue: The Websocket Channel is broken >> Solution: The socket Provider needs a web page pointer, since the web socket >> channel source code is moved to WebkitLegacy in 617.1 for the web process >> model, it is invalid for JavaFx Webkit. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typos meesage to message Everything still built fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1477#pullrequestreview-2132158211
Integrated: 8333147: update maven classifier syntax to recent gradle version
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote: > Replaces the deprecated `classifier` property with `archiveClassifier`. The > property was removed with the release of Gradle 8.0: > https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup This pull request has now been integrated. Changeset: c8b96e4e Author: Joeri Sykora Committer: Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/c8b96e4e6da18b4ab1331bb3a5b48cf1b8b3e2e6 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8333147: update maven classifier syntax to recent gradle version Reviewed-by: kcr - PR: https://git.openjdk.org/jfx/pull/1472
RFR: 8333147: update maven classifier syntax to recent gradle version
Replaces the deprecated `classifier` property with `archiveClassifier`. The property was removed with the release of Gradle 8.0: https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup - Commit messages: - fix 8333147 Changes: https://git.openjdk.org/jfx/pull/1472/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1472&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333147 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jfx/pull/1472.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1472/head:pull/1472 PR: https://git.openjdk.org/jfx/pull/1472
Re: JavaFX applications fail to build with Maven 3.9.7
FYI, version 23-ea+20 should contain the fixed parent pom. Op wo 29 mei 2024 om 09:31 schreef Michael Hall : > > > On May 29, 2024, at 2:19 AM, Joeri Sykora wrote: > > Hi John, > > maven artifacts are generated when providing the following gradle > property: -PMAVEN_PUBLISH=true > > For the actual maven publication to maven central, Gluon uses a different > parent pom file, which indeed has those duplicate profile id's. > We'll provide a fix that will be available from 23-ea+19. > > As a workaround you can: > >- fallback to maven 3.9.6 or earlier >- manually specify the javafx.platform property, i.e.: mvn >-Djavafx.platform=linux compile > > Kind regards, > Joeri > > > Simply editing the file and deleting the duplicates also seemed to work > for me. At least it ran the validate command successfully. > >
Re: JavaFX applications fail to build with Maven 3.9.7
Hi John, maven artifacts are generated when providing the following gradle property: -PMAVEN_PUBLISH=true For the actual maven publication to maven central, Gluon uses a different parent pom file, which indeed has those duplicate profile id's. We'll provide a fix that will be available from 23-ea+19. As a workaround you can: - fallback to maven 3.9.6 or earlier - manually specify the javafx.platform property, i.e.: mvn -Djavafx.platform=linux compile Kind regards, Joeri Op wo 29 mei 2024 om 04:30 schreef John Neffenger : > It looks as if this issue was reported in 2021, 2022, and 2023. The > difference now is that, as of Maven 3.9.7, the failure occurs > immediately when it tries to download the JavaFX dependencies. > > 2021-12-27 > JDK-8279380: Duplicate profile id in JavaFX maven POM > https://bugs.openjdk.org/browse/JDK-8279380 > > 2022-12-22 > JDK-8299352: Duplicate profile id in JavaFX maven POM > https://bugs.openjdk.org/browse/JDK-8299352 > > 2023-03-24 > JDK-8305167: Duplicate profile ids in generated javafx-19.0.2.1.pom > https://bugs.openjdk.org/browse/JDK-8305167 > > Those three bugs were closed as duplicates of the following: > > 2021-12-23 > JDK-8279327: Maven Assembly Plugin Issues Warnings for JavaFx 17 Onwards > https://bugs.openjdk.org/browse/JDK-8279327 > > Comments in that bug report suggest reporting the issue to the JavaFX > Maven Plugin project, but I'm getting the error, and I don't use that > plugin. I also don't use the Maven Assembly Plugin. > > The Maven developers tell me the error is in the JavaFX parent POM file > itself. Is that published by Gluon? So far I've been unable to produce > the Maven artifacts using tasks in the JavaFX Gradle build file. > > Thanks, > John >
Re: RFR: 8332539: Update libxml2 to 2.12.7
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen Tests are green here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1464#pullrequestreview-2080216007
Re: RFR: 8331748: Update libxml2 to 2.12.6
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.6. Verified build and sanity testing on all > platforms. No issue seen All tests are green here too. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1453#pullrequestreview-2057279996
Re: RFR: 8329011: Update SQLite to 3.45.3
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote: > Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing > looks fine. Everything built fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1454#pullrequestreview-2055796129
Re: RFR: 8324326: Update ICU4C to 74.2
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms Builds and tests all ran fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1398#pullrequestreview-1936125774
Re: [jfx17u] RFR: 8318387: Update GStreamer to 1.22.6 [v2]
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote: >> Almost clean backport of JDK-8318386. >> The original patch contains a fix to gstaacparse.c which is not in jfx17u >> because it does not have JDK-8277309 (JDK-8277309) > > Johan Vos has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains two additional commits since > the last revision: > > - Merge branch 'openjdk:master' into backport-johanvos-606878af > - Backport 606878af275dbad551a10653c92a2deef61c10cd Build and tests succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx17u/pull/181#pullrequestreview-1922961943
Re: [jfx17u] RFR: 8318614: Update WebKit to 617.1 [v2]
On Thu, 7 Mar 2024 13:30:47 GMT, Johan Vos wrote: >> Hi all, >> >> This pull request contains a backport of commit >> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a) >> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. >> >> The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 >> and was reviewed by Joeri Sykora and Kevin Rushforth. >> >> Thanks! > > Johan Vos has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains two additional commits since > the last revision: > > - Merge branch 'openjdk:master' into backport-johanvos-ba79e081 > - Backport ba79e081547b7f15697bfaaac42ec2de1971935a Build and tests succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx17u/pull/182#pullrequestreview-1922613531
Re: RFR: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote: > Ported changes related to webkit-2.42.5. Verified build on all platforms. > Sanity testing looks fine. Builds and tests ran succesfully. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1362#pullrequestreview-1873140822
Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]
On Mon, 29 Jan 2024 04:24:54 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > space corrections Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1350#pullrequestreview-1850425295
Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]
On Fri, 26 Jan 2024 14:19:53 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Minor corrections as per review comments Everything built fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1350#pullrequestreview-1846426562
Re: RFR: 8318614: Update WebKit to 617.1
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote: > This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. > Sanity testing looks fine. No issues observed in HelloWebView as well All builds and tests went fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1328#pullrequestreview-1815631832
Re: RFR: 8321434: Update Gradle to 8.5
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version update. > > Also, merging the PR with boot jdk update to 21.0.1 b12 I ran the full build with tests on the major platforms and everything worked fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1300#pullrequestreview-1772757644
Re: RFR: 8318388: Update libxslt to 1.1.39 [v2]
On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote: >> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with two > additional commits since the last revision: > > - update license for libxslt > - update libxslt.md Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1298#pullrequestreview-1764114186
Re: RFR: 8318387: Update GStreamer to 1.22.6 [v2]
On Tue, 21 Nov 2023 01:03:07 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. >> - Tested on all platforms with all supported media streams. >> - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older >> GLib versions on Linux following APIs were changed from new to old one >> (restored GStreamer 1.20.1 code) (Linux only, other platforms using latest >> code): >> - g_queue_clear_full() -> g_queue_foreach(), g_queue_clear(). >> - g_atomic_rc_box_*() -> g_weak_ref_init(), g_weak_ref_clear(). > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8318387: Update GStreamer to 1.22.6 [v3] All builds and tests succeeded. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1290#pullrequestreview-1741393495
Re: RFR: 8319996: Update to GCC 13.2.0 on Linux [v2]
On Wed, 15 Nov 2023 12:35:50 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match >> JDK 22. >> >> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8319996-gcc-13.2 > - 8319996: Update to GCC 13.2.0 on Linux Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1286#pullrequestreview-1733629767
Re: RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows [v2]
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from >> 17.5.0) to match JDK 22. >> >> I've run headless and headful tests. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8319762-vs2022-17.6.5 > - 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1285#pullrequestreview-1730826931
Re: RFR: 8318984: Update to Xcode 14.3.1 on macOS
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote: > This PR updates the micro version of the compiler on macOS to 14.3.1 (from > 14.3) to match JDK 22. > > I've run headless and headful tests. Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1284#pullrequestreview-1729599986
Re: RFR: 8317508: Provide media support for libavcodec version 60
On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only x86. Without "--disable-asm" > I had issue building ffmpeg 6.0 on Ubuntu 23.10 most likely due to compiler > version. Disabling assembler optimization fixed issue and we do not need this > anyway for our stubs. Builds and tests ran successfully. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1259#pullrequestreview-1685102383
Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]
On Wed, 11 Oct 2023 03:58:01 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into python_update > - change minimum version for mac to 3.6 > - Add check for python version for various platforms Looking fine! - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1205#pullrequestreview-1684894023
Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revision: > > Update the documentation in UPDATING-VERSION.md Tested on our build infrastructure and build and tests all worked fine. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1253#pullrequestreview-1678081796
Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]
On Mon, 7 Aug 2023 04:18:31 GMT, Hima Bindu Meda wrote: >> Cherry-picked commits from webkitgtk-2.40.5. >> Verified build on windows, mac and linux. Sanity testing looks fine. No >> issues seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Correct indentation All tests ran fine here too. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1196#pullrequestreview-1564901998
Re: RFR: JDK-8310681: Update WebKit to 616.1 [v2]
On Mon, 24 Jul 2023 12:43:57 GMT, Hima Bindu Meda wrote: >> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). >> Verified the updated version build, sanity tests and stability. No issues >> have been observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove check for PLATFORM(JAVA) as the change corresponds to webkit upstream After upgrading our version of python from 3.7 to 3.8 all builds and tests completed successfully. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1180#pullrequestreview-1551971281
Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows [v2]
On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). >> The solution for the failure is to compile 615.1 using the C++20 flag for >> Windows (we will use this flag on all platforms for the next WebKit update). >> The fix for that bug is necessarily included in this PR, since the two fixes >> as interdependent. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge remote-tracking branch 'upstream/master' into 8308308-vs2022-17.5.0 > - 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows > - enable c++20 for windows and c++17 for other platforms We still used an older version of cmake and updating it to 3.22.3 fixed the issue. Everything works fine now. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1142#pullrequestreview-1455691681
Re: RFR: 8308307: Update to gcc 12.2.0 on Linux
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote: > Update the compiler on Linux to gcc 12.2. This provides the needed C++20 > support for the next WebKit update. Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1141#pullrequestreview-1451215901
Re: RFR: 8308306: Update to Xcode 14.3 on macOS [v2]
On Thu, 25 May 2023 16:30:38 GMT, Kevin Rushforth wrote: >> Update the compiler on macOS to Xcode 14.3. In addition to providing the >> needed C++20 support for the next WebKit update, initial testing by the JDK >> team shows that this fixes a reproducible builds problem, so it might help >> address [JDK-8306886](https://bugs.openjdk.org/browse/JDK-8306886). >> >> Xcode 14.3 requires macOS 13 Ventura to build (although it is known to build >> on macOS 12 Monterey, which might be useful for developer builds). The >> generated JavaFX code will run on older versions of macOS. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into 8308306-xcode-14.3 > - Bump the MacOSX SDK to 13.3 to match the SDK included with Xcode 14.3 > - 8308306: Update to Xcode 14.3 on macOS Marked as reviewed by sykora (Author). - PR Review: https://git.openjdk.org/jfx/pull/1140#pullrequestreview-1451215162
Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The > solution for the failure is to compile 615.1 using the C++20 flag for Windows > (we will use this flag on all platforms for the next WebKit update). The fix > for that bug is necessarily included in this PR, since the two fixes as > interdependent. I still get the same error when building with Windows SDK version `10.0.22621` (was using `10.0.22000` before). This is our output of the lines you pasted: -- The C compiler identification is MSVC 19.35.32215.0 -- The CXX compiler identification is MSVC 19.35.32215.0 -- Check for working C compiler: C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- Check for working C compiler: C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- The CMake build type is: Release -- Found Perl: C:/cygwin64/bin/perl.exe (found suitable version "5.32.1", minimum required is "5.10.0") -- Found PerlModules: TRUE found components: English FindBin JSON::PP -- Found Python: C:/cygwin64/bin/python3.8.exe (found version "3.8.10") found components: Interpreter -- Could NOT find Ruby (missing: RUBY_INCLUDE_DIR RUBY_LIBRARY RUBY_CONFIG_INCLUDE_DIR) (found suitable version "2.6.4", minimum required is "1.9") -- Enabling ccache: Couldn't find ccache program. Not enabling it. For reference, I'll paste the full error message below: FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-66f79d8a-1.cpp.obj C:\PROGRA~2\MICROS~1\2022\175~1.0\VC\Tools\MSVC\1435~1.322\bin\Hostx64\x64\cl.exe /nologo /TP -DBUILDING_JAVA__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DDATA_DIR="share" -DHAVE_CONFIG_H=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DIMAGEIO=1 -DLIBXML_STATIC -DLIBXSLT_STATIC -DMAX_DOM_TREE_DEPTH=2000 -DNOMINMAX -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_JavaScriptCore -DSTATICALLY_LINKED_WITH_PAL -DSTATICALLY_LINKED_WITH_WTF -DUNICODE -DUSE_SYSTEM_MALLOC -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DWINVER=0x601 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WINDOWS -D_WINSOCKAPI_="" -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\platform\java -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\platform\graphics\java -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\S ource\WebCore\platform\linux -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\platform\network -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\platform\network\java -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\bindings\java -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\page\java -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\bridge\jni -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebKitLegacy -I\gensrc\headers\javafx.web -I. -IWebCore\DerivedSources -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\sr c\main\native\Source\WebCore\Modules\webgpu -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\Modules\airplay -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\Modules\applepay -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\Modules\applepay\paymentrequest -IC:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Sourc
Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The > solution for the failure is to compile 615.1 using the C++20 flag for Windows > (we will use this flag on all platforms for the next WebKit update). The fix > for that bug is necessarily included in this PR, since the two fixes as > interdependent. When building this, I no longer get the compile error that is mentioned in the JBS issue, but instead I get this error: WTF\Headers\wtf/RefPtr.h(42): error C2027: use of undefined type 'WebCore::Text' C:\jenkins\workspace\OpenJFX-build-windows-x86_64\repo\modules\javafx.web\src\main\native\Source\WebCore\style\StyleUpdate.h(41): note: see declaration of 'WebCore::Text' I am using compiler version `14.35.32215` (from VS 2022 17.5.0). - PR Comment: https://git.openjdk.org/jfx/pull/1142#issuecomment-1563367313
Re: RFR: 8308306: Update to Xcode 14.3 on macOS
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote: > Update the compiler on macOS to Xcode 14.3. In addition to providing the > needed C++20 support for the next WebKit update, initial testing by the JDK > team shows that this fixes a reproducible builds problem, so it might help > address [JDK-8306886](https://bugs.openjdk.org/browse/JDK-8306886). > > Xcode 14.3 requires macOS 13 Ventura to build (although it is known to build > on macOS 12 Monterey, which might be useful for developer builds). The > generated JavaFX code will run on older versions of macOS. Just for clarity, the preferred macos SDK will remain at 11.1: https://github.com/openjdk/jfx/blob/master/buildSrc/mac.gradle#L53? - PR Comment: https://git.openjdk.org/jfx/pull/1140#issuecomment-1562995480
Re: RFR: 8306115 : Update libxml2 to 2.10.4
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and > Mac. > Sanity testing looks fine. Builds and tests completed without issues. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1108#pullrequestreview-1399391429
Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". > > Root cause: The number of build threads more than 8, causing a > synchronization issue for builtins_generate_separate_header.py, the file > needs to be copied before use at build dir > > Solution: Use the sleep of 1 second and retry 10 times to copy in > CMakeList.txt and execute using the execute_process cmake command Everything still works here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1073#pullrequestreview-1370814874
Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v4]
On Mon, 3 Apr 2023 18:50:57 GMT, Hima Bindu Meda wrote: >> In Jenkins Build, the intermediate failure on windows is observed due to >> crash in mspdbserv.exe, which generates Program database (.pdb) files. >> Disabled the pdb file generation in order to resolve the build failure. >> Sanity testing looks fine. Verified build on windows, mac and linux. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Update proper comment All builds and tests succeeded here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1079#pullrequestreview-1370644246
Re: RFR: 8301009: Update libxml2 to 2.10.3
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. Building and running tests worked on windows, linux and macos. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1058
Re: RFR: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. Building and testing completed without issues. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1038
Re: RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes
On Tue, 14 Feb 2023 18:19:17 GMT, Hima Bindu Meda wrote: > Cherry-pick stabilisation fixes till 2.38.4. > Verified unit tests and drt. No issue observed. Building and testing succeeded. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1033
Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v3]
On Wed, 1 Feb 2023 04:11:48 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while playing youtube >> >> The above issues are recorded and ignored using below bugs: >> [JDK-8300954](https://bugs.openjdk.org/browse/JDK-8300954) >> [JDK-8301022](https://bugs.openjdk.org/browse/JDK-8301022) > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Remove the log added for testing purpose Marked as reviewed by sykora (Author). - PR: https://git.openjdk.org/jfx/pull/1011
Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v2]
On Mon, 30 Jan 2023 15:11:20 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while playing youtube >> >> The above issues are recorded and ignored using below bugs: >> [JDK-8300954](https://bugs.openjdk.org/browse/JDK-8300954) >> [JDK-8301022](https://bugs.openjdk.org/browse/JDK-8301022) > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Add blank lines Building and testing succeeded on linux, mac and windows x86_64. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1011
Re: RFR: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
On Thu, 7 Jul 2022 23:16:12 GMT, Kevin Rushforth wrote: > On Windows platforms we redistribute the Visual Studio runtime libraries with > the JavaFX build so that JavaFX applications can run on systems that don't > have them installed already. The main C++ runtime library is `msvcp140.dll`, > which we ship along with the other native libraries for JavaFX. Additional > C++ functionality has been added to `msvcp140_1.dll` and `msvcp140_2.dll`, > neither of which are shipped. > > Recently, WebKit has started using some standard C++ functions that are only > found in `msvcp140_2.dll`. We need to include the two missing libraries as > part of the JavaFX build (in addition to `msvcp140.dll`, which is already > included). Marked as reviewed by sykora (Author). - PR: https://git.openjdk.org/jfx/pull/818
