Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Fri, 3 Feb 2023 08:44:53 GMT, Johan Vos wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > I'm ok with this. > Apart from the functionality, this BP also makes it easier to backport future > changes in build.gradle (because it backports a structural change in the > 64-bit "detection") Thanks, @johanvos ! Let's wait for a while to see if @kevinrushforth has further comments. - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Marked as reviewed by jvos (Reviewer). I'm ok with this. Apart from the functionality, this BP also makes it easier to backport future changes in build.gradle (because it backports a structural change in the 64-bit "detection") - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Tue, 31 Jan 2023 13:19:56 GMT, Ao Qi wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > RFC and RFR. Thanks. Should I take this PR out of Draft? @theaoqi Yes, if you take it out of draft, I'll review it. - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. RFC and RFR. Thanks. Should I take this PR out of Draft? - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote: >> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. > > Backports to `jfx17u` require prior approval. You will need to seek such > approval from one of the project leads before taking this PR out of Draft. > > If it is approved, the timing is such that it needs to wait for about two > weeks. It could possibly be slated for JavaFX 17.0.7 (the April CPU release), > since it is far too late to make any changes for 17.0.6. Thanks a lot for the quick advice, @kevinrushforth. I will further learn how to do the backports to `jfx17u`. Also, this backport is not in a hurry. Let's wait for the release of `17.0.6`. I don't want to bother with the new releasing version:) - PR: https://git.openjdk.org/jfx17u/pull/102
Re: [jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote: > Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. Backports to `jfx17u` require prior approval. You will need to seek such approval from one of the project leads before taking this PR out of Draft. If it is approved, the timing is such that it needs to wait for about two weeks. It could possibly be slated for JavaFX 17.0.7 (the April CPU release), since it is far too late to make any changes for 17.0.6. - PR: https://git.openjdk.org/jfx17u/pull/102
[jfx17u] RFR: 8293214: Add support for Linux/LoongArch64
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64. - Commit messages: - 8293214: Add support for Linux/LoongArch64 Changes: https://git.openjdk.org/jfx17u/pull/102/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=102&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293214 Stats: 26 lines in 4 files changed: 15 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jfx17u/pull/102.diff Fetch: git fetch https://git.openjdk.org/jfx17u pull/102/head:pull/102 PR: https://git.openjdk.org/jfx17u/pull/102
