Re: [jfx17u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-03-01 Thread Johan Vos
On Thu, 29 Feb 2024 15:48:30 GMT, Jose Pereda  wrote:

> Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel 
> from IME calls on macOS
> 
> Reviewed-by: jbhaskar, arapte
> 
> Very minor conflicts after cherry picking the commit:
> 
>  // InputMethodRequests implementation
> +<<< HEAD
> +===
> ...
>  @Override
> +>>> 40809a3f84 (8322703: Intermittent crash in WebView in a JFXPanel 
> from IME calls on macOS)
>  public Point2D getTextLocation(int offset) {
> 
> 
> I fixed it manually, and pushed the change.

Marked as reviewed by jvos (Reviewer).

-

PR Review: https://git.openjdk.org/jfx17u/pull/179#pullrequestreview-1910678848


[jfx17u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-02-29 Thread Jose Pereda
Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel 
from IME calls on macOS

Reviewed-by: jbhaskar, arapte

-

Commit messages:
 - 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

Changes: https://git.openjdk.org/jfx17u/pull/179/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx17u=179=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322703
  Stats: 63 lines in 1 file changed: 34 ins; 18 del; 11 mod
  Patch: https://git.openjdk.org/jfx17u/pull/179.diff
  Fetch: git fetch https://git.openjdk.org/jfx17u.git pull/179/head:pull/179

PR: https://git.openjdk.org/jfx17u/pull/179