Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v5]

2023-02-07 Thread Kevin Rushforth
On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker  wrote:

>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressed review comments

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.org/jfx/pull/1025


Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v5]

2023-02-07 Thread John Hendrikx
On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker  wrote:

>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressed review comments

Marked as reviewed by jhendrikx (Committer).

-

PR: https://git.openjdk.org/jfx/pull/1025


Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v5]

2023-02-07 Thread Andy Goryachev
On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker  wrote:

>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressed review comments

definitely an improvement, thank you.

-

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/1025


Re: [jfx20] RFR: 8293587: Fix mistakes in FX API docs [v5]

2023-02-07 Thread Nir Lisker
> Fixes and cleanup in the areas in the linked issue.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  Addressed review comments

-

Changes:
  - all: https://git.openjdk.org/jfx/pull/1025/files
  - new: https://git.openjdk.org/jfx/pull/1025/files/a5632000..328bdebc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx=1025=04
 - incr: https://webrevs.openjdk.org/?repo=jfx=1025=03-04

  Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1025.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/1025/head:pull/1025

PR: https://git.openjdk.org/jfx/pull/1025