[jfx17u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
On Thu, 29 Feb 2024 15:48:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel
> from IME calls on macOS
>
> Reviewed-by: jbhaskar, arapte
>
> Very minor conflicts after cherry picking the commit:
>
> // InputMethodRequests implementation
> +<<< HEAD
> +===
> ...
> @Override
> +>>> 40809a3f84 (8322703: Intermittent crash in WebView in a JFXPanel
> from IME calls on macOS)
> public Point2D getTextLocation(int offset) {
>
>
> I fixed it manually, and pushed the change.
This pull request has now been integrated.
Changeset: c54a9ed3
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commit/c54a9ed3e91dad2d0b06302d75387882310b3fe6
Stats: 63 lines in 1 file changed: 34 ins; 18 del; 11 mod
8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
Reviewed-by: jvos
Backport-of: 40809a3f84d5f9f91b265f455a95d045e5b4f692
-
PR: https://git.openjdk.org/jfx17u/pull/179
[jfx21u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
On Thu, 29 Feb 2024 09:22:38 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backported was authored by Kevin Rushforth on 30 Jan 2024 > and was reviewed by Jay Bhaskar and Ambarish Rapte. > > Thanks! This pull request has now been integrated. Changeset: 61d9c36e Author:Jose Pereda URL: https://git.openjdk.org/jfx21u/commit/61d9c36ece644a4a17e018588833ef0aea8b6743 Stats: 62 lines in 1 file changed: 33 ins; 18 del; 11 mod 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS Reviewed-by: jvos Backport-of: 40809a3f84d5f9f91b265f455a95d045e5b4f692 - PR: https://git.openjdk.org/jfx21u/pull/45
[jfx22u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
On Tue, 30 Jan 2024 16:57:37 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u (for 22.0.1). This pull request has now been integrated. Changeset: 37695a2c Author:Kevin Rushforth URL: https://git.openjdk.org/jfx22u/commit/37695a2ce89d90ca0e1a3bb1d8d7547669b7f2e7 Stats: 62 lines in 1 file changed: 33 ins; 18 del; 11 mod 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS Backport-of: 40809a3f84d5f9f91b265f455a95d045e5b4f692 - PR: https://git.openjdk.org/jfx22u/pull/8
Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS
On Fri, 5 Jan 2024 23:59:31 GMT, Kevin Rushforth wrote: > As noted in the JBS bug, this is a follow-on to > [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered > while testing the fix for > [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in the > IME code when using WebView in a JFXPanel on macOS). > > I have tested this in connection with with the proposed fix for JDK-8221261, > although it is a valid fix regardless. > > This expands the fix done in > [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) to call all of the > WebKit methods on the right thread. Additionally, we sometimes see spurious > exceptions where the committed text is coming back as null, so I changed the > log level to "fine" rather than "severe" for those exceptions. I'll file a > follow-up bug to see if any of these are real problems or not. This pull request has now been integrated. Changeset: 40809a3f Author:Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692 Stats: 62 lines in 1 file changed: 33 ins; 18 del; 11 mod 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS Reviewed-by: jbhaskar, arapte - PR: https://git.openjdk.org/jfx/pull/1321
