Re: Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-02-01 Thread Kevin Rushforth
And thank you for raising the issue and answering the questions we had 
concerning the use case.


This will be in the next promoted build, JavaFX 22+28 (as well as JavaFX 
23+3).


-- Kevin


On 2/1/2024 12:42 AM, Jurgen Doll wrote:


A big THANK YOU to everybody that was part of this process.
It's very much appreciated !

Regards
Jurgen


On Tue, 30 Jan 2024 11:27:44 +0200, Nir Lisker  
wrote:


On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker  
wrote:


Added a utility method to run code on the FX thread if it's not 
already, and changed the animation methods to use it.


This pull request has now been integrated.

Changeset: c5ab220b
Author:    Nir Lisker 
URL: 
https://git.openjdk.org/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f

Stats: 422 lines in 7 files changed: 225 ins; 148 del; 49 mod

8324658: Allow animation play/start/stop/pause methods to be called 
on any thread


Reviewed-by: kcr, jpereda

-

PR: https://git.openjdk.org/jfx/pull/1352




Re: Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-02-01 Thread Jurgen Doll



A big THANK YOU to everybody that was part of this process.
It's very much appreciated !

Regards
Jurgen


On Tue, 30 Jan 2024 11:27:44 +0200, Nir Lisker  wrote:


On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker  wrote:

Added a utility method to run code on the FX thread if it's not  
already, and changed the animation methods to use it.


This pull request has now been integrated.

Changeset: c5ab220b
Author:Nir Lisker 
URL:
https://git.openjdk.org/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f

Stats: 422 lines in 7 files changed: 225 ins; 148 del; 49 mod

8324658: Allow animation play/start/stop/pause methods to be called on  
any thread


Reviewed-by: kcr, jpereda

-

PR: https://git.openjdk.org/jfx/pull/1352


[jfx22] Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Tue, 30 Jan 2024 12:08:41 GMT, Nir Lisker  wrote:

> Hi all,
> 
> This pull request contains a backport of commit 
> [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f)
>  from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
> 
> The commit being backported was authored by Nir Lisker on 30 Jan 2024 and was 
> reviewed by Kevin Rushforth and Jose Pereda.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 648dfd54
Author:Nir Lisker 
URL:   
https://git.openjdk.org/jfx/commit/648dfd540cde6bc8127df333fe30b2cac5b022e6
Stats: 422 lines in 7 files changed: 225 ins; 148 del; 49 mod

8324658: Allow animation play/start/stop/pause methods to be called on any 
thread

Reviewed-by: kcr
Backport-of: c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f

-

PR: https://git.openjdk.org/jfx/pull/1354


Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker  wrote:

> Added a utility method to run code on the FX thread if it's not already, and 
> changed the animation methods to use it.

This pull request has now been integrated.

Changeset: c5ab220b
Author:Nir Lisker 
URL:   
https://git.openjdk.org/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f
Stats: 422 lines in 7 files changed: 225 ins; 148 del; 49 mod

8324658: Allow animation play/start/stop/pause methods to be called on any 
thread

Reviewed-by: kcr, jpereda

-

PR: https://git.openjdk.org/jfx/pull/1352